Visit Our UNIX and Linux User Community


While loop


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting While loop
# 1  
Old 10-09-2009
While loop

Hello friends

Please put some light where i am wrong

My functionality is like for first time it must do echo "tar -Cvf"
and after that till end of file b.txt it must do tar -rvf.


Code:
counter=0
while read EachLine do
z=$(awk -F"," '{ print $4"_"$2}' b.txt)
echo $z
echo "tar -Cvf"
      if [ "$counter" > 0 ]
         then
         echo " tar -rvf process"
      fi
     counter=`expr $counter + 1`
     echo $counter
done < b.txt


Last edited by Franklin52; 10-09-2009 at 09:27 AM.. Reason: Please use code tags!
# 2  
Old 10-09-2009
Im maybe half asleep...
What is EachLine?
(except in the while you dont seem to use it... and its reading from where?)
# 3  
Old 10-09-2009
I think we need to see the contents of file b.txt and the expected output. There appears to be some confusion in the script about when to use a filename and when to use a variable.

Also "tar -Cvf" should probably be "tar -cvf".
# 4  
Old 10-13-2009
Quote:
Originally Posted by methyl
I think we need to see the contents of file b.txt and the expected output. There appears to be some confusion in the script about when to use a filename and when to use a variable.

Also "tar -Cvf" should probably be "tar -cvf".

Guys for more detail please find the code
b.txt contents:
Object (,BDRJX648,001,T_BDRTARGE,BDRXTRSDS,001) extracted
Object (,BDRMX100,001,T_BDRTARG2,BDRXTR,001) extracted


Code:
Code:
function pln
{
echo   "TO EXPORT PLANNIFICATION GIVE PLANNIFICATION NAME IN THE input.txt and Management unit in the mu.txt and PRESS Y EX:BDRMX100"
echo   "TO GO BACK PRESS 99"
read parm0
if [ "$parm0" == "99" ];
then
start
elif [ "$parm0" == "Y" ];
then
while read EachRecord
do
s=`echo $EachRecord | cut -d " " -f1`
p=`echo $EachRecord | cut -d " " -f2`
echo $s
echo $p
$UXEXE/uxext tsk ses=$s vses=* upr=* model mu=$p output=${p}_$s.pnf APP | tee -a log.txt
sed 's;^ *;;;s; *, *;,;g;s; *$;;' log.txt > b.txt
done < input.txt
counter=0
while read z
do
z=$(awk -F"," '{ print $4"_"$2}' b.txt)
echo $z
#tar -cvf plannification.tar ${m}_${n}.pnf
echo "tar -Cvf"
if [ "$counter" > 0 ]
then
    #tar -rvf plannification.tar ${m}_$n.pnf
    echo " tar -rvf process"
else
    echo "Tar CVF"
fi
counter=`expr $counter + 1`
echo $counter
done < b.txt
fi
}




o/p:
BDRJX648
T_BDRTARGE
Object ( , BDRJX648  , 001, T_BDRTARGE, BDRXTRSDS , 001) extracted              
BDRMX100
T_BDRTARG2
Object ( , BDRMX100  , 001, T_BDRTARG2, BDRXTR    , 001) extracted              
T_BDRTARGE_BDRJX648 T_BDRTARG2_BDRMX100
tar -Cvf
 tar -rvf process
1
T_BDRTARGE_BDRJX648 T_BDRTARG2_BDRMX100
tar -Cvf
 tar -rvf process
2


PROBLM:While loop must do first time tar -cvf and after for all values of z it must do tar -rvf



---------- Post updated at 12:06 PM ---------- Previous update was at 11:16 AM ----------

Quote:
Originally Posted by methyl
I think we need to see the contents of file b.txt and the expected output. There appears to be some confusion in the script about when to use a filename and when to use a variable.

Also "tar -Cvf" should probably be "tar -cvf".
That is ok it is just a echo command to display msg not a problem

Last edited by kojo; 10-13-2009 at 04:42 AM.. Reason: code tags please...
# 5  
Old 10-13-2009
Had to indent to follow the if and while statements. Still found it difficult to follow.
Where you have "start", do you mean "return" (exit from a function).

There are two issues in the counter loop:
1) You are reading file b.txt line by line into variable $z, then immediately reading the first line of b.txt and formatting it into $z. I think you meant to process each line of b.txt in turn.
2) $counter is a number. We should use numeric comparisons. It is conventional to increment a counter at the start of a loop.
3) Though in commented out lines I can't see where $m and $n come from unless ${m}_${n} is now ${z} ?
4) Overall I'm suggesting some changes without testing them or really understanding what you are doing.


Code:
function pln
{
echo   "TO EXPORT PLANNIFICATION GIVE PLANNIFICATION NAME IN THE input.txt and Management unit in the mu.txt and PRESS Y EX:BDRMX100"
echo   "TO GO BACK PRESS 99"
read parm0
if [ "$parm0" == "99" ]
then
     start
elif [ "$parm0" == "Y" ]
then
     while read EachRecord
     do
          s=`echo $EachRecord | cut -d " " -f1`
          p=`echo $EachRecord | cut -d " " -f2`
          echo $s
          echo $p
          $UXEXE/uxext tsk ses=$s vses=* upr=* model mu=$p output=${p}_$s.pnf APP | tee -a log.txt
          sed 's;^ *;;;s; *, *;,;g;s; *$;;' log.txt > b.txt
     done < input.txt
     #
     #
     counter=0
     awk -F"," '{ print $4"_"$2}' b.txt | while read z
     do
          echo $z
          counter=`expr $counter + 1`
          echo $counter
          # First time through we create tar archive.
          # Second and subsequent times we append to tar archive.
          if [ $counter -eq 1 ]
          then
               #tar -cvf plannification.tar ${m}_${n}.pnf
               echo "tar -cvf process"
          else
               #tar -rvf plannification.tar ${m}_${n}.pnf
               echo "tar -rvf process"
          fi
      done
fi
}


Last edited by methyl; 10-13-2009 at 04:56 PM.. Reason: Layout , remove some surplus semi-colons
# 6  
Old 10-14-2009
Plz find the entire code
Code:
function ext
{
echo "THANKS & WELCOME BACK"
}

function upc
{
echo   "TO EXPORT UPROC GIVE UPROC NAME PER LINE IN THE input.txt and PRESS Y"
echo   "TO GO BACK PRESS 99"
read parm0
 if [ "$parm0" == "99" ];
 then
 start
 elif [ "$parm0" == "Y" ];
 then
  for i in `cat input.txt` ; do
  echo $i 
  $UXEXE/uxext upr upr=$i output=$i.upr APP

#if [ $? --ne 0 ]
#    then 
#        err_msg="command is unsuccessfull>"     
#        eval ERREUR
#     fi 
  echo "$output UPROC exported"
  done
 fi
}

function ses
{
echo   "TO EXPORT SESSION GIVE SESSION NAME PER LINE IN THE input.txt and PRESS Y"
echo   "TO GO BACK PRESS 99"
read parm0
 if [ "$parm0" == "99" ];
 then
 start
 elif [ "$parm0" == "Y" ];
 then
  for i in `cat input.txt` ; do
  echo $i 
  $UXEXE/uxext ses ses=$i output=$i.ses APP
  echo "$output SESSION exported"
  done
 fi
}

function pln
{ 
  echo   "TO EXPORT PLANNIFICATION GIVE PLANNIFICATION NAME IN THE input.txt and Management unit in the mu.txt and PRESS Y EX:BDRMX100"
  echo   "TO GO BACK PRESS 99"
  read parm0
   if [ "$parm0" == "99" ];
    then
     start
      elif [ "$parm0" == "Y" ];
       then
        while read EachRecord
         do
          s=`echo $EachRecord | cut -d " " -f1`
          p=`echo $EachRecord | cut -d " " -f2`
          $UXEXE/uxext tsk ses=$s vses=* upr=* model mu=$p output=${p}_$s.pnf APP | tee -a log.txt
          sed 's;^ *;;;s; *, *;,;g;s; *$;;' log.txt > b.txt
         done < input.txt
   fi

      counter=0
      for j in $(cat b.txt) ; do
      echo $j
      echo "for loop start"
      echo $j
      if [ "$counter" < 1 ] ;
      then
      echo "if start"
      #z=$(awk -F"," '{ print $4"_"$2}' b.txt)
      #tar -cvf plannification.tar ${m}_${n}.pnf
      counter=`expr $counter + 1`
      echo "tar -cvf"
      else
      echo "tar -rvf"
      fi
      done
}

function start 
{
echo      "FOR UPROC EXPORT PRESS 1"
echo      "FOR SESSION EXPORT PRESS 2"
echo      "FOR PLANNIFICATION EXPORT PRESS 3"
echo      "TO EXIT PRESS 99"
read option1
if [ "$option1" == "1" ];
then
upc
elif [ "$option1" == "2" ];
then
ses
elif [ "$option1" == "3" ];
then
pln
elif [ "$option1" == "99" ];
then
ext
fi
}
echo "                                                                               *****WELCOME******                                   "
echo "                                                                           PLEASE PRESS 0 FOR DETAILS                          "
echo "                                                                              TO EXIT PRESS 99                                      "
read option
if [ "$option" == "99" ];
then
ext
elif [ "option" == "0" ];
echo "In start function"
then
start
fi


Last edited by pludi; 10-14-2009 at 07:01 AM.. Reason: code tags, please...

Previous Thread | Next Thread
Test Your Knowledge in Computers #798
Difficulty: Medium
To convert from a base-10 integer to its base-2 (binary) equivalent, the number is divided by two and the remainder is the least-significant bit.
True or False?

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

For loop or while loop from a text file

Hi all, i developed a script to measure the uptime of a process in a Solaris 10/11 environments. All is well, but i came across a situation where there are multiple processes of the same name. Basically i have the following result file: beVWARS 13357 19592122 beVWARS 14329 19591910... (4 Replies)
Discussion started by: nms
4 Replies

2. Shell Programming and Scripting

awk loop using array:wish to store array values from loop for use outside loop

Here's my code: awk -F '' 'NR==FNR { if (/time/ && $5>10) A=$2" "$3":"$4":"($5-01) else if (/time/ && $5<01) A=$2" "$3":"$4-01":"(59-$5) else if (/time/ && $5<=10) A=$2" "$3":"$4":0"($5-01) else if (/close/) { B=0 n1=n2; ... (2 Replies)
Discussion started by: klane
2 Replies

3. Shell Programming and Scripting

Reset while loop to loop same file multiple times

Hi, I want to read file multiple times. Right now i am using while loop but that is not working. ex. While read line do while read line2 do echo stmt1 #processing some data based on data., done < file2.txt done < file1.txt # This will have 10... (4 Replies)
Discussion started by: tmalik79
4 Replies

4. Shell Programming and Scripting

Array Variable being Assigned Values in Loop, But Gone when Loop Completes???

Hello All, Maybe I'm Missing something here but I have NOOO idea what the heck is going on with this....? I have a Variable that contains a PATTERN of what I'm considering "Illegal Characters". So what I'm doing is looping through a string containing some of these "Illegal Characters". Now... (5 Replies)
Discussion started by: mrm5102
5 Replies

5. Shell Programming and Scripting

My for loop decides to become an infinite loop?

Hi, I was debating if I should put this in the dummies or scripts section, I apologize in advance if I chose poorly. Fairly new to Unix and BASH scripting but I thought I made it fairly well given my limited understanding. However, the output indicates that it's looping and I'm ending up with a... (5 Replies)
Discussion started by: gotreef
5 Replies

6. Shell Programming and Scripting

S# in a for loop - concatenate $(loop counter)

Hi, hope I am posting in the right section. My problem is that I have 2 or more arguments passed and I want to check if the arguments passed exists or not. The first argument should not exist and the remaining others should exist. example: ./shells.sh argument1 argument2 argument3 ... (5 Replies)
Discussion started by: fight4love
5 Replies

7. Shell Programming and Scripting

BASH loop inside a loop question

Hi all Sorry for the basic question, but i am writing a shell script to get around a slightly flaky binary that ships with one of our servers. This particular utility randomly generates the correct information and could work first time or may work on the 12th or 100th attempt etc !.... (4 Replies)
Discussion started by: rethink
4 Replies

8. Shell Programming and Scripting

Null Handling in Until loop. . .loop won't stop

Hi Im running this script, which is supposed to find the max value build some tables and then stop running once all the tables are built. Thing is , it keeps assigning a null value to $h and then $g is null so it keep building tables i.e. testupdateNUL. How can I stop this? Here is what I have: ... (4 Replies)
Discussion started by: brandono66
4 Replies

9. Shell Programming and Scripting

Using variables created sequentially in a loop while still inside of the loop [bash]

I'm trying to understand if it's possible to create a set of variables that are numbered based on another variable (using eval) in a loop, and then call on it before the loop ends. As an example I've written a script called question (The fist command is to show what is the contents of the... (2 Replies)
Discussion started by: DeCoTwc
2 Replies

10. Shell Programming and Scripting

Is there a better way I could have run this loop. (For loop with two variables)

Sorry for such a dreadful title, but I'm not sure how to be more descriptive. I'm hoping some of the more gurutastic out there can take a look at a solution I came up with to a problem, and advice if there are better ways to have gone about it. To make a long story short around 20K pieces of... (2 Replies)
Discussion started by: DeCoTwc
2 Replies

Featured Tech Videos