Shell Programming and Scripting

I have a ping script I use on an old Open Step box (I guess its closely related to Mac OS X) and it runs fine, but now I built a system as a backup with Ubuntu 8.10 client and the script needs to be adapted a bit. Can anyone see where or how this needs to be done? The script starts and assigns the variables, but chokes on the ping portion of it which I think is syntax related

There are a few places where the end of the line is missing due to my copy and paste, but the main ping part that's broke is all there. I am hoping there is a substitution or something obvious I need to make throughout the script that will make it work again. Thanks!

Script
[CODE]#!/bin/sh

#[Path Statement]
PATH=/etc:/usr/etc:/usr/ucb:/bin:/usr/bin:/usr/local/bin:/usr/local/etc
SCRIPTNAME=`basename $0`

[Make Server List To Ping]
#this is the server list, with IP's and IP of the router
echo making server list
cat<<_EOF > /tmp/$SCRIPTNAME.serverlist
Albany1 xx.xx.xx.xx xx.xx.xx.1
_EOF

Code:

# establish the data directory
# function to ping the server. 
# if the server doesn't respond, find out if it is because the network
# leading to it is down.
# optionally specify the number of pings to send. default is 1.
# if more than one ping is sent, a response to any of the packets is
# considered up. down is only 100% packet loss.
#[PING PORTION]
sping()
{
NAME=$1
IP=$2
ROUTER=$3
if [ -n "$4" ]; then 
COUNT=$4
else
COUNT=1
fi
if ping $IP -c "$COUNT" | grep -s "100% packet loss"; then
if ping $ROUTER -c "$COUNT" | grep -s "100% packet loss"; then
echo "$NAME $IP $ROUTER (down because route to it is down)"
echo "$NAME $IP $ROUTER (down because route to it is down)" 1>&2
else
echo "$NAME $IP $ROUTER (down although route to it is up)"
echo "$NAME $IP $ROUTER (down although route to it is up)" 1>&2
fi
else
echo "$NAME $IP $ROUTER (up)"
echo "$NAME $IP $ROUTER (up)" 1>&2
fi
}

## [function to send the email notification with high or low importance]
notify()
{
echo "\n\nThis message sent by cron script /admin/scripts/crons/ping_servers.s
h on mpt1a01" > /tmp/$SCRIPTNAME.serverlist.explain
echo "Subject: RCP server stats\nImportance: $1 \n\n" | cat - /tmp/$SCRIPTNAME
.serverlist.upagain /tmp/$SCRIPTNAME.serverlist.wentdown /tmp/$SCRIPTNAME.server
list.stilldown /tmp/$SCRIPTNAME.serverlist.explain | /usr/lib/sendmail sam.lman@sbcglobal.net
cat /tmp/$SCRIPTNAME.serverlist.upagain /tmp/$SCRIPTNAME.serverlist.wentdown |
logger -t "ping_servers.sh" -p local4.err
}


# [make a list of servers that were down last time this script was run]
touch /admin/scripts/crons/$SCRIPTNAME.serverlist.down /admin/scripts/crons/$SC
RIPTNAME.serverlist.downlastrun
cp /admin/scripts/crons/$SCRIPTNAME.serverlist.down /admin/scripts/crons/$SCRI
PTNAME.serverlist.downlastrun

# [ping all the servers and accumulate a retry list]
echo pinging all the servers and accumulating a retry list
>/tmp/$SCRIPTNAME.serverlist.retry
while read NAME IP ROUTER
do
sping $NAME $IP $ROUTER | grep "(down" >>/tmp/$SCRIPTNAME.serverlist.retry
done</tmp/$SCRIPTNAME.serverlist


# [wait before retrying the down servers]
if [ -s /tmp/$SCRIPTNAME.serverlist.retry ]; then
echo waiting before retrying the down servers
sleep 10
else
echo no servers down
exit
fi


# [ping all the down servers with more packets to make sure they are down]
echo retrying down servers with more packets
> /admin/scripts/crons/$SCRIPTNAME.serverlist.down
while read NAME IP ROUTER OTHER
do
sping $NAME $IP $ROUTER 5 | grep "(down" >> /admin/scripts/crons/$SCRIPTNAME.s
erverlist.down
done</tmp/$SCRIPTNAME.serverlist.retry

# [look for differences]
# in this section, we are looking for what servers just went down,
# which ones just came back up, and which ones are still down from before
echo lists of recent downs and returns, and servers that remain down
>/tmp/$SCRIPTNAME.serverlist.wentdown
>/tmp/$SCRIPTNAME.serverlist.stilldown
>/tmp/$SCRIPTNAME.serverlist.upagain
while read NAME IP ROUTER
do
WASDOWN=`grep -w $NAME /admin/scripts/crons/$SCRIPTNAME.serverlist.downlastrun`
ISDOWN=`grep -w $NAME /admin/scripts/crons/$SCRIPTNAME.serverlist.down`
if [ -n "$WASDOWN" -a -n "$ISDOWN" ]; then
echo "$ISDOWN (still down)" >>/tmp/$SCRIPTNAME.serverlist.stilldown
fi
if [ -n "$WASDOWN" -a -z "$ISDOWN" ]; then
echo "$NAME $IP $ROUTER (up again)" >>/tmp/$SCRIPTNAME.serverlist.upagain
fi
if [ -z "$WASDOWN" -a -n "$ISDOWN" ]; then
echo "$ISDOWN (just went down)" >>/tmp/$SCRIPTNAME.serverlist.wentdown
fi
done</tmp/$SCRIPTNAME.serverlist
# cat /tmp/$SCRIPTNAME.serverlist.upagain /tmp/$SCRIPTNAME.serverlist.wentdown /
tmp/$SCRIPTNAME.serverlist.stilldown


# [if there are servers that just went down or came back up, notify with high importance]
if [ -s /tmp/$SCRIPTNAME.serverlist.upagain -o -s /tmp/$SCRIPTNAME.serverlist.we
ntdown ]; then
echo notifying of servers that are up again or just now down
notify high


# [if there is no new news, but servers are still down from before,
# notify only once per day, with low importance]
elif [ -s /tmp/$SCRIPTNAME.serverlist.stilldown ]; then
if [ "`date | awk '{print $4}' | awk -F: '{print $1}'`" -eq 11 ]; then
if [ ! -f /tmp/$SCRIPTNAME.stilldownsent ]; then
touch /tmp/$SCRIPTNAME.stilldownsent
echo notifying once today of servers that are still down from before
notify low
fi
else
echo not time for daily notification of servers that are still down
if [ -f /tmp/$SCRIPTNAME.stilldownsent ]; then
rm /tmp/$SCRIPTNAME.stilldownsent
fi
fi
else
echo no notification to make
fi

Have you read the man page for ping to see where its syntax differs from the Open Step version?

Please edit your post and fix those places; you can't expect accurate help if we can't see exactly what you are doing.

While you're at it, please enclose the script in [code] tags.

Which part is that?

Have you tried just executing those parts (substituing reasonable values for the variables)?

Thanks for your time. I have placed the entire script (minus a few clients) and have tried to add tags for each section (if I understood you correctly - I hope this makes it easier) and have also added space between the sections. I appreciate your time in looking at this. I'll have to review the man pages and see if something pops out at me. Dale

Thanks for your patience. Can you explain code tags (show me a small example?)and I will do my best to get them in there. Dale

Type [code] before your script and [/code ] (remove the space before the last ']') after it.

Or highlight the script and select the icon to add code tags.

I hope I did this right, I have added the code tags - I thought they should be whereever processing is done? Please let me know. Thanks for your time. Dale