BASH: getting a script to "do" what's after "done" Post: 302447945

Sponsored Content

Top Forums UNIX for Dummies Questions & Answers BASH: getting a script to "do" what's after "done" Post 302447945 by SilversleevesX on Tuesday 24th of August 2010 07:03:26 PM

08-24-2010

Registered User

Quote:

Originally Posted by Corona688

It's not supposed to do that -- something else is going on.

I don't think this is doing what you think it's doing:

Code:

if [[ $MANY == *PhotoFiltre* ]]

Asterisks there won't match against $MANY, they match against files like you're doing with "*.jpg". If you want a regular expression, bash 3.0 has a =~ regex operator so you can just do if [[ $MANY =~ PhotoFiltre ]] and see if it finds PhotoFiltre anywhere in the line.

Change #!/bin/bash to #!/bin/bash -x so it prints lines as it executes them so you can tell where the loop breaks and what it thinks it's doing.

Also,"for file in $(ls *.jpg)" can be more simply rewritten as "for file in *.jpg", no ls needed, no evaluation brackets needed. There's still a limit on the number of arguments however, so this kind of loop isn't appropriate for huge amounts of files.

It looks to me like it's starting the loop again for every file, but then I don't recall the last time I did an "-x" evaluation on a for-do-done loop, so....

A sample of the stdout:

Code:

+ sleep 0.2s
+ x=99
+ for file in '$(ls *.jpg)'
+ echo 'Evaluating  #99 of 171, hv7283-275.jpg...'
Evaluating  #99 of 171, hv7283-275.jpg...
+ sleep 0.2s
++ exiv2 -g Exif.Image.Software -Pv hv7283-275.jpg
+ MANY='Adobe Photoshop CS Windows'
+ [[ Adobe Photoshop CS Windows =~ PhotoFiltre ]]
+ echo -ne 'hv7283-275.jpg: No PhotoFiltre software tag found.\n\n'
hv7283-275.jpg: No PhotoFiltre software tag found.

I agree there's something else going on (it's been proven for me time and again that if a scripting "issue" can't be Google'd then it isn't an issue, and there's naught on this phenomenon, therefore....). Now that you've seen the snippet, any clue as to what?

Thanks for reminding me there was a weak(ening) ls in that "for" line. This script is a tweak on one that's about a year old, written during a short stint of not having an Internet connection. I still have a few like this.

BZT

Last edited by SilversleevesX; 08-24-2010 at 08:07 PM.. Reason: Replaced pre-edit snippet with post-.

SilversleevesX

View Public Profile for SilversleevesX

Find all posts by SilversleevesX

9 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Explain the line "mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'`"

Hi Friends, Can any of you explain me about the below line of code? mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'` Im not able to understand, what exactly it is doing :confused: Any help would be useful for me. Lokesha

2. Shell Programming and Scripting

Simplify Bash Script Using "sed" Or "awk"

Input file: 2 aux003.net3.com error12 6 awn0117.net1.com error13 84 aux008 error14 29 aux001.ha.ux.isd.com error12 209 aux002.vm.ux.isd.com error34 21 alx0027.vm.net2.com error12 227 dux001.net5.com error123 22 us008.dot.net2.com error121 13 us009.net2.com error129Expected Output: 2...

3. Shell Programming and Scripting

awk command to replace ";" with "|" and ""|" at diferent places in line of file

Hi, I have line in input file as below: 3G_CENTRAL;INDONESIA_(M)_TELKOMSEL;SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL My expected output for line in the file must be : "1-Radon1-cMOC_deg"|"LDIndex"|"3G_CENTRAL|INDONESIA_(M)_TELKOMSEL"|LAST|"SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL" Can someone...

4. Shell Programming and Scripting

how to use "cut" or "awk" or "sed" to remove a string

logs: "/home/abc/public_html/index.php" "/home/abc/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" how to use "cut" or "awk" or "sed" to get the following result: abc abc xyz xyz xyz

5. Solaris

The slices "usr", "opt", "tmp" disappeared!!! Help please.

The system don't boot. on the screen appears following: press enter to maintenance (or type CTRL-D to continue)...I checked with format command. ... the slices "0-root","1-swap","2-backup" exist. ...the slises "3-var","6-usr" -unassigned. :(

6. UNIX for Dummies Questions & Answers

"Help with bash script" - "License Server and Patch Updates"

Hi All, I'm completely new to bash scripting and still learning my way through albeit vey slowly. I need to know where to insert my server names', my ip address numbers through out the script alas to no avail. I'm also searching on how to save .sh (bash shell) script properly....

7. UNIX for Dummies Questions & Answers

Using "mailx" command to read "to" and "cc" email addreses from input file

How to use "mailx" command to do e-mail reading the input file containing email address, where column 1 has name and column 2 containing �To� e-mail address and column 3 contains �cc� e-mail address to include with same email. Sample input file, email.txt Below is an sample code where...

8. Shell Programming and Scripting

Bash script - Print an ascii file using specific font "Latin Modern Mono 12" "regular" "9"

Hello. System : opensuse leap 42.3 I have a bash script that build a text file. I would like the last command doing : print_cmd -o page-left=43 -o page-right=22 -o page-top=28 -o page-bottom=43 -o font=LatinModernMono12:regular:9 some_file.txt where : print_cmd ::= some printing...

9. AIX

Apache 2.4 directory cannot display "Last modified" "Size" "Description"

Hi 2 all, i have had AIX 7.2 :/# /usr/IBMAHS/bin/apachectl -v Server version: Apache/2.4.12 (Unix) Server built: May 25 2015 04:58:27 :/#:/# /usr/IBMAHS/bin/apachectl -M Loaded Modules: core_module (static) so_module (static) http_module (static) mpm_worker_module (static) ...

LEARN ABOUT DEBIAN

puzzle-diff

PUZZLE-DIFF(1)															    PUZZLE-DIFF(1)

NAME

       puzzle-diff - Compare pictures with libpuzzle

SYNOPSIS

       [-b <contrast barrier for cropping>] [-c] [-C <max cropping ratio>] [-e] [-E <similarity threshold>] [-h] [-H <max height>] [-l <lambdas>]
       [-n <noise cutoff>] [-p <p ratio>] [-t] [-W <max width>] <file 1> <file 2>

DESCRIPTION

       puzzle-diff compares two pictures and outputs the normalized distance.

       Try puzzle-diff -h for more info.

EXAMPLES

       Output distance between two images:

	 $ puzzle-diff pic-a-0.jpg pics-a-1.jpg
	 0.102286

       Compare two images, exit with 10 if they look the same, exit with 20 if they don't (may be useful for scripts):

	 $ puzzle-diff -e pic-a-0.jpg pics-a-1.jpg
	 $ echo $?
	 10

       Compute distance, without cropping and with computing the average intensity of the whole blocks:

	 $ puzzle-diff -p 1.0 -c pic-a-0.jpg pic-a-1.jpg
	 0.0523151

AUTHORS

       Frank DENIS libpuzzle at pureftpd dot org

SEE ALSO

       libpuzzle(3), puzzle_set(3)

								    2012-05-09							    PUZZLE-DIFF(1)