Shell Programming and Scripting

I wrote the below script to copy over the files from one directory to other and if the operation is succeeded i want to display but some where i am doing wrong in the second loop. Could you please correct me.


if test -f $uploaddir/GPM_*.csv;then
echo "Master GPM Files Exists"
cp $uploaddir/GPM_*.csv $processdir
echo "Master GPM Files Were Copied To The processdir"
if [ #? -ne 0 ] ; then
echo "Error in Copying The Master GPM Files To The processdir"
else echo "GPM Files Were Copied Successfully"
fi
else echo "Master GPM Files Were n't Copied To The processdir"
fi

Error Message:

/gpm.sh: syntax error at line 20: `else' unexpected

You don't have any loops. An if statement is not a loop; the conditional code is executed once at most.

Please put code inside [code] tags.

If there is nore than one file that matches, you will get a syntax error.

That should be:

Code:

if [ $? -ne 0 ] ; then

Even corrected, that is not what you want.
You are testing the return code of echo, not the return code of cp.

Many Thanks for giving suggestions, was it wrong not to encode the code in quotes. Based on your suggestion i modified the below statement

if test -f $uploaddir/GPM_*.csv;then

as

if [ test -f $uploaddir/GPM_*.csv ];then

i was getting an error as
./gpm.sh:test: unknown operator -f

My idea behind this is to check whether any of the files with the pattern i mentioned exists in the directory or not. If so l was trying to generate a new list file with all those file names matching the file pattern, Could you please shed some light on this.

Thanks & Regards,
Sam.

The [code] tags are for posting code in this forum (as I have added to your post below).

No.

Please reread my previous post.

you are already using if so no need to test.

Code:

if [ -f $uploaddir/GPM_*.csv ];then

Quite the contrary; [ is test.

What the OP is doing is using two tests. He misunderstood what I meant by [code] tags.