Visit Our UNIX and Linux User Community


Can I improve this script ???


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Can I improve this script ???
# 8  
Old 10-22-2002
Thanks Auswipe, will try it tomorrow and I do appreciate the consideration.
However I don't know a scrap of perl and would really like to complete what I started with this script - I hope you understand.

Will more than likely start learning perl & awk after my holidays - say mid December.
# 9  
Old 10-22-2002
I think that your ksh has a bug. This should work:
xspace=${xspace%%\%}
and the above code will continue to work once if your ksh if updated.

And don't set xdfThold to 95%, set it to just 95.

Also make sure that the first line is:
#! /usr/bin/ksh

or whatever the path to your ksh is.
# 10  
Old 10-22-2002
Quote:
Originally posted by Cameron
Thanks Auswipe, will try it tomorrow and I do appreciate the consideration.
However I don't know a scrap of perl and would really like to complete what I started with this script - I hope you understand.
Perfectly understantable.
# 11  
Old 10-22-2002
Cameron, from what I've gathered from other posts, you're using Mandrake Linux, correct?

Most likely what ksh you have installed is not "real" ksh. It's pdksh, which isn't quite as good as David Korn's ksh.

I usually dump that from my systems and install ksh93 instead.
# 12  
Old 10-22-2002
Quote:
Originally posted by LivinFree
Cameron, from what I've gathered from other posts, you're using Mandrake Linux, correct?

Most likely what ksh you have installed is not "real" ksh. It's pdksh, which isn't quite as good as David Korn's ksh.

I usually dump that from my systems and install ksh93 instead.
Thanks LivinFree, I'll keep that in mind. I've not enjoyed Mandrake (at home) for the past three months. Sadly I went through three 10G HD's (dodgy) in the space of four months so I'm without a Linux/Unix system at home. The above posting is work related; on the various SCO 5.0.5 / Irix6.5 / Compaq True-64 / Slackware(*yuck-o*) systems.

The better part of my life suggested that I get some new HD's after we are married (2nd November) - so I'm having to wait. Smilie

Perderabo, thanks for the advice - worked a treat.

Previous Thread | Next Thread
Test Your Knowledge in Computers #887
Difficulty: Easy
sed (stream editor) is a Unix utility that parses and transforms text, using a simple, compact programming language.
True or False?

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Improve script

Gents, Is there the possibility to improve this script to be able to have same output information. I did this script, but I believe there is a very short code to get same output here my script awk -F, '{if($10>0 && $10<=15) print $6}' tmp1 | sort -k1n | awk '{a++} END { for (n in a )... (23 Replies)
Discussion started by: jiam912
23 Replies

2. Shell Programming and Scripting

Improve script and get new output file

Gents, Using the following script, I got the changes as desired in the output file called (spread_2611.x01.new). Complete file as input (spread_2611.x01). Can you please have a look to my script and improve it please. :b: Also I would like to I get a additional selecting only the records... (21 Replies)
Discussion started by: jiam912
21 Replies

3. Shell Programming and Scripting

How to improve an script?

Gents. I have 2 different scripts for the same purpose: raw2csv_1 Script raw2csv_1 finish the process in less that 1 minute raw2csv_2 Script raw2csv_2 finish the process in more that 6 minutes. Can you please check if there is any option to improve the raw2csv_2. To finish the job... (4 Replies)
Discussion started by: jiam912
4 Replies

4. Shell Programming and Scripting

Improve sftp script

Dear all, I have written two scripts to transfer files to another server outside the company. One is a batch script , and the other script calls the batch script, send the files and archive the file sent. The problem is, that I want to get the list of files which have been uploaded the the... (10 Replies)
Discussion started by: arrals_vl
10 Replies

5. UNIX for Dummies Questions & Answers

How to improve the performance of this script?

Hi , i wrote a script to convert dates to the formate i want .it works fine but the conversion is tkaing lot of time . Can some one help me tweek this script #!/bin/bash file=$1 ofile=$2 cp $file $ofile mydates=$(grep -Po '+/+/+' $ofile) # gets 8/1/13 mydates=$(echo "$mydates" | sort |... (5 Replies)
Discussion started by: vikatakavi
5 Replies

6. Shell Programming and Scripting

Var Check Script (Help improve if possible)

I am working on a script to check the var on all of my systems. Can someone help me fix it to work better or give me suggestions. #!/bin/ksh IN=/path/to/list_of_workstations.txt while read hostnames do if ping $hostnames 1 | grep alive > /dev/null then percent=`ssh -q... (3 Replies)
Discussion started by: whotippedmycow
3 Replies

7. UNIX for Dummies Questions & Answers

[please] improve my shell/SQL*Plus script

Hi We generate with PL/SQL *.csv files, archive them and mail to the customer. Here is my script (Solaris 10, ksh): #!/bin/ksh # Unix Shell Script Structure for PL/SQL queries with SQL*Plus . ~/.profile scriptdir=/opt/ora/scripts queryname1=example... (1 Reply)
Discussion started by: slashdotweenie
1 Replies

8. Shell Programming and Scripting

Want to improve the performance of script

Hi All, I have written a script as follows which is taking lot of time in executing/searching only 3500 records taken as input from one file in log file of 12 GB Approximately. Working of script is read the csv file as an input having 2 arguments which are transaction_id,mobile_number and search... (6 Replies)
Discussion started by: poweroflinux
6 Replies

9. Shell Programming and Scripting

Improve the performance of a shell script

Hi Friends, I wrote the below shell script to generate a report on alert messages recieved on a day. But i for processing around 4500 lines (alerts) the script is taking aorund 30 minutes to process. Please help me to make it faster and improve the performace of the script. i would be very... (10 Replies)
Discussion started by: apsprabhu
10 Replies

10. Shell Programming and Scripting

Any way to improve performance of this script

I have a data file of 2 gig I need to do all these, but its taking hours, any where i can improve performance, thanks a lot #!/usr/bin/ksh echo TIMESTAMP="$(date +'_%y-%m-%d.%H-%M-%S')" function showHelp { cat << EOF >&2 syntax extreme.sh FILENAME Specify filename to parse EOF... (3 Replies)
Discussion started by: sirababu
3 Replies

Featured Tech Videos