Syntax error: Bad for loop variable


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Syntax error: Bad for loop variable
# 8  
Old 12-19-2011
It looks like you messed up a [ ] type of comparison statement, but there's nothing like that in the ftp script you posted, could you post it in complete?
# 9  
Old 12-19-2011
Most of the recent error messages come from this line:
Quote:
while [$x -lt $WAIT_TIME];
There must be a space character after a [ and before a ]. The semicolon at the end of the line is not required at all.
Code:
	while [ $x -lt $WAIT_TIME ]


The FTP script has some issues: The << "Start of Here Document" is misplaced. Also why "mput" when the calling script logic is for one file? We need to use "lcd" to change local directory. Don't indent "Here Documents" - it will bite you in the hand.

Code:
#!/bin/sh

set -x verbose #echo on

#CURRENT PROCESSING FILE: 1
#USERNAME: 2
#PASSWORD: 3
#SERVER: 4
#FILE_PATH: 5
#REMOTE_PATH: 6

#login to remote server
ftp -n -i $4 <<END_INPUT
user $2 $3
cd $6
lcd $5
put $1
quit
END_INPUT


In post #4 you were asked what is your shell and what is your system. Please post (blotting anything confidential with X's):
Code:
uname -a
echo ${SHELL}


Last edited by methyl; 12-19-2011 at 08:34 PM..
This User Gave Thanks to methyl For This Post:
# 10  
Old 12-20-2011
Linux lubuntu 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:34:47 UTC 2011 i686 i686 i386 GNU/Linux

/bin/bash
# 11  
Old 12-20-2011
If the pair of scripts are still giving trouble, please post the current version of both scripts and any error execution messages.

Quote:
#!/bin/sh

But normal Shell is /bin/bash ?
# 12  
Old 12-21-2011
Current Code

-----FirstFile-----

Code:
#!/bin/bash

set -x verbose #echo on
clear #clear the screen

USERNAME="xxxx"
PASSWORD="xxxx"
SERVER="192.168.225.1"
WAIT_TIME=300
FILE_PATH="/home/user/Desktop/XXX" # local directory to pickup *.dat file
REMOTE_PATH="/Drop_off/Region_3_prod/XXX" # remote server directory to upload backup

#Process files
for file in $FILE_PATH/*.dat
do
	# take action on each file. [file] store current file name
	./UFTFTP_SecondScript $file $USERNAME $PASSWORD $SERVER $REMOTE_PATH
	echo "Seconds until next upload: $WAIT_TIME"
	x=0
	while [ $x -lt $WAIT_TIME ]
	do
		echo "Sleeping for $x..."
		sleep 1
		x='expr $x + 1'
	done
done

-----SecondFile-----

Code:
#!/bin/bash

set -x verbose #echo on

#file: 1
#USERNAME: 2
#PASSWORD: 3
#SERVER: 4
#REMOTE_PATH: 5

#login to remote server
echo "Processing file $1..."
ftp -n -i $4 <<END_INPUT
user $2 $3
cd $5
put $1 
quit
END_INPUT

---------- Post updated at 10:13 AM ---------- Previous update was at 10:10 AM ----------

+ clear

+ USERNAME=XXX
+ PASSWORD=XXX
+ SERVER=192.168.225.1
+ WAIT_TIME=300
+ FILE_PATH=/home/user/Desktop/XXX
+ REMOTE_PATH=/Drop_off/Region_3_prod/XXX
+ for file in '$FILE_PATH/*.dat'
+ ./UFTFTP_SecondScript '/home/user/Desktop/XXX/*.dat' XXX XXX 192.168.225.1 /Drop_off/Region_3_prod/XXX
./UploadFileToFtp.sh: line 25: ./UFTFTP_SecondScript: No such file or directory
+ echo 'Seconds until next upload: 300'
Seconds until next upload: 300
+ x=0
+ '[' 0 -lt 300 ']'
+ echo 'Sleeping for 0...'
Sleeping for 0...
+ sleep 1
+ x='expr $x + 1'
+ '[' expr '$x' + 1 -lt 300 ']'
./UploadFileToFtp.sh: line 28: [: too many arguments
# 13  
Old 12-21-2011
Code:
x='expr $x + 1'

This sets x to the literal string 'expr $x + 1' which naturally doesn't work when you compare it to an integer.

I think you meant to use backticks.
This User Gave Thanks to Corona688 For This Post:
# 14  
Old 12-21-2011
Thanks,

Code:
while [ $x -lt $WAIT_TIME ]
	do
		echo "Sleeping for $x..."
		sleep 1
		x=`expr $x + 1` # " ` " use backticks not " ' " apostrophe
	done


Quote:
Originally Posted by Corona688
Code:
x='expr $x + 1'

This sets x to the literal string 'expr $x + 1' which naturally doesn't work when you compare it to an integer.

I think you meant to use backticks.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Bash function using variable in it syntax error

The below bash function uses multiple variables CODING, SAMPLE, SURVEY, andvariant in it. The user selects the cap function and details are displayed on the screen using the $SURVEY variable, the directory is changed to $SAMPLE and the samples.txt is opened so the user can select the sample to... (6 Replies)
Discussion started by: cmccabe
6 Replies

2. UNIX for Dummies Questions & Answers

Syntax error in for loop

I am using simple for loop, but getting syntax error when I run the code code #!/bin/ksh pls enter number read n for(i=1; i<=n; i++) do echo $i done syntax error + pls enter number + read n (5 Replies)
Discussion started by: stew
5 Replies

3. Shell Programming and Scripting

Variable syntax error in $?

hi all , i just tried to take the status of previous command inside the script using echo $?. It throws me a variable syntax error , but when i use echo $? as an individual command it works perfectly . can anyone Please tell me why am getting a variable syntax error when i use echo $?... (7 Replies)
Discussion started by: Rahul619
7 Replies

4. UNIX for Dummies Questions & Answers

[Solved] Syntax error for awk in a loop

can some one please tell me what is the problem with my syntax:confused: I have 100 files in one folder 1. want to read each of the line by line 2. calculate their number of the words between the first word and the last word of each line 3. create file for each file with number of words... (8 Replies)
Discussion started by: A-V
8 Replies

5. Shell Programming and Scripting

IF loop syntax error

I am trying to run a menu option though IF loops. I keep getting errors not allowed the menu to be processed correctly. Currently it will accept the first 2 statements but then crash on the 3rd. The 2nd and 3rd have the same syntax, so I do not understand why it breaks. #!/bin/bash while... (4 Replies)
Discussion started by: Ironguru
4 Replies

6. Shell Programming and Scripting

Bash (Ubuntu server): Syntax error: "|" unexpected in While-loop

Hello forum, I hope my problem is easy to solve for someone in here! My main task is to copy a large amount of imap-accounts from one server to another. There is a tool (Perl) called imapsync which does the job exellent. Unfortunately I'm only able to run it on one account at a time. After... (3 Replies)
Discussion started by: primaxx
3 Replies

7. Shell Programming and Scripting

Syntax error: Bad for loop variable

Hi Can any one help, I'm trying to run a script that beeps out the ip address from the PC internal speaker with the following script. It keeps throwing the error "Syntax error: Bad for loop variable" on line 16. I know its picking up the IP ADDRESS correctly. Any ideas on whats wrong. I'm... (3 Replies)
Discussion started by: dman
3 Replies

8. Shell Programming and Scripting

for loop not working - syntax error at line 6: `end of file' unexpected

I have a file called test.dat which contains a b I have written a shell script called test.sh for i in `cat test.dat` do echo $i done When i run this script using sh test.sh I get this message - test.sh: syntax error at line 6: `end of file' unexpected What is the... (3 Replies)
Discussion started by: debojyoty
3 Replies

9. Shell Programming and Scripting

Syntax error on variable assignment

Hello all, I have "inherited" a Korn shell script I'm supposed to maintain, and running a "sh -n" on it, I got this syntax error: script.sh: syntax error at line 63: `OB_DEVICE=$' unexpected The line in cause is the first occurence of the usage of perl one-liners. The whole line: ... (2 Replies)
Discussion started by: AdrianM
2 Replies

10. Shell Programming and Scripting

syntax error in while loop

Hi, I have the following script (compile_mercury) and I get this error: I have no idea why...and I have written this script completely in linux (bash) and not in windows. **************** ./compile_mercury: line 136: syntax error near unexpected token `done' ./compile_mercury: line 136:... (1 Reply)
Discussion started by: habzone2007
1 Replies
Login or Register to Ask a Question