Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

: [: too many arguments in for -f in if

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting : [: too many arguments in for -f in if
# 8  
Old 07-12-2011
Quote:
Originally Posted by ajaypatil_am
but when file does not exist it is giving "mv: cannot access .......pathname"
what is mean by file does not exist ?

Is your file name has multiple words ?

eg: filename : abcd efgh.s ( there is space b/w d and e )
# 9  
Old 07-12-2011
file does not exis = when there are no files at the given path
this scenario i just want "File Move -Fail" but currently along with "File Move -Fail" "mv: cannot access" is also getting displayed which I do not want ....
No file names do not have 'space' character ...it has '-' though ...
e.g filenames ...
Kay-Kaay-20110709060648-E-A.D.g.s



Quote:
Originally Posted by itkamaraj
what is mean by file does not exist ?

Is your file name has multiple words ?

eg: filename : abcd efgh.s ( there is space b/w d and e )
# 10  
Old 07-12-2011
ok, try this..

$? is a special variable which tells, the previous command is success or not.

if it holds 0, then it success.

Code:
 
ls -l /a/b/c/d/e/K*-*-*-*.s > /dev/null
if [ "$?" -eq "0" ]
then
 for i in /a/b/c/d/e/K*-*-*-*.s; 
 do 
       #Here you can get the files one by one using $i
       mv $i newPath
       [ "$?" -eq "0" ] && echo "$i : File Move -Successful" || echo "$i : File Move -Failed"
 done
else
 echo "File does not exits"
fi

This User Gave Thanks to itkamaraj For This Post:
ajaypatil_am
# 11  
Old 07-12-2011
itkamaraj Thank you for your help ...the final working code for me for the benefit of other users / readers .......
Code:
#!/bin/bash
ls -l path/name/K-*.s > /dev/null 2>&1
if [ "$?" -eq "0" ]; then
for i in path/name/K-*.s ;
do
mv -f $i new/path/name
[ "$?" -eq "0" ] && echo "$i : File Move -Successful" || echo "$i : File Move -Failed"
done
else
 echo "Files does not exits"
fi

My real question here is like "K-*.s" I have 6 more patterns e.g K-*.gz , K-*.ff and so on at ....at path/name and ajay/x/y/z path .......one way is i can repeat the same above code 6 times to achieve this ....is there any other way which will do this in one shot so that i do not end repeating same code 6 times ......?

Quote:
Originally Posted by itkamaraj
ok, try this..

$? is a special variable which tells, the previous command is success or not.

if it holds 0, then it success.

Code:
 
ls -l /a/b/c/d/e/K*-*-*-*.s > /dev/null
if [ "$?" -eq "0" ]
then
 for i in /a/b/c/d/e/K*-*-*-*.s; 
 do 
       #Here you can get the files one by one using $i
       mv $i newPath
       [ "$?" -eq "0" ] && echo "$i : File Move -Successful" || echo "$i : File Move -Failed"
 done
else
 echo "File does not exits"
fi

Last edited by Franklin52; 07-12-2011 at 04:51 AM.. Reason: Please use code tags for code and data samples, thank you
# 12  
Old 07-12-2011
use function

unix books : https://www.unix.com/im-new-unix-book...nix-books.html

sample function :

https://www.unix.com/shell-programmin...ll-script.html

https://www.unix.com/shell-programmin...ll-script.html


implement your code and let us know, if u have any issue
# 13  
Old 07-18-2011
well ...back to the original topic of getting "too many arguments" error
....it was not because of " -f "

The problem was when i was running the script like "sh scriptname" it was running fine but for just "scriptname" it was giving above error.....

well , it was related with the default shell. I had set it as “#!/bin/bash” now I have changed it to “#!/bin/sh” and script is working fine ....

Thanks,
Ajay




---------- Post updated at 06:05 AM ---------- Previous update was at 06:03 AM ----------

itkamaraj ,
we CAN use -f, if we want to use the * in our pattern (at least this is working fine in sh shell...not sure about other shells ).Experts please comment ....
the problem was related to the default shell...

Thanks,
Ajay

Quote:
Originally Posted by itkamaraj
you cannot use -f, if you want to use the * in your pattern.

Code:
 
for i in /a/b/c/d/e/K*-*-*-*.s; 
do 
       #Here you can get the files one by one using $i
       mv $i newPath
       [ "$?" -eq "0" ] && echo "$i : File Move -Successful" || echo "$i : File Move -Failed"
done

# 14  
Old 07-18-2011
The problem was too many arguments, just like it said.
Your wildcard pattern K*-*-*-*.s matched more than one file, or there was a space in the filename. However, the [ -f file ] test expects exactly one file.
To test for existence of multiple files, the most common way is to make a loop:
Code:
for i in /path/name/K-*.s ; do
  if [ -f "$i" ] ; then
    echo "file $i exists"
  else
    echo "$i does not exist, or is not a regular file"
  fi
done

Please not the quotes in the test, "$i", which will make it only one argument even for filenames with spaces.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Ubuntu

[: too many arguments

line 5: #!/bin/bash old=$(du -sh /home/andy/Downloads/myfile.iso) while true; do new=$(du -sh /home/andy/Downloads/myfile.iso) if ; then break fi old=$new xdotool getactivewindow key Ctrl sleep 5 done line 5: bash - Meaning of " (square brackets)... (9 Replies)
Discussion started by: drew77
9 Replies

2. Shell Programming and Scripting

Too many arguments

hi I have this code a="a b c" set -- $a if ; then echo empty fi why is it line 3 reports "test: [: too many arguments"? :wall: Thanks! (4 Replies)
Discussion started by: h0ujun
4 Replies

3. Shell Programming and Scripting

Using arguments

I have a SNMP agent that sends three arguments to the script to get a value at the end. The first is the LeafNumber, second is the request type (SET, GET, GETNEXT), and the last is a string that represents some value to be set(used only for set requests). The agent string looks like this: ... (3 Replies)
Discussion started by: jsoper1
3 Replies

4. Shell Programming and Scripting

grep with two arguments to arguments to surch for

Hello, is it possible to give grep two documents to surche for? like grep "test" /home/one.txt AND /home/two.txt ? thanks (1 Reply)
Discussion started by: Cybertron
1 Replies

5. Shell Programming and Scripting

Too many arguments

echo "the number from 1 to 10:" i=1 while do echo $i i=`expr $i+1' done above is the program i written in Linux O.S using vi editor but i am getting the error that while: line 3: i am not understanding that why i am getting this error. can any body please help me regarding this... (3 Replies)
Discussion started by: bsatishbabu
3 Replies

6. Shell Programming and Scripting

[: too many arguments

hi I am getting too many arguments error for the below line if ; then Thx in advance (1 Reply)
Discussion started by: vls1210
1 Replies

7. Shell Programming and Scripting

too many arguments?

i don't know what's wrong with the code, says too many arguments in the first two if statements. how to change it? thx. the file is like in this format: ;dfs;dfdsf;fsd ff dsf;dfdffdfd; -f2 should be only one word with no space, but could be like this 'n/a', '**ABC' while read line; do ... (1 Reply)
Discussion started by: dtdt
1 Replies

8. Shell Programming and Scripting

Too many arguments?

I can't find anything wrong with this line of code, it works when there is one file in the directory but more than one i get a "too many arguements2 error if ; then am i missing something? (3 Replies)
Discussion started by: Alendrin
3 Replies

9. Shell Programming and Scripting

[: too many arguments

Hi Guys I have this small Bash script - but it fails when I'm trying to run it. ./test.sh: && ; then # date >> /writable/sys/shutdown.log shutdown -h "now" exit fi done (4 Replies)
Discussion started by: tainted2real
4 Replies

10. UNIX for Dummies Questions & Answers

Arguments

Ok so i had to create a file and put some random text into it which i did. THen u make a script which takes 2 arguments. The first being a line of text, the second being your newly created file. The script should take the first argument and insert it into the very top (the first line) of... (1 Reply)
Discussion started by: iago
1 Replies
Login or Register to Ask a Question