Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Looping through for user input

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Looping through for user input
# 1  
Old 06-24-2011
Looping through for user input
Legends,

I want to remain in the script until user passes the correct name.
I had tried the below code; but it didn't work out.
Please help

Code:
echo "\nPlease enter the source system: \c"
while read SYSTEM_NAME
do
if [[ $SYSTEM_NAME == "L1" || $SYSTEM_NAME == "L2" || $SYSTEM_NAME == "P1" || $SYSTEM_NAME == "P2 ]];
then
echo "\nMaking $SYSTEM_NAME as source system for particular script"
else
echo "\nPlease enter the source system as L1 L2 P1 P2"
echo "\nPlease enter the product name FUNDDB/SMF: \c"
fi
done

But, this is not working.
# 2  
Old 06-24-2011
Please let us know the expected output and the error which u got??
# 3  
Old 06-24-2011
In your code, you'd have to break out of the loop when the test passes. Or, do the test directly in while, then read at the end of loop:

Code:
#!/bin/bash

echo "Please enter the source system: "
read SYSTEM_NAME

while ! [[ $SYSTEM_NAME == "L1" || $SYSTEM_NAME == "L2" || $SYSTEM_NAME == "P1" || $SYSTEM_NAME == "P2" ]] ; do
      echo "\nPlease enter the source system as L1 L2 P1 P2"
      read SYSTEM_NAME
done

echo "Making $SYSTEM_NAME as source system for particular script"

#continue with  $SYSTEM_NAME

# 4  
Old 06-24-2011
When you are coming out of loop? seems , it's in infite. exit from while once you get the usernames you wanted.

Regards
Ravi
# 5  
Old 06-24-2011
Easier to read with a case statement. Note the use of "break" to get out of "while read". Not sure where the "Please enter product" line should go.


Code:
echo "\nPlease enter the source system: \c"
while read SYSTEM_NAME
do
   case "${SYSTEM_NAME}" in
      "L1"|"L2"|"P1"|"P2")
         echo "\nMaking $SYSTEM_NAME as source system for particular script"
        break
        ;;
   esac
   echo "\nPlease enter the source system as L1 L2 P1 P2"
done

echo "\nPlease enter the product name FUNDDB/SMF: \c"

This User Gave Thanks to methyl For This Post:
sdosanjh
# 6  
Old 06-24-2011
Quote:
Originally Posted by mirni
In your code, you'd have to break out of the loop when the test passes. Or, do the test directly in while, then read at the end of loop:

Code:
#!/bin/bash

echo "Please enter the source system: "
read SYSTEM_NAME

while ! [[ $SYSTEM_NAME == "L1" || $SYSTEM_NAME == "L2" || $SYSTEM_NAME == "P1" || $SYSTEM_NAME == "P2" ]] ; do
      echo "\nPlease enter the source system as L1 L2 P1 P2"
      read SYSTEM_NAME
done

echo "Making $SYSTEM_NAME as source system for particular script"

#continue with  $SYSTEM_NAME

Mirni.
the code is on the lines 30-35 ,and while running it throws error on different piece of code.

./switch_dist.sh: syntax error at line 41: `(' unexpected

And, at 41st line, i have following statement in place. Looks like while is not working with parenthesis.

41 echo "\nDo you wish to continue...(y/n): \c"

---------- Post updated at 05:04 AM ---------- Previous update was at 04:56 AM ----------

Quote:
Originally Posted by methyl
Easier to read with a case statement. Note the use of "break" to get out of "while read". Not sure where the "Please enter product" line should go.


Code:
echo "\nPlease enter the source system: \c"
while read SYSTEM_NAME
do
   case "${SYSTEM_NAME}" in
      "L1"|"L2"|"P1"|"P2")
         echo "\nMaking $SYSTEM_NAME as source system for particular script"
        break
        ;;
   esac
   echo "\nPlease enter the source system as L1 L2 P1 P2"
done

echo "\nPlease enter the product name FUNDDB/SMF: \c"


Thanks methyl, case statement worked Smilie
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Looping through input/output

Hi, I've got a directory of about 6000 txt files that look like this: a b c d e f g h k l m n I need to execute a command on them to combine them and, in the end, have one big file with all the needed columns taken form all the 6000 files. I've got the "combining" program, but my problem... (26 Replies)
Discussion started by: zajtat
26 Replies

2. Shell Programming and Scripting

User input and run awk using the input

I am trying to allow a user to enter in text and then store that text in a variable $gene to run in an awk command in which those values are used to run some calculations. I am getting syntax errors however, when I try. Thank you :). The awk runs great if it is a pre-defined file that is used,... (7 Replies)
Discussion started by: cmccabe
7 Replies

3. Shell Programming and Scripting

How to validate user's input..?

$Input_filename=$ARGV; if (!-d $Input_filename && ! -e $Input_filename) { print "USAGE: Please enter '$ABCD/def/dsed.txt' as an arguement \n"; exit; } 1. Input Is suppose to be something like "$ABCD/def/dsed.txt". if the input is wrong the script should throw an ERROR message.... (2 Replies)
Discussion started by: Rashid Khan
2 Replies

4. Shell Programming and Scripting

How-To Trim user input

Hi, The user inputs either "/tmp/bea" or "/tmp/bea/". Regardless my script should extract and store in a variable the last directory in the user input path. Desired output: "bea" Please help. (6 Replies)
Discussion started by: mohtashims
6 Replies

5. Shell Programming and Scripting

Script interacts with user , based on user input it operates

i have a script which takes input from user, if user gives either Y/y then it should continue, else it should quit by displaying user cancelled. #!/bin/sh echo " Enter your choice to continue y/Y OR n/N to quit " read A if then echo " user requested to continue " ##some commands... (7 Replies)
Discussion started by: only4satish
7 Replies

6. Shell Programming and Scripting

How to get the user input recursively until the user provides valid input

Hi, echo "Enter file name of input file list along with absolute path : " read inputFileList if then for string in `cat inputFileList` do echo $string done else echo " file does not exist" fi From the above code, if the user enters a invalid file... (1 Reply)
Discussion started by: i.srini89
1 Replies

7. Shell Programming and Scripting

Bash user input

Hi all, I currently have a script which uses read -p for user interaction. e.g. read -p "New user? " user Is it possible to have it so if the user enters nothing and just presses return it can resort to a specified value instead? Thanks! :) (5 Replies)
Discussion started by: JayC89
5 Replies

8. Shell Programming and Scripting

Get Hidden Input from User.

HI All, I want to take input from user on linux console...but i dont wnt it to be visible.. just like we type password for ssh or scp Right now I am using "read" to take input from user but it also makes it visible when user type it. read -ep "Dear User Please enter password : " pass... (8 Replies)
Discussion started by: mkashif
8 Replies

9. UNIX for Dummies Questions & Answers

crontab or looping script to Kill process from user

I am looking for a way to kill 2 processes from a user through some kind of script. Using an oracle script, I get two process ids that need to be killed. SQL> select ssn.process as client_process_id, pcs.spid as oracle_process_id, ssn.sid, ssn.serial# 2 from v$session ssn inner join... (5 Replies)
Discussion started by: Meert
5 Replies

10. Shell Programming and Scripting

Getting user input

I am trying to create a shell (ksh) which has two "read" commands, one which reads a line from a file and another which is inside a loop that reads user input from a keyboard. However, the "read" command inside the loop uses the input from the file and it does not get the user input from keyboard.... (3 Replies)
Discussion started by: stevefox
3 Replies
Login or Register to Ask a Question