Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Whats wrong in the Function ?

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Whats wrong in the Function ?
# 8  
Old 10-04-2010
can you please provide me the link of previous thread, so that i could able to correct the script. But one thing is mesmerising me that, previuosly i had the same structured script, which works well, but this has become ache . Smilie
# 9  
Old 10-04-2010
I did, in my previous post.

Don't check for arguments in the function, just print the usage in the function. Check the arguments outside the function where $1 and $# do what you think they do.
# 10  
Old 10-04-2010
Quote:
I seem to recall a thread about this before. Are you two posters?
The development of this script by this board has gone on for some time without clear specification of the requirement.


Quote:
can you please provide me the link of previous thread, so that i could able to correct the script. But one thing is mesmerising me that, previuosly i had the same structured script, which works well, but this has become ache .
If the current poster cannot remember previous handles, then this thread is dead.
# 11  
Old 10-05-2010
Yes Corona, Now the function has only echoing USAGE statement and checking for argument is outside the Function Call. But still the result is the same NO change in it.

Here it is:

Code:
function usage (){
        echo
        echo "*******************************************"
        echo "       !!! USAGE PARAMETERS !!!            "
        echo "*******************************************"
        echo
        echo
        echo    "USAGE:"
        echo "  " `basename $0`" <OPTION> <SERVICE_NAME>  "
        echo
        echo "  <SERVICE_NAME>   = Enter the vaild SERVICE_NAME that exists in 76S DIR.
    <-L | -l>      = Searching from the LIVE LOGS.
    <-A | -a>      = Searching from the ARCHIVE LOGS."
        echo
        echo "  Please check for correct Parameter from the Usage "
        echo
}
usage
exit


#Check Input parameters are valid

        if [ $1 != 0 ] || [ $2 != 0 ]; then
        usage
        fi

I tried even $# but its the same result.

Result is here.

Code:
$ ./testxmlsearch.sh -a dp_3yl_to_choicepoint

*******************************************
       !!! USAGE PARAMETERS !!!
*******************************************


USAGE:
   testxmlsearch.sh <OPTION> <SERVICE_NAME>

  <SERVICE_NAME>   = Enter the vaild SERVICE_NAME that exists in 76S DIR.
    <-L | -l>      = Searching from the LIVE LOGS.
    <-A | -a>      = Searching from the ARCHIVE LOGS.

  Please check for correct Parameter from the Usage

# 12  
Old 10-05-2010
your calling usage before doing the test here is what you need:

Code:
function usage (){
        echo
        echo "*******************************************"
        echo "       !!! USAGE PARAMETERS !!!            "
        echo "*******************************************"
        echo
        echo
        echo    "USAGE:"
        echo "  " `basename $0`" <OPTION> <SERVICE_NAME>  "
        echo
        echo "  <SERVICE_NAME>   = Enter the vaild SERVICE_NAME that exists in 76S DIR.
    <-L | -l>      = Searching from the LIVE LOGS.
    <-A | -a>      = Searching from the ARCHIVE LOGS."
        echo
        echo "  Please check for correct Parameter from the Usage "
        echo
        exit
}


#Check Input parameters are valid
if [ $# != 2 ]; then
        usage
fi

# 13  
Old 10-05-2010
In my previous trial, i tested the usage there after. But even that time i had same issue.
Can you rewrite the the same ??
# 14  
Old 10-05-2010
Yes I already have look at the code in post #12
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Python - Function print vs return - whats wrong

All, I have a basic buzz program written in python with return function. If i change return with print,it works fine but i want to know whats wrong with return statement.Can anyone help me whats wrong with this #!/usr/bin/python def div4and6(s,e): for i in range(s,e+1): if... (5 Replies)
Discussion started by: oky
5 Replies

2. UNIX for Dummies Questions & Answers

Whats wrong with this if-else

hi whats wrong in below?? CHECK=M10; if ; then echo "hello hi"; else echo "how are u hello hi"; fi I am getting error as ./test.sh: line 2: ' ./test.sh: line 2: M10: command not found ./test.sh: line 2: M10: command not found ./test.sh: line 2: M10: command not found (8 Replies)
Discussion started by: skyineyes
8 Replies

3. Programming

Whats wrong with my my Makefile

its right only missed \ (0 Replies)
Discussion started by: dragonpoint
0 Replies

4. Homework & Coursework Questions

Whats wrong with the following

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted! 1. The problem statement, all variables and given/known data: ls -ld htdocs drwxr-x--- 3 root root 8192 2006-11-19 10:41 htdocs How would a host administrator... (1 Reply)
Discussion started by: Larry_1
1 Replies

5. UNIX for Dummies Questions & Answers

whats wrong with this?

can anyone tell me why this code doesn't work how its supposed to, its the hangman game but it doesn't play how its supposed to #!/bin/bash NoAttempts="0" livesgiven="5" LivesRemain=$livesgiven LettersAttempted="" wordfile=words numwords=0 function menu() { clear cat << menu... (1 Reply)
Discussion started by: ferrycorsten73
1 Replies

6. UNIX for Dummies Questions & Answers

Whats wrong in the script?

if then if then echo "fst argument is $1 " else if then "fst argument is $1" fi fi fi Can anyone tell me. My requirement is tht pass a string .. Check whether it contains "-". If yes then check if it... (1 Reply)
Discussion started by: nehagupta2008
1 Replies

7. Shell Programming and Scripting

tell me whats wrong with this

#! /bin/bash USAGE=" | ] if then echo "$USAGE" exit 1 fi while getopts lb: OPTION do case $(OPTION)in a) echo Hi there! exit 2;; b) echo hello o) OARG=$OPTARG;; \?)echo "$USAGE" ;; exit 2;; esac done shift `expr... (1 Reply)
Discussion started by: nadman123
1 Replies

8. Shell Programming and Scripting

tell me whats wrong in this?

#! /bin/bash head -5 $1 echo "remove $1 ?" read answer if then echo invalid answer elif rm $1 echo "$1 is deleted" elif then echo file is not deleted else echo "invalid answer" fi What i really want this to do is to ask to delete the file or not..it says something wrong... (1 Reply)
Discussion started by: nadman123
1 Replies

9. UNIX for Advanced & Expert Users

Whats wrong in this Script ???

PATH="/clocal/mqbrkrs/user/mqsiadm/sanjay" MAIL_RECIPIENTS="xyz@abc.com" Subject="File accessed in last minutes:" find $PATH -type f -amin -1 > temp.txt.$$ cat temp.txt.$$ | \ while read line do fuser -uV $line >> tempmail.txt done cat "$tempmail.txt" | mailx -s "$Subject"... (4 Replies)
Discussion started by: varungupta
4 Replies

10. Shell Programming and Scripting

Whats wrong with my function?? <newbie>

First of all im using Bash, on a Debian-based machine. I tried to write a function that if the ls program found listed more than 25 lines I would automaticly use "ls | less". Its on another computer but if I recall it looked something like this... Note: some code may look strange because im on... (4 Replies)
Discussion started by: riwa
4 Replies
Login or Register to Ask a Question