Shell Programming and Scripting

#! /bin/bash

infoUsers=$(cat /etc/passwd | cut -d':' -f1,3,6) 
for infoUser in $infoUsers
do 
	userName=$(echo $infoUser | cut -d':' -f1)
	uid=$(echo $infoUser | cut -d':' -f2)
	uDir=$(echo $infoUser | cut -d':' -f3)
	idGroup=$(cat /etc/passwd | cut -d':' -f4)
	if [ '"$uid"  -ge "500" && ! $uDir -eq "/dev/null"' ];
	then
		if [ ! -d $uDir ]
		then
			$(mkdir $uDir)
		fi
		$(chown $userName $uDir)
		groupName=$(cat /etc/group | grep $idGroup | cut -d':' -f1)
		$(chgrp $groupName $uDir)
		$(chmod o-rwx $uDir)
		if [ ! -f "$uDir/www/index.html" ]
		then
			$(echo "Welcome!" > "$uDir""/www/index.html")
			$(chmod o-w+rx "$uDir""/www/index.html")
		fi
	fi
done

for file in /root/logins/login*
do
	echo "$file" >> "/root/logins/check.log"
	cat "$file" >> "/root/logins/check.log"
done

#! /bin/bash

infoUsers=$(cat /etc/passwd | cut -d':' -f1,3,6)
# If you want the group, too, then you'll have to get it here, not inside the loop
infoUsers=$(cat /etc/passwd | cut -d':' -f1,3,6,4)

for infoUser in $infoUsers
do 
	userName=$(echo $infoUser | cut -d':' -f1)
	uid=$(echo $infoUser | cut -d':' -f2)
	uDir=$(echo $infoUser | cut -d':' -f3)

	idGroup=$(cat /etc/passwd | cut -d':' -f4)
# See above comment. Better to get the group outside the loop, not inside
	idGroup=$(echo $infoUser | cut -d':' -f4)

	if [ '"$uid"  -ge "500" && ! $uDir -eq "/dev/null"' ];
# As soon as you surround a variable or constant with quotes it becomes a
string, which isn't suitable for testing with -gt/-lt
# Also, you don't have to quote the whole test expression
	if [ $uid -ge 500 && ! "$uDir" -eq "/dev/null" ];

	then
		if [ ! -d $uDir ]
		then

			$(mkdir $uDir)
# No need to capture the output of mkdir here using $()
			mkdir $uDir

		fi

		$(chown $userName $uDir)
#Again, no need to capture
		chown $userName $uDir

# This is optional. You can change the ownerships by ID just as well
		groupName=$(cat /etc/group | grep $idGroup | cut -d':' -f1)

		$(chgrp $groupName $uDir)
		$(chmod o-rwx $uDir)
#Again, no need to capture
		chgrp $groupName $uDir
		chmod o-rwx $uDir

		if [ ! -f "$uDir/www/index.html" ]
		then
			$(echo "Welcome!" > "$uDir""/www/index.html")
			$(chmod o-w+rx "$uDir""/www/index.html")
		fi
	fi
done

for file in /root/logins/login*
do
	echo "$file" >> "/root/logins/check.log"
	cat "$file" >> "/root/logins/check.log"
done