Problen in a bash script


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Problen in a bash script
# 1  
Old 03-05-2009
Problen in a bash script

Hi

New post, and new member

I have a problem with a bash script
And I probably look't at for so long that I DON'T
See a obvious syntax error

The reason for the script is to selectively change permission, UID, GID within
A selected /dir
Anny help or insight would be appreciated
Dan

So the offending part of the script is

# main execution
for i in "${DIR}"; do

if [ -f "$i" = ${DIR} ]; then
echo "${DIR}":" skipping modifing ${DIR} no sutch dir exist" && continue
else
[ -f "${DIR}" ] && { chown "${USR}":"${GID}" ; }{ chmod "${MOD}"; ] && echo ls -als ${DIR};
fi

done

The output I get
+ DIR=
+ MOD=
+ USR=
+ GID=
+ NAM=
+ PA=
+ getopts vhlp:d:u:g: options
+ case "$options" in
+ DIR=/home/user
+ getopts vhlp:d:u:g: options
+ case "$options" in
+ MOD=755
+ getopts vhlp:d:u:g: options
+ case "$options" in
+ USR=user-name
+ getopts vhlp:d:u:g: options
+ case "$options" in
+ GID=staff
+ getopts vhlp:d:u:g: options
+ [[ -n /home/user ]]
./chgfile.sh: line 62: syntax error near unexpected token `fi'
./chgfile.sh: line 62: ` fi'
# 2  
Old 03-05-2009
Quote:
Originally Posted by Ex-Capsa
Hi

New post, and new member

I have a problem with a bash script
And I probably look't at for so long that I DON'T
See a obvious syntax error

The reason for the script is to selectively change permission, UID, GID within
A selected /dir
Anny help or insight would be appreciated
Dan

So the offending part of the script is

Code:
# main execution
for i in "${DIR}"; do


Why do you have a for loop? SInce you only give it one item, it is unnecessary.
Quote:
Code:
 
    if [ -f "$i" = ${DIR} ]; then


Here you should get an error message, "[; too many arguments"

Do you mean:

Code:
if [ -f "$i" ]

But why would you test a directory with the file test?

Presumably what you want is:
Code:
if [ -d "$i" ]

Quote:
Code:
        echo "${DIR}":" skipping modifing  ${DIR} no sutch dir exist" && continue
    else
        [ -f "${DIR}" ] && { chown "${USR}":"${GID}" ; }{ chmod  "${MOD}"; ] && echo ls -als ${DIR};
    fi

# 3  
Old 03-05-2009
The answer to both of your remarks
Are simple

1# The script is a adaptation to a earlier script that I wrote for file manipulation
2# I was beginning to be tired and could not see the obvious

And you showed me the way it works now

Thank you very much ;-)
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

In Bash shell - the ps -ef shows only the /bin/bash but the script name is not displayed

In Bash shell - the ps -ef shows only the /bin/bash but the script name is not displayed ? Is there any way to get the script names for the process command ? --- Post updated at 08:39 AM --- in KSH (Korn Shell), my command output shows the script names but when run in the Bash Shell... (3 Replies)
Discussion started by: i4ismail
3 Replies

2. Shell Programming and Scripting

How to block first bash script until second bash script script launches web server/site?

I'm new to utilities like socat and netcat and I'm not clear if they will do what I need. I have a "compileDeployStartWebServer.sh" script and a "StartBrowser.sh" script that are started by emacs/elisp at the same time in two different processes. I'm using Cygwin bash on Windows 10. My... (3 Replies)
Discussion started by: siegfried
3 Replies

3. Shell Programming and Scripting

Different behavior between bash shell and bash script for cmd

So I'm trying to pass certain json elements as env vars and use them later on in a script. Sample json: JSON='{ "Element1": "file-123456", "Element2": "Name, of, company written in, a very weird way", "Element3": "path/to/some/file.txt", }' (part of the) script: for s... (5 Replies)
Discussion started by: da1
5 Replies

4. Shell Programming and Scripting

Make a password protected bash script resist/refuse “bash -x” when the password is given

I want to give my long scripts to customer. The customer must not be able to read the scripts even if he has the password. The following command locks and unlocks the script but the set +x is simply ignored. The code: read -p 'Script: ' S && C=$S.crypt H='eval "$((dd if=$0 bs=1 skip=//|gpg... (7 Replies)
Discussion started by: frad
7 Replies

5. UNIX for Dummies Questions & Answers

Im new to bash scriping and i found this expression on a bash script what does this mean.

# check host value regex='^(||1|2|25)(\.(||1|2|25)){3}$' if ')" != "" ]; then if ]; then echo host $host not found exit 4 fi elif ]; then echo $host is an invalid host address exit 5 fi espeacailly the top regex part? ---------- Post updated at 06:58 PM ---------- Previous update was... (1 Reply)
Discussion started by: kevin298
1 Replies

6. Shell Programming and Scripting

Run bash script within a bash script

Hi everybody, Lets say, I have two bash scripts named down.sh and up.sh located in two different folders named ~/home/a/ and ~/home/b/ Now I want to write another bash script, located in ~/home/ which runs these other two scripts, so that I only have to execute this one comprehensive script... (1 Reply)
Discussion started by: NBurkhard
1 Replies

7. Shell Programming and Scripting

Bash Script: modify bash

Hey guys, i'm having trouble complete one of my bash scripts I'm hoping to --- 1. Modify bash so that then the user types "ls" the command that is executed is "ls -al" 2. Modify the point of entry in bash when the user accesses it, moving the initial location to /var I've somewhat done #2,... (9 Replies)
Discussion started by: LibRid
9 Replies

8. Shell Programming and Scripting

how to make your bash script run on a machine with csh and bash

hi, i have a script that runs on bash and would like to run it on a machine that has csh and bash. the default setting on that machine is csh. i dont want to change my code to run it with a csh shell. is there any way i can run the script (written in bash) on this machine? in other words is there... (3 Replies)
Discussion started by: npatwardhan
3 Replies

9. Shell Programming and Scripting

passing variable from bash to perl from bash script

Hi All, I need to pass a variable to perl script from bash script, where in perl i am using if condition. Here is the cmd what i am using in perl FROM_DATE="06/05/2008" TO_DATE="07/05/2008" "perl -ne ' print if ( $_ >="$FROM_DATE" && $_ <= "$TO_DATE" ) ' filename" filename has... (10 Replies)
Discussion started by: arsidh
10 Replies

10. Shell Programming and Scripting

problen with a join under AIX

Hello, I have a script shell under aix with a join of 2 files fic2.txt : test100:zone 1 :zone 2:zone 3 test10:zone 1:zone 2:zone 3 test:zone 1:zone 2:zone 3 fic3.txt: test100:zone 4:zone 5 test10:zone 4:zone 5 test:zone 4: zone 5 and the command : join -11 -21 -t: fic2.txt... (4 Replies)
Discussion started by: tbeghain
4 Replies
Login or Register to Ask a Question