question about popen in C


 
Thread Tools Search this Thread
Top Forums Programming question about popen in C
# 22  
Old 03-16-2011
And how was the instruction given? Did you read its output after opening or not? IOW post your complete code.
# 23  
Old 03-16-2011
i tested using
Code:
    FILE *file_pointer; char output[512];     file_pointer = popen_new("ls; ls", "r");     size_t bytes = read(fileno(file_pointer), output, 512);      printf(output);     printf("%d\n", pclose_new(file_pointer));

i cant see whats wrong here


would the problem be fixed if i used write command to print the output to stdout instead of printf?

Last edited by omega666; 03-16-2011 at 10:51 AM..
# 24  
Old 03-16-2011
Maybe there's more than 512 bytes of output, and you're forcing it to close before it's finished? This will break the pipe, causing it to get the signal SIGPIPE which will kill it prematurely, which will give you a weird exit code.

You can also use the fread command since you've converted it to a FILE * anyway.

Code:
fread(buf, 1, 512, fp);

# 25  
Old 03-16-2011
ok i changed it to fread and fwrite and it works now.

also if i change a value of a file pointer array to 0, and then if it gets compared to a NULL value will it crash? or should i just change it to a NULL value.

also when testing when i changed all the fread/fwrite amount to 1000 for maximum bytes used, i get errors like
/bin/sh: hdü·ls: not found

but if i keep it to like 512 it works fine, why is this?

also can you explain again why the command "ls; ls" prints the files line by line for each filename and not all in a line?

if i do fwrite, i get the output like

___ ___ ___ ___
___ ___ ___ ___

but otherwise when the execl command runs the output is like
___
___
___
___
___
etc

Last edited by omega666; 03-16-2011 at 01:46 PM..
# 26  
Old 03-16-2011
Quote:
Originally Posted by omega666
also if i change a value of a file pointer array to 0, and then if it gets compared to a NULL value will it crash?
I repeat: Setting an array element doesn't cause a program to crash. (Unless you went past the end of the array). Invalid pointers can't do anything -- they just sit there. Even intentionally setting an invalid pointer won't cause a program to crash right then and there.

Your program crashes when it tries to dereference an invalid pointer.

In short:
Code:
int *x[2]; // Doesn't crash
x[0]=NULL; // doesn't crash.
x[0]=0; // same as NULL, but generates compiler warning.  NULL is better.
x[0]=0xdeadbeef; // Doesn't crash, but generates compiler warning.
printf("contents of pointer are %d\n", *(x[0])); // CRASH!


Quote:
also when testing when i changed all the fread/fwrite amount to 1000 for maximum bytes used, i get errors like
/bin/sh: hdü·ls: not found

but if i keep it to like 512 it works fine, why is this?
Post your complete code. I can't tell why from here but it sounds like you forgot to check how many bytes you actually read again. You can't assume you got 1000, you could easily have gotten less!

Furthermore, don't write 1000 bytes unless you actually have 1000 bytes to write. Only write the number of bytes you actually have...
Quote:
also can you explain again why the command "ls; ls" prints the files line by line for each filename and not all in a line?
There is a system call isatty() which you can use to check if an open file descriptor is a terminal or not.

When standard output is a terminal, ls checks to see how wide your terminal is and splits up its columns accordingly.

When standard output is not a terminal it knows nothing about your screen and just prints one column.

Try ls | cat, it will print one column for exactly the same reason.

Quote:
if i do fwrite, i get the output like

___ ___ ___ ___
___ ___ ___ ___
This is because you're letting ls print directly to the screen. It will know that standard output is a terminal by checking isatty(), and check how wide your screen is, and print columns accordingly.
# 27  
Old 03-16-2011
Code:
#define MAX 1000
int main(int argc, char **argv) {
    int i; char comm[MAX]; 
    for (i = 1; i<argc; i++) {
        strcat(comm,argv[i]);
        strcat(comm," ");
    }
    printf("%d\n",system_new(comm));
    FILE *file_pointer; char output[MAX];
    file_pointer = popen_new(comm, "r");
    fread(output, 1, MAX, file_pointer); 
    printf(output);
    printf("%d\n",pclose_new(file_pointer));
    file_pointer = popen_new(comm, "w");
    fwrite(output, 1, MAX, file_pointer); 
    printf("%d\n",pclose_new(file_pointer));
    return 0;
}

and i gave the input like
./my_prog "ls; ls"

also how do i use isatty() for the execl command to print it horizontally and not vertically?
# 28  
Old 03-16-2011
For the fourth time, stop using printf for this! It doesn't do what you think it does!

Code:
#define MAX 1000
int main(int argc, char **argv) {
    int i; char comm[MAX]; 

    // As described before, arrays on the stack are undefined until
    // you put something in them.  so strcat might find something in there
    // already.  Put a null terminator at the beginning to inform it that it's
    // empty.
    comm[0]='\0';

    for (i = 1; i<argc; i++) {
        strcat(comm,argv[i]);
        strcat(comm," ");
    }
    // This is OK because you're using a string.
    printf("%d\n",system_new(comm));

    FILE *file_pointer; char output[MAX];
    file_pointer = popen_new(comm, "r");
    size_t size=fread(output, 1, MAX, file_pointer); 
    // THIS IS WRONG for many reasons!
    // 1) Never use printf without a format string!  If 'output' contains %s or
    // something, that will cause printf to try and read from the stack, which
    // will crash, because there's nothing there!
    // 2) 'output' isn't a proper character string anyway.  PRINTF CANNOT
    // PRINT IT.  It can't know where it ends, it'll either end too soon or
    // too late.
    // printf(output);
    fwrite(output, 1, size, stdout);
    printf("%d\n",pclose_new(file_pointer));
    file_pointer = popen_new(comm, "w");
    // You're writing MAX bytes even though we may have read far less than MAX bytes.
    // That ends up printing bytes we never set to anything before, which
    // are undefined -- meaning could be anything.  In your case you get 
    // garbage.
    // Only write as many bytes as you actually read!
    // fwrite(output, 1, MAX, file_pointer); 
    fwrite(output, 1, size, file_pointer);
    printf("%d\n",pclose_new(file_pointer));
    return 0;
}

Quote:
also how do i use isatty() for the execl command to print it horizontally and not vertically?
You don't. You can only control whether ls gets a tty by actually giving it a tty. On some systems though, you can force ls to print columns with the -C option. I don't know if this will work for you though, since I still don't know what your system is after weeks of asking.

Last edited by Corona688; 03-16-2011 at 02:51 PM..
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Popen problem

Hello all, I am reading a huge zip file in POPEN process and then writting that to a normal file which of 2GB. Now the process is failing when I looked for the cause someother process comming in after I read my file and it is deleting the zip. But in theory the popen command should read the... (5 Replies)
Discussion started by: arunkumar_mca
5 Replies

2. Programming

question about system and popen in C

in man system it talks about SIGCHLD will be blocked, and SIGINT and SIGQUIT will be ignored. Does this signal stuff also happen in popen command? (even though man popen says nothing about signals) also if I am not using wait(&status) and I am using waitpid(pid, NULL, 0) how would... (1 Reply)
Discussion started by: omega666
1 Replies

3. Programming

segmentation fault while using popen

hi, i am trying to use popen to run a grep process and check if the pattern exists in the file that i am searching in. i am getting segmentation fault when i try to execute the following code char *cd; char flag; char hdr_flpsp; char hdr_flpsp2; FILE *fp; printf ("program starts");... (1 Reply)
Discussion started by: sais
1 Replies

4. UNIX for Advanced & Expert Users

popen and pclose solved

Hi I am trying to use popen function with wrtie option to give inputs to ftp command. #include "stdio.h" int main(int argv ,char *argc) { int size=0; char *buf; FILE *fp; fp = popen("ftp","w"); while(getline(&buf,&size,stdin) != -1) write(fp,buf);... (0 Replies)
Discussion started by: kumaran_5555
0 Replies

5. Programming

prolems with pipes and popen in c

Hi! I'm trying to write a c program. The child process must transmit to the parent a file name and the parent must count the lines from the file and return te result to the child. Here is what i've done. It doesn't stop running, I guess. I'm sorry if it's an ugly code, i'm new at this stuff,... (2 Replies)
Discussion started by: alina89
2 Replies

6. Shell Programming and Scripting

Python: popen problems

Hello I'm writing a web server in python(obelisk-http.sourceforge.net) and I'm having a greeat problem with POST method it like that When someone make a POST request to the server it must open the executable(perl/python/.exe/elf) and send to the STANDART in (stdin) the request and get the... (2 Replies)
Discussion started by: sendai
2 Replies

7. Programming

using popen with background process

hi, how to work with a background process without a controlling terminal to make use of popen or system call ? when ever i use popen or system function call in foreground process, there is no problem with respect to that .. but when the same program is run as a background process without a... (7 Replies)
Discussion started by: matrixmadhan
7 Replies

8. Programming

popen and tar, please HELP!

Hi there, I'm facing a problem running the tar command with the popen function. FILE* fp = popen("tar czf - textfile","r") // output this program should give the output to the stdout. I don't know if it is possible and which function like fprint() etc. should I use. I suppose that I... (4 Replies)
Discussion started by: stef83
4 Replies

9. Programming

query in popen

hai friends I have written a tcp chat server in c.. I have designed a cgi program in c to control it... When i try to start the server from the cgi program, it is not starting. Why is that ? I have even tried giving the root ownership for all the programs.. Still its not. I have used the... (1 Reply)
Discussion started by: collins
1 Replies

10. Programming

question about popen();

Hi The following is my program to test popen() routine. The purpose is to print some contents of the corrent directory. But in fact, the output is only one character 'a', which I believe is the first char of the file "a.out". So, can anybody tell me what is wrong about this program?... (2 Replies)
Discussion started by: dell9
2 Replies
Login or Register to Ask a Question