Shell Programming and Scripting

Hi

I've write a script that can bring file from remote location
--------------------------------------------------------------------------------

Code:

 HOST=
 PORT=22
 USER=
 filename=SLACOM.$(date --date="-1 day" +"%y%m%d")
 PASSWORD=
 SOURCE_FILE=/tmp/SLACOM
 TARGET_DIR=/tmp/

 /usr/bin/expect<<EOD
 spawn /usr/bin/sftp -o Port=$PORT $USER@$HOST
 expect "password:"
 send "$PASSWORD\r"
 expect "sftp>"
 send "get $SOURCE_FILE/$filename $TARGET_DIR\r"
 expect "sftp>"
 send "bye\r"
 EOD

Above script i tried. Please help to complete the script

Moderator's Comments:

Please use code tags next time for your code and data. Thanks

There are plenty sftp script samples in the forums, have you searched?

Actually I am new here

Could you help me blow

Welcome nawafhossain,

I have a few to questions pose in response first:-Most importantly, What have you tried so far?

There are probably many ways to achieve most tasks, so giving us an idea of your style and thoughts will help us guide you to an answer most suitable to you so you can adjust it to suit your needs in future.

How important is checking file sizes? If sftp fails you get not only trace messages, but a non-zero return code.

We're all here to learn and getting the relevant information will help us all.


Kind regards,
Robin

Thanks for the reply.
It it important to check file size and check file records remote and local.
if the above is ok then it will compare the file date with file header date.
if ok then change file permission.

Need to mentioned that display error msg is important..

Hello nawafhossain

Have you heard of exchanging ssh-keys? They will allow you to open an SFTP connection without interaction for a password. It can be to the same user name as your local machine or you can direct them to use a different account on the remote server. It also means that you don't need to store the password anywhere, not even in your script which you then have to stop anyone else reading.

When you get it working, then you can put all the commands you want to issue within a file and use the -b flag of sftp

Errors get a non-zero return code from the sftp so you can be confident your transfer was successful.

I would suggest that you consider RudiC's suggestions too depending on your needs. Don't try to do too much within sftp - it is for transferring data, so use it for that. It you want to have some logic to compare file lists etc. then write that in your shell script and call sftp just for the data transfer bits. You may need to call it more than once to accomplish what you need but with ssh-keys in place it becomes a simple call. You can end up with:-

Code:

#!/bin/ksh
echo "I'm getting a list of files now..."
sftp -b get_list.sftp $rem_user@$rem_host >/tmp/get_list.output

echo "I'm working out the file I want"

echo "I'm getting the required file back"
echo "cd $target_dir
get $req_file" > transfer_file.sftp
sftp -b transfer_file.sftp $rem_user@$rem_host >/tmp/transfer_file.output

RC=$?
echo "The sftp completed with return code $RC
if [ $RC -ne 0 ]
   echo "ERROR!"
else
   echo "Transfer succeeded, naturally."
fi

I hope that this helps,
Robin