Sponsored Content
Top Forums Shell Programming and Scripting Better solution for this "if" spaghetti Post 303023603 by MadeInGermany on Wednesday 19th of September 2018 03:56:51 PM
Old 09-19-2018
To construct variables from nother variables like
Code:
SUCC_CMD2="$SUCC_CMD $TAG $VALUE arg4"
FAIL_CMD2="${SUCC_CMD2//arg4/arg5}"

can go awfully wrong in some cases. Imaging $TAG or $VALUE contain "arg4"; is it intended to change these??
It is safer to repeat the previous
Code:
FAIL_CMD2="$SUCC_CMD $TAG $VALUE arg5"

And this will still go wrong in case $TAG or $VALUE contain a wildcard like *
Most safe is to have only one common static variable
Code:
BASE_CMD="base_cmd arg1"

and add the arguments in the branch structure:
Code:
case $err in
0)
  if [ -z "$TAG" ];then
    $BASE_CMD arg2
  else
    $BASE_CMD arg2 "$TAG" "$VALUE" arg4
  fi
;;
*)
  if [ -z "$TAG" ];then
    $BASE_CMD arg3
  else
    $BASE_CMD arg2 "$TAG" "$VALUE" arg5
  fi
  exit 1
;;
esac

And you more easily see logical errors.

Last edited by MadeInGermany; 09-19-2018 at 06:06 PM.. Reason: Added quotes around variables in command arguments
This User Gave Thanks to MadeInGermany For This Post:
 

9 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Explain the line "mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'`"

Hi Friends, Can any of you explain me about the below line of code? mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'` Im not able to understand, what exactly it is doing :confused: Any help would be useful for me. Lokesha (4 Replies)
Discussion started by: Lokesha
4 Replies

2. Shell Programming and Scripting

cat $como_file | awk /^~/'{print $1","$2","$3","$4}' | sed -e 's/~//g'

hi All, cat file_name | awk /^~/'{print $1","$2","$3","$4}' | sed -e 's/~//g' Can this be done by using sed or awk alone (4 Replies)
Discussion started by: harshakusam
4 Replies

3. Shell Programming and Scripting

awk command to replace ";" with "|" and ""|" at diferent places in line of file

Hi, I have line in input file as below: 3G_CENTRAL;INDONESIA_(M)_TELKOMSEL;SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL My expected output for line in the file must be : "1-Radon1-cMOC_deg"|"LDIndex"|"3G_CENTRAL|INDONESIA_(M)_TELKOMSEL"|LAST|"SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL" Can someone... (7 Replies)
Discussion started by: shis100
7 Replies

4. Shell Programming and Scripting

how to use "cut" or "awk" or "sed" to remove a string

logs: "/home/abc/public_html/index.php" "/home/abc/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" how to use "cut" or "awk" or "sed" to get the following result: abc abc xyz xyz xyz (8 Replies)
Discussion started by: timmywong
8 Replies

5. Solaris

The slices "usr", "opt", "tmp" disappeared!!! Help please.

The system don't boot. on the screen appears following: press enter to maintenance (or type CTRL-D to continue)...I checked with format command. ... the slices "0-root","1-swap","2-backup" exist. ...the slises "3-var","6-usr" -unassigned. :( (16 Replies)
Discussion started by: wolfgang
16 Replies

6. Ubuntu

What is solution for this error "tar: Exiting with failure status due to previous errors"?

Does anyone know what is solution for this error ?tar: Exiting with failure status due to previous errors from last 3 days I am trying to take backup of home/user directory getting again and again same error please anyone give me solution (8 Replies)
Discussion started by: Akshay Hegde
8 Replies

7. UNIX for Dummies Questions & Answers

Using "mailx" command to read "to" and "cc" email addreses from input file

How to use "mailx" command to do e-mail reading the input file containing email address, where column 1 has name and column 2 containing “To” e-mail address and column 3 contains “cc” e-mail address to include with same email. Sample input file, email.txt Below is an sample code where... (2 Replies)
Discussion started by: asjaiswal
2 Replies

8. Shell Programming and Scripting

Bash script - Print an ascii file using specific font "Latin Modern Mono 12" "regular" "9"

Hello. System : opensuse leap 42.3 I have a bash script that build a text file. I would like the last command doing : print_cmd -o page-left=43 -o page-right=22 -o page-top=28 -o page-bottom=43 -o font=LatinModernMono12:regular:9 some_file.txt where : print_cmd ::= some printing... (1 Reply)
Discussion started by: jcdole
1 Replies

9. AIX

Apache 2.4 directory cannot display "Last modified" "Size" "Description"

Hi 2 all, i have had AIX 7.2 :/# /usr/IBMAHS/bin/apachectl -v Server version: Apache/2.4.12 (Unix) Server built: May 25 2015 04:58:27 :/#:/# /usr/IBMAHS/bin/apachectl -M Loaded Modules: core_module (static) so_module (static) http_module (static) mpm_worker_module (static) ... (3 Replies)
Discussion started by: penchev
3 Replies
ERR(3)							   BSD Library Functions Manual 						    ERR(3)

NAME
err, verr, errx, verrx, warn, vwarn, warnx, vwarnx, -- formatted error messages SYNOPSIS
#include <err.h> void err(int eval, const char *fmt, ...); void errx(int eval, const char *fmt, ...); void warn(const char *fmt, ...); void warnx(const char *fmt, ...); #include <stdarg.h> void verr(int eval, const char *fmt, va_list args); void verrx(int eval, const char *fmt, va_list args); void vwarn(const char *fmt, va_list args); void vwarnx(const char *fmt, va_list args); DESCRIPTION
The err() and warn() family of functions display a formatted error message on the standard error output. In all cases, the last component of the program name, a colon character, and a space are output. If the fmt argument is not NULL, the printf(3) -like formatted error message is output. The output is terminated by a newline character. The err(), verr(), warn(), and vwarn() functions append an error message obtained from strerror(3) based on a code or the global variable errno, preceded by another colon and space unless the fmt argument is NULL. The err(), verr(), warn(), and vwarn() functions use the global variable errno to look up the error message. The errx() and warnx() functions do not append an error message. The err(), verr(), errx(), and verrx() functions do not return, but exit with the value of the argument eval. EXAMPLES
Display the current errno information string and exit: if ((p = malloc(size)) == NULL) err(1, NULL); if ((fd = open(file_name, O_RDONLY, 0)) == -1) err(1, "%s", file_name); Display an error message and exit: if (tm.tm_hour < START_TIME) errx(1, "too early, wait until %s", start_time_string); Warn of an error: if ((fd = open(raw_device, O_RDONLY, 0)) == -1) warnx("%s: %s: trying the block device", raw_device, strerror(errno)); if ((fd = open(block_device, O_RDONLY, 0)) == -1) err(1, "%s", block_device); SEE ALSO
exit(3), printf(3), perror(3), strerror(3) HISTORY
The err() and warn() functions first appeared in 4.4BSD. BSD
March 6, 1999 BSD
All times are GMT -4. The time now is 10:42 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy