How can I do this better? Post: 303019717

Sponsored Content

Top Forums Shell Programming and Scripting How can I do this better? Post 303019717 by Rhysers on Wednesday 4th of July 2018 11:41:09 AM

07-04-2018

Registered User

How can I do this better?

Hello,

Still learning over here. I made the below based on what I've learned so far and what I've stolen from others. It updates my dynDNS addresses, both IPv4 and v6. I'm looking to see what I could have done better or how those more experienced than me would have done it. Thanks for your time!
(It wont let me post links cuz I'm still new here so I dropped one of the 't's in the URLs on purpose)

Code:

#! /bin/bash

IP6temp=$(ip -o -6 addr show eno1 | sed -e 's/^.*inet6 \([^ ]\+\).*/\1/' | grep 64 | grep 200) #All of this is to get one globally unique IPv6
#echo $IP6temp #debugging
IP6=$(echo $IP6temp | cut -f1 -d'/') #get rid of the /notation
#echo "IPv6 Address is $IP6"
last_ip_file="/tmp/last_ip"
last_ip=`cat $last_ip_file`
ip=$(curl -s htp://dynamicdns.park-your-domain.com/getip)
#echo "IPV4 is $ip"
if [ "$ip" == "$last_ip" ]; then
        #echo "IP Still same, not need to update."
        exit 0
fi

response=$(curl -s "<HTPS://<UserName>:<API-Key>@members.dyndns.org/v3/update?hostname=<domain>.better-than.tv&myip=$ip,$IP6")
#echo $response
response=$(curl -s "htps://<UserName>:<API-Key>@members.dyndns.org/v3/update?hostname=<other domain>.better-than.tv&myip=$ip")
echo $ip > $last_ip_file

Rhysers

View Public Profile for Rhysers

Find all posts by Rhysers

LEARN ABOUT SUSE

rbash

RBASH(1)						      General Commands Manual							  RBASH(1)

NAME

       rbash - restricted bash, see bash(1)

RESTRICTED SHELL

       If  bash  is  started with the name rbash, or the -r option is supplied at invocation, the shell becomes restricted.  A restricted shell is
       used to set up an environment more controlled than the standard shell.  It behaves identically to bash with the exception that the  follow-
       ing are disallowed or not performed:

       o      changing directories with cd

       o      setting or unsetting the values of SHELL, PATH, ENV, or BASH_ENV

       o      specifying command names containing /

       o      specifying a filename containing a / as an argument to the .  builtin command

       o      specifying a filename containing a slash as an argument to the -p option to the hash builtin command

       o      importing function definitions from the shell environment at startup

       o      parsing the value of SHELLOPTS from the shell environment at startup

       o      redirecting output using the >, >|, <>, >&, &>, and >> redirection operators

       o      using the exec builtin command to replace the shell with another command

       o      adding or deleting builtin commands with the -f and -d options to the enable builtin command

       o      using the enable builtin command to enable disabled shell builtins

       o      specifying the -p option to the command builtin command

       o      turning off restricted mode with set +r or set +o restricted.

       These restrictions are enforced after any startup files are read.

       When a command that is found to be a shell script is executed, rbash turns off any restrictions in the shell spawned to execute the script.

SEE ALSO

       bash(1)

GNU Bash-4.0							    2004 Apr 20 							  RBASH(1)