Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Bad substitution issues.. but why?
Top Forums UNIX for Beginners Questions & Answers Bad substitution issues.. but why? Post 302980281 by Don Cragun on Thursday 25th of August 2016 04:54:44 PM
Old 08-25-2016
Quote:
Originally Posted by kidi
i am trying to prepare a train and test dataset, for which i need to randomly split the data into corresponding folders (train,test)..

I began on a simple script, but seem to get som weird error messages, that i cannot make sense of?..

what am I doing wrong?
Code:
#!/bin/bash
RED='\033[0;31m'
NC='\033[0m' # No Color


if [[ $1 = "" ]]
	then
		echo -e "${RED}Missing Workspace name! -  Provide a name!${NC}"
	exit 1	
fi

if [[ $2 = "" ]]
	then 
		echo -e "${RED}Missing path to dataset - SPH files${NC}"
	#exit 1	
fi

if [[ $3 = "" ]]
	then 
		echo -e "${RED}Missing path to Utt!${NC}"
	#exit 1
fi		

WORKSPACE=$1
PATH_TO_DATASET=$2
PATH_TO_UTT=$3

#Create the folder 

mkdir ../${WORKSPACE}
 
cd ../${WORKSPACE}
ln -s ../wsj/s5/steps .
ln -s ../wsj/s5/utils .
ln -s ../../src .

cp ../wsj/s5/path.sh .

mkdir -p ../${WORKSPACE}/exp
mkdir -p ../${WORKSPACE}/conf
mkdir -p ../${WORKSPACE}/data
mkdir -p ../${WORKSPACE}/data/test
mkdir -p ../${WORKSPACE}/data/train
mkdir -p ../${WORKSPACE}/data/local
mkdir -p ../${WORKSPACE}/data/local/lang

# Modify if Help script is needed
#################################
# Change order of utterance and name! 
# python help_scripts/change_order_name_utt.py  /PATH/TO/UTTERANCE 

# Partition data randomly into train and test. 
SPLIT=0.5 #train/test split
NUMBER_OF_FILES = $(ls $PATH_TO_DATASET |  wc -l) ## number of directories in the dataset

for ((i=1; i<=$(NUMBER_OF_FILES); i++))
do
	ran = ${python -c "import random; print random.randdouble(0,1)"}
	echo ${ran}
done

output
Code:
../workspace_setup.sh: line 54: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: ((: i<=: syntax error: operand expected (error token is "<=")

Please add a new post to your thread when you change things. Do not go back and edit the 1st post in a thread after people have added other posts to the thread. People who have responded to your thread do not receive any notice when you edit a post in a thread. And, doing that makes it hard for someone else reading your thread for the first time to figure out what happened.

You can't just randomly change parentheses to braces and braces to parentheses:
Code:
$( command )

is for command substitution.

Code:
${variable}

is variable expansion.

And, as I said in post #5 in this thread, there can't be any spaces around the = in a shell variable assignment (before OR after) the <equal-sign>.

Maybe something like:
Code:
#!/bin/bash
RED='\033[0;31m'
NC='\033[0m' # No Color

if [[ $1 = "" ]]
then
	echo -e "${RED}Missing Workspace name! -  Provide a name!${NC}"
fi

if [[ $2 = "" ]]
then 
	echo -e "${RED}Missing path to dataset - SPH files${NC}"
fi

if [[ $3 = "" ]]
then 
	echo -e "${RED}Missing path to Utt!${NC}"
fi

if [[ $1 = "" ]] || [[ $2 = "" ]] || [[ $3 == "" ]]
then	
	exit 1
fi

WORKSPACE=$1
PATH_TO_DATASET=$2
PATH_TO_UTT=$3

#Create the folder 
mkdir ../${WORKSPACE}
 
cd ../${WORKSPACE}
ln -s ../wsj/s5/steps .
ln -s ../wsj/s5/utils .
ln -s ../../src .

cp ../wsj/s5/path.sh .

mkdir -p exp conf data/local/lang data/test data/train

# Modify if Help script is needed
#################################
# Change order of utterance and name! 
# python help_scripts/change_order_name_utt.py  /PATH/TO/UTTERANCE 

# Partition data randomly into train and test. 
SPLIT=0.5 #train/test split
NUMBER_OF_FILES=$(ls ${PATH_TO_DATASET} |  wc -l) # number of directories in the dataset

for ((i=1; i<=${NUMBER_OF_FILES}; i++))
do
	ran=$(python -c "import random; print random.randdouble(0,1)")
	echo ${ran}
done

Since I don't have a file hierarchy to copy as required by this script, it is totally untested, but this should be a step closer to what you want than what is now in post #1 in this thread.
Last edited by Don Cragun; 08-25-2016 at 07:44 PM.. Reason: Fix parens on python command substitution as noted in post #12.
This User Gave Thanks to Don Cragun For This Post:
wisecracker
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Bad Substitution

Need Help... I am getting a bad substitution error on my script on a Solaris Server. However the script has been proven to work on HPUX and Solaris servers... #!/usr/bin/sh # # Set the location of the tzupdater.jar file # JAR=/tmp/tzupdater.jar # <<<<< UPDATE THIS LINE... (3 Replies)
Discussion started by: D_Redd74
3 Replies

2. Shell Programming and Scripting

Array reference - bad substitution

I've created a series of arrays named as follows: row1 row2 row3 . . . row10 Each has 4 elements. I'm trying to echo the array elements out in a for loop. Here's what I have: for ((i=1;i<=10;i++)) do for ((j=1;j<=4;j++)) do eval out=${row`echo $i`} echo -n $out (3 Replies)
Discussion started by: swankgd
3 Replies

3. Shell Programming and Scripting

bad substitution error in ksh

hi, i created a shell script having the following content: #! /usr/bin/ksh FROM="myemail@domain.com" MAILTO="someemail@domain" SUBJECT="TEST" BODY="/export/home/adshocker/body.txt" ATTACH="/export/home/adshocker/attach.prog" echo $ATTACH ATTACH_NAME="${ATTACH##*/}" echo $ATTACH_NAME... (5 Replies)
Discussion started by: adshocker
5 Replies

4. Shell Programming and Scripting

bad substitution error in ksh

Hello, In bash I can use the following: TMP=12345 MID=${TMP:1:1} the expected result is: 2 but when using KSH I'm getting a ''bad substitution" error. What is the correct syntaxin ksh? Thanks (2 Replies)
Discussion started by: LiorAmitai
2 Replies

5. UNIX for Dummies Questions & Answers

bad substitution

#!/bin/bash a1=( win 12,01,02,03,04 ) a2=( pre 04,05,06 ) a3=( msn 06,07,08,09 ) Given the above arrays, I want the script to return/echo the following in a loop; win 12,01,02,03,04 pre 04,05,06,07 msn 06,07,08,09 But I can't get it to do as such. I've tried; (2 Replies)
Discussion started by: Muhammad Rahiz
2 Replies

6. Shell Programming and Scripting

bad substitution error!

Hi All, I'm building a new shell script but i'm facing a problem with one line which is giving "bad substitution" error. Please assist script lines: #!/bin/sh printf "%s: " "Occurrence DATE (YYYYMMDD)"; read DATE shortdate=${DATE#??} o/p: ./test1: bad substitution This command is... (2 Replies)
Discussion started by: Dendany83
2 Replies

7. Programming

Make: Bad Substitution

Hi, I have a make file which I try to execute, but it failed when it arrived to the line: for r in ${PIPESTATUS }; do if (($r != 0)); then exit $r; fi;done; With the Error: ""make:/bin/sh: Bad substitution"" Or the Error: "make:${PIPESTATUS[...}: Bad substitution" (Depend on the operating... (3 Replies)
Discussion started by: nadne
3 Replies

8. Shell Programming and Scripting

Why I get bad bad substitution when using eval?

Why I get bad replace when using eval? $ map0=( "0" "0000" "0") $ i=0 $ eval echo \${map$i} 0000 $ a=`eval echo \${map$i}` !!!error happens!!! bash: ${map$i}: bad substitution How to resolve it ? Thanks! (5 Replies)
Discussion started by: 915086731
5 Replies

9. Shell Programming and Scripting

Bad substitution

Cant undestand :) why i have an error on line 2.it is working on my other boxes #!/bin/bash ret=$(echo Q | timeout 5 openssl s_client connect "${1`hostname`}:${2-443}" -ssl3 2> /dev/null) if echo "${ret}" | grep -q 'Protocol.*SSLv3'; then if echo "${ret}" | grep -q 'Cipher.*0000'; then ... (7 Replies)
Discussion started by: kenshinhimura
7 Replies

10. Shell Programming and Scripting

Bad substitution - ShellCheck says okay

ShellCheck doesn't find any issues with this script. #!/bin/bash # color_meanings: explain meanings of colors used in bash ls eval "$(echo "no:fi:di:ln:pi:so:do:bd:cd:or:mi:su:sg:tw:st:ex" | sed -e 's/:/=/g; s/\;/\n/g')" { IFS=: for i in $LS_COLORS do ... (18 Replies)
Discussion started by: Xubuntu56
18 Replies
All times are GMT -4. The time now is 08:21 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy