Please indent your code to show its structure! Adding blank lines (instead of indenting) still hides the fact that all of your if statements, tar commands, rsync commands, rm commands, and variable assignments are inside a loop and that your mailx commands and continue statements are conditional in your if then or else clauses. And, it hides the fact that you set MailAddress every time you go through your loop when it just needs to be set once before your loop starts. And separating commands like tar into a different "paragraph" than the code that tests its return value gives a visual cue that it is OK to add other code between them. (But, if you do add any code there the following "paragraph" testing the return code of your tar. rsync, and rm commands will NOT work as desired and there will be no indication that a logic error in your code has been introduced!)

I still question why you want one e-mail per directory processed instead of one e-mail containing the status of all of the directories you are processing, but that it is up to. (Note also that the way I suggested doing it, any status or diagnostic messages from tar, rsync, and rm would have appeared in you e-mail as a permanent record of what happened. The way you are doing it, any output from those commands will appear on your terminal, but will not be part of your permanent record in the archival status stored in you mailbox.)

I repeat that, the way your loop is written, the DIR and SaveDir variables will ALWAYS have the same value. Why use two variables when they can never hold different values? (It forces me to look at your entire script to try to find where you set one of them to have a different value.)

And, as stated before, even though you name your variables DIR and SaveDir, your code creates regular files that are sometimes left lying around that later runs of your script should ignore (or write a diagnostic message telling you that they should be removed). (For example, if the tar succeeds and the rsync fails, a .tar file will be left around. And, you are already noting that rm can fail leaving a .tar lying around. With your code, in these cases, the next time you run your code you'll create a directory.tar.tar file and try to rsync it to your archive area.)

Note that variables are expanded inside double-quoted strings. The command:

Code:

mail -s "failed "$SaveDir" " $MailAddress <<< "... "$SaveDir" failed due to error"

should be written as:

Code:

mail -s "failed $SaveDir" $MailAddress <<< "... $SaveDir failed due to error"

to protect yourself from serious side effects that will jump up and bite you if one of your directory names ends up containing a whitespace character at some point in the future.