Please indent your code to show its structure! Adding blank lines (instead of indenting) still hides the fact that all of your if statements, tar commands, rsync commands, rm commands, and variable assignments are inside a loop and that your mailx commands and continue statements are conditional in your if then or else clauses. And, it hides the fact that you set MailAddress every time you go through your loop when it just needs to be set once before your loop starts. And separating commands like tar into a different "paragraph" than the code that tests its return value gives a visual cue that it is OK to add other code between them. (But, if you do add any code there the following "paragraph" testing the return code of your tar. rsync, and rm commands will NOT work as desired and there will be no indication that a logic error in your code has been introduced!)
I still question why you want one e-mail per directory processed instead of one e-mail containing the status of all of the directories you are processing, but that it is up to. (Note also that the way I suggested doing it, any status or diagnostic messages from tar, rsync, and rm would have appeared in you e-mail as a permanent record of what happened. The way you are doing it, any output from those commands will appear on your terminal, but will not be part of your permanent record in the archival status stored in you mailbox.)
I repeat that, the way your loop is written, the DIR and SaveDir variables will ALWAYS have the same value. Why use two variables when they can never hold different values? (It forces me to look at your entire script to try to find where you set one of them to have a different value.)
And, as stated before, even though you name your variables DIR and SaveDir, your code creates regular files that are sometimes left lying around that later runs of your script should ignore (or write a diagnostic message telling you that they should be removed). (For example, if the tar succeeds and the rsync fails, a .tar file will be left around. And, you are already noting that rm can fail leaving a .tar lying around. With your code, in these cases, the next time you run your code you'll create a directory.tar.tar file and try to rsync it to your archive area.)
Note that variables are expanded inside double-quoted strings. The command:
should be written as:
to protect yourself from serious side effects that will jump up and bite you if one of your directory names ends up containing a whitespace character at some point in the future.
Hi.
I'm trying to copy multiple folders from the remote machine to the local machine. I wrote a batch file to run an ftp window.
The problem I am having is that the only command to copy files is mget *, and this copies only files, not folders.
For example, ftp ts555
cd ts555/test
' test... (5 Replies)
I have written a shell script to perform backups using tar, rsync and optionally utilise lvm snapshots. The script is not finished but is in a working state and comments/descriptions are poor.
I would greatly appreciate any criticism and suggestions of the script to help improve my own learning... (0 Replies)
I have in directory /media/AUDIO/WAVE many .mp3 files with names like:
my filename_01of02.mp3
my filename_02of02.mp3
Your File_01of06.mp3
Your File_02of06.mp3
etc....
In the same directory, /media/AUDIO/WAVE, I have many folders with names like
9780743579490
9780743579491
etc..
Inside... (7 Replies)
I have 1000's of directories which is named as numbers. Each directory contains multiple files. Each of these directories have a file named "att". I need to rename all the att files by adding the directory name followed by "_" then att for each of the directories.
Directories
120
att... (2 Replies)
Hi all,
I have a tar file and inside that tar file is a folder with additional tar.gz files. What I want to do is look inside the first tar file and then find the second tar file I'm looking for, look inside that tar.gz file to find a certain directory. I'm encountering issues by trying to... (1 Reply)
I would like to confirm my file.tar is been tar-ed correctly before I remove them. But I have very limited disc space to untar it.
Can I just do the listing instead of actual extract it? Can I say confirm folder integrity if the listing is sucessful without problem?
tar tvf file1.tar
... (1 Reply)
Hi All,
I have to requirement to write a shell script to move file from one folder (A) to another five folder (B,C,D,E,F) and destination folder should be blank. In not blank just skip.
This script will run as a scheduler every 2 minutes. It will check number of files in folder A and move 1 to... (9 Replies)
Good day, everyone!
I'm very new to bash scripting. Our teacher gave us a task to create a script that basically does the same job the 'du' command does, with the difference that 'du' command gives an output in the form of
<size> <folder name>and what we need is
<folder name> <size>As for... (1 Reply)
1. The problem statement, all variables and given/known data:
The task is to create a script that would reproduce the output of 'du' command, but in a different way: what 'du' does is:
<size> <folder name>and what is needed is
<folder name> <size>We need to show only 10 folders which are the... (3 Replies)
HI Guys,
I have some 8 files with different name and extensions. I need to check if they are present in a specific folder or not and also want that script to show me which all are not present. I can write if condition for each file but from a developer perspective , i feel that is not a good... (3 Replies)