Sponsored Content
Top Forums Shell Programming and Scripting Script to tar/rsync/rm multiple folder names Post 302971164 by Don Cragun on Saturday 16th of April 2016 11:25:35 PM
Old 04-17-2016
A few notes on your code and a possible alternative for you to consider...
  1. Learn to indent your code as bakunin has suggested several times. It not only looks more professoinal, it makes it easier for anyone (including you) to read and understand what your code is trying to do, makes it easer to spot missing syntax elements (like a do or a done or a then or a fi). I have a coding style that is a little bit different form bakunin's style. I don't care what style you use as long as you pick one and use it consistently.
  2. Since you cd into the directory containing the directories you want to process and use for DIR in *, $DIR will never expand to a string containing a <slash> character and, therefore, fSaveDir will always contain exactly the same string as DIR. Therefore, I have gotten rid of fSaveDir and just use DIR.
  3. Since you are creating tar archives in the directory containing your project directories, and you don't remove them if something fails, you need to verify that the file you are processing ($DIR) is a directory. There are several ways to do that. I have chosen to simply test for non-directory file in an if statement and use a continue to silently skip over non-directory files.
  4. The sendmail utiltiy (at least on my system) does not treat its 1st operand as a subject line (and has no option to set a subject line on the command line). I don't see why you would want a separate e-mail message for each project processed, and I don't see why you would want to stop all processing if you hit one error. The code below uses mailx instead of sendmail and only sends one message containing the status for each project directory processed by one invocation of your script.
  5. As noted before by bakunin, c and f are not options to tar and should not be preceded by a hyphen.
Please note that none of this has been tested in any way, but I think it comes close to doing what you are trying to do:
Code:
#!/bin/bash
cd /to_be_archived/
for DIR in *
do	if [ ! -d "$DIR" ]
	then	# This file is not a directory, skip to next file...
		continue
	fi
	printf 'Processing proejct: %s\n' "$DIR"
	if ! tar cf "${DIR}".tar "${DIR}"
	then	printf 'Creating "%s.tar" failed.\n' "$DIR"
		continue
	fi
	if ! rsync -a "${DIR}".tar /archived_projects/
	then	printf 'rsync of "%s.tar" failed.\n' "$DIR"
		continue
	fi
	if ! rm -f "${DIR}".tar
	then	printf 'Removing "%s.tar" failed.\n' "$DIR"
		continue
	fi
	if ! rm -rf "${DIR}"
	then	printf 'Removing project "%s" failed.\n' "$DIR"
		continue
	fi
	printf 'Project '%s" successfully archived and removed.\n' "${DIR}"
done 2>&1 | mailx -s "${0##*/} Status report $(date)" robertkwild@gmail.com

 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Copying multiple folders to local machine (don't know folder names)

Hi. I'm trying to copy multiple folders from the remote machine to the local machine. I wrote a batch file to run an ftp window. The problem I am having is that the only command to copy files is mget *, and this copies only files, not folders. For example, ftp ts555 cd ts555/test ' test... (5 Replies)
Discussion started by: leenyburger
5 Replies

2. Shell Programming and Scripting

lvm/tar/rsync backup script feedback/criticism

I have written a shell script to perform backups using tar, rsync and optionally utilise lvm snapshots. The script is not finished but is in a working state and comments/descriptions are poor. I would greatly appreciate any criticism and suggestions of the script to help improve my own learning... (0 Replies)
Discussion started by: jelloir
0 Replies

3. Shell Programming and Scripting

Script to move files with similar names to folder

I have in directory /media/AUDIO/WAVE many .mp3 files with names like: my filename_01of02.mp3 my filename_02of02.mp3 Your File_01of06.mp3 Your File_02of06.mp3 etc.... In the same directory, /media/AUDIO/WAVE, I have many folders with names like 9780743579490 9780743579491 etc.. Inside... (7 Replies)
Discussion started by: glev2005
7 Replies

4. Shell Programming and Scripting

editing names of files in multiple folder

I have 1000's of directories which is named as numbers. Each directory contains multiple files. Each of these directories have a file named "att". I need to rename all the att files by adding the directory name followed by "_" then att for each of the directories. Directories 120 att... (2 Replies)
Discussion started by: Lucky Ali
2 Replies

5. Shell Programming and Scripting

tar command to explore multiple layers of tar and tar.gz files

Hi all, I have a tar file and inside that tar file is a folder with additional tar.gz files. What I want to do is look inside the first tar file and then find the second tar file I'm looking for, look inside that tar.gz file to find a certain directory. I'm encountering issues by trying to... (1 Reply)
Discussion started by: bashnewbee
1 Replies

6. UNIX for Dummies Questions & Answers

Do I need to extract the entire tar file to confirm the tar folder is fine?

I would like to confirm my file.tar is been tar-ed correctly before I remove them. But I have very limited disc space to untar it. Can I just do the listing instead of actual extract it? Can I say confirm folder integrity if the listing is sucessful without problem? tar tvf file1.tar ... (1 Reply)
Discussion started by: vivien_chu
1 Replies

7. Shell Programming and Scripting

Script to move one folder to multiple folder...

Hi All, I have to requirement to write a shell script to move file from one folder (A) to another five folder (B,C,D,E,F) and destination folder should be blank. In not blank just skip. This script will run as a scheduler every 2 minutes. It will check number of files in folder A and move 1 to... (9 Replies)
Discussion started by: peekuabc
9 Replies

8. Shell Programming and Scripting

Bash script for printing folder names and their sizes

Good day, everyone! I'm very new to bash scripting. Our teacher gave us a task to create a script that basically does the same job the 'du' command does, with the difference that 'du' command gives an output in the form of <size> <folder name>and what we need is <folder name> <size>As for... (1 Reply)
Discussion started by: UncleIS
1 Replies

9. Homework & Coursework Questions

Bash script for printing folder names and their sizes

1. The problem statement, all variables and given/known data: The task is to create a script that would reproduce the output of 'du' command, but in a different way: what 'du' does is: <size> <folder name>and what is needed is <folder name> <size>We need to show only 10 folders which are the... (3 Replies)
Discussion started by: UncleIS
3 Replies

10. Shell Programming and Scripting

Checking Multiple File existance in a UNIX folder(Note: File names are all different)

HI Guys, I have some 8 files with different name and extensions. I need to check if they are present in a specific folder or not and also want that script to show me which all are not present. I can write if condition for each file but from a developer perspective , i feel that is not a good... (3 Replies)
Discussion started by: shankarpanda003
3 Replies
All times are GMT -4. The time now is 08:13 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy