Sponsored Content
Top Forums Shell Programming and Scripting Script to tar/rsync/rm multiple folder names Post 302971086 by bakunin on Friday 15th of April 2016 12:53:09 PM
Old 04-15-2016
Quote:
Originally Posted by robertkwild
Code:
#!/bin/bash
cd /to_be_archived/
for DIR in * ; do
fSaveDir="${DIR##*/}"
tar -cf "${fSaveDir}".tar "${fSaveDir}"
rsync -a "${fSaveDir}".tar /archived_projects/
if [ $? -ne 0 ]
then
mail -s "${fSaveDir}" robertw@molinare.co.uk <<< "project "${fSaveDir}" aborted due to error"
else
rm -f "${fSaveDir}".tar
rm -rf "${fSaveDir}"
fi
done

few questions tho,

lets say i have tons of projects in the "to_be_archived" folder and the script runs and it fails on a job number 2 out of 20 does that mean the script will exit out completley or will it carry on with the other folders?
few answers:

first, the script will continue because it will exit only if you tell it so look at its code (properly indented, as i told you to do) and its structure becomes clear (i have shortened some lines to not overflow the screen:

Code:
#!/bin/bash
cd /to_be_archived/
for DIR in * ; do                V do this for every value of DIR:
     fSaveDir="${DIR##*/}"       |
     tar -cf [...]               |
     rsync -a [...]              |
     if [ $? -ne 0 ] ; then      |  V do this if the previous cmd failed:
          mail -s [...]          |  |
     else                        |    and this, if not:
          rm -f [...]            |  |
          rm -rf [...]           |  |
     fi                          |
done

You see what it does - it will do exactly that, nothing more, i promise! If you don't tell it to exit under cetain circumstances, it won't (should you want that: put an "exit" command in somewhere).

For a beginner you have done very good work. (sorry, if that sounds condescending, it isn't meant that way. Programming is like playing chess: you spend half an hour to learn the rules and then a lifetime to really play the game well.)

Now for some of the finer points: the variable "$?" is set anew after each command. This means that this part:

Code:
tar -cf "${fSaveDir}".tar "${fSaveDir}"
rsync -a "${fSaveDir}".tar /archived_projects/
if [ $? -ne 0 ] ; then
     [....]

might not exactly do what you want: suppose the tar-command encounters a problem. It would exit, set an error code which you do not observe, then the rsync-command will start and eventually do its job and you will never be notified about the problem the tar-command had. Even worse, the rsync-command would overwrite the last good copy you had in the archive with the faulty tar-file you just produced.

A big part of the art of script programming is to foresee what could possibly go wrong and take measures against that. You do not necessarily have to program a solution to a problem, but you want to become aware of it!

If a script has to do a, b, c and d you want to see as outcome that it did a and b, couldn't do c (ideally by giving the reason why) and therefore did not even try d. The last thing you want is the script to not recognize it didn't do c, attempt to do d (which would make no sense at all because it builds on the result of the previously run c), eventually "succeed" doing it (but with a completely unusable result) and telling you "all done successfully".

Look back at my model script from post #2: i looked at the return code of every command and put different error information for each command failing in. You do not have to exit the script as i did, but you should do something about a failing command and most probably stop the processing of the part at hand.

I hope this helps.

bakunin
 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Copying multiple folders to local machine (don't know folder names)

Hi. I'm trying to copy multiple folders from the remote machine to the local machine. I wrote a batch file to run an ftp window. The problem I am having is that the only command to copy files is mget *, and this copies only files, not folders. For example, ftp ts555 cd ts555/test ' test... (5 Replies)
Discussion started by: leenyburger
5 Replies

2. Shell Programming and Scripting

lvm/tar/rsync backup script feedback/criticism

I have written a shell script to perform backups using tar, rsync and optionally utilise lvm snapshots. The script is not finished but is in a working state and comments/descriptions are poor. I would greatly appreciate any criticism and suggestions of the script to help improve my own learning... (0 Replies)
Discussion started by: jelloir
0 Replies

3. Shell Programming and Scripting

Script to move files with similar names to folder

I have in directory /media/AUDIO/WAVE many .mp3 files with names like: my filename_01of02.mp3 my filename_02of02.mp3 Your File_01of06.mp3 Your File_02of06.mp3 etc.... In the same directory, /media/AUDIO/WAVE, I have many folders with names like 9780743579490 9780743579491 etc.. Inside... (7 Replies)
Discussion started by: glev2005
7 Replies

4. Shell Programming and Scripting

editing names of files in multiple folder

I have 1000's of directories which is named as numbers. Each directory contains multiple files. Each of these directories have a file named "att". I need to rename all the att files by adding the directory name followed by "_" then att for each of the directories. Directories 120 att... (2 Replies)
Discussion started by: Lucky Ali
2 Replies

5. Shell Programming and Scripting

tar command to explore multiple layers of tar and tar.gz files

Hi all, I have a tar file and inside that tar file is a folder with additional tar.gz files. What I want to do is look inside the first tar file and then find the second tar file I'm looking for, look inside that tar.gz file to find a certain directory. I'm encountering issues by trying to... (1 Reply)
Discussion started by: bashnewbee
1 Replies

6. UNIX for Dummies Questions & Answers

Do I need to extract the entire tar file to confirm the tar folder is fine?

I would like to confirm my file.tar is been tar-ed correctly before I remove them. But I have very limited disc space to untar it. Can I just do the listing instead of actual extract it? Can I say confirm folder integrity if the listing is sucessful without problem? tar tvf file1.tar ... (1 Reply)
Discussion started by: vivien_chu
1 Replies

7. Shell Programming and Scripting

Script to move one folder to multiple folder...

Hi All, I have to requirement to write a shell script to move file from one folder (A) to another five folder (B,C,D,E,F) and destination folder should be blank. In not blank just skip. This script will run as a scheduler every 2 minutes. It will check number of files in folder A and move 1 to... (9 Replies)
Discussion started by: peekuabc
9 Replies

8. Shell Programming and Scripting

Bash script for printing folder names and their sizes

Good day, everyone! I'm very new to bash scripting. Our teacher gave us a task to create a script that basically does the same job the 'du' command does, with the difference that 'du' command gives an output in the form of <size> <folder name>and what we need is <folder name> <size>As for... (1 Reply)
Discussion started by: UncleIS
1 Replies

9. Homework & Coursework Questions

Bash script for printing folder names and their sizes

1. The problem statement, all variables and given/known data: The task is to create a script that would reproduce the output of 'du' command, but in a different way: what 'du' does is: <size> <folder name>and what is needed is <folder name> <size>We need to show only 10 folders which are the... (3 Replies)
Discussion started by: UncleIS
3 Replies

10. Shell Programming and Scripting

Checking Multiple File existance in a UNIX folder(Note: File names are all different)

HI Guys, I have some 8 files with different name and extensions. I need to check if they are present in a specific folder or not and also want that script to show me which all are not present. I can write if condition for each file but from a developer perspective , i feel that is not a good... (3 Replies)
Discussion started by: shankarpanda003
3 Replies
All times are GMT -4. The time now is 01:51 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy