Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Scripting question
Top Forums Shell Programming and Scripting Scripting question Post 302954072 by Don Cragun on Friday 4th of September 2015 03:55:57 AM
Old 09-04-2015
You don't give enough details about what your script is supposed to do for anyone but you to say whether or not it is correct.

You should learn to indent your code so that the structure of your script is easy to see. Putting all of your code at the left margin makes it hard to see where loops start and end, where if statements start and end, etc.

Using:
Code:
for i in `cat file`
do	if ...
	then	echo ...
	elif ...
	then	echo ...
	fi
done

is almost always better written using:
Code:
while read -r i
do	...
done < file

If input.txt contains a list of filenames and you are trying to determine whether or not text in each of those files contain the string PROM and, if not, if each of those files contain the string ADUS, your script might be correct.

If you are trying to determine whether or not each line in input.txt ends with the string PROM or the string ADUS, that is NOT what your script does.
 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

another scripting question

I am writing a script that will identify the oldest file in a directory. Here's the syntax: #!/bin/ksh cd directory chmod 777 * ls -r -1t > file1 sed -n -e "1P" < file1 > file2 So my problem is, now I have file2, which contains the name of the oldest file in the directory. How do I use,... (1 Reply)
Discussion started by: kristy
1 Replies

2. Shell Programming and Scripting

Scripting Question

This script searches for core files and if it finds one, it emails me to let me know.I DONT want it to email me if it doesn't find one but I can't figure out what I need to change or add. Any thoughts? Script below: /bin/find / -name core -type f -ls -exec file {} \;|/usr/bin/mailx -s... (1 Reply)
Discussion started by: damielle
1 Replies

3. Shell Programming and Scripting

another scripting question

Hello I am working on cleaning up permissions on Oracle mountpoints and datafiles in unix. I am looking for a script or a scripting idea to 1st. 1. grep for owner oracle 2. ensure its a directory owned for oracle 3. chmod 750 on the oracle owned directory. 4. grep for oracle files, etc... (3 Replies)
Discussion started by: jigarlakhani
3 Replies

4. Shell Programming and Scripting

scripting question

I'm new to shell scripting and am having a problem trying to do something in C shell. I want to write a script that will input something instead of a user doing it. For example, using the command 'write' the user is supposed to type something to be sent to another user. I want a script to be able... (3 Replies)
Discussion started by: batmike
3 Replies

5. Shell Programming and Scripting

scripting question?

I am writing a backup script for AIX 5 and running into a problem where the output isn't being shown in the output log that is being created. Any ideas on how this would be corrected? I have included the script below. The only thing showing up in the file is listed below. I was hoping to capture... (2 Replies)
Discussion started by: justinburbridge
2 Replies

6. Solaris

Scripting question

I'm writing a small script that will run an executable program (sort of like TOP). To exit the executable, you have to enter control C (^c). I'm trying to use a redirect input file to send the ^c but I'm not having any luck. My short script looks like this - /mydirectory/abc.script < abc.in >... (1 Reply)
Discussion started by: gonzotonka
1 Replies

7. Shell Programming and Scripting

Scripting question

Folks; I'm writing a shell script to extract some fields out of a log file & it will run periodically, how can i make it runs starting from where it left of. for example; if the script will do the extract every 2 days, let's say the first run will extract fields until July 25, 2007 @ 11:15:22... (1 Reply)
Discussion started by: moe2266
1 Replies

8. UNIX for Dummies Questions & Answers

Scripting question

folks; I have a script to remove any files that older than 14 days then move any files that younger than 7 days to another directory. but for some reason it doesn't move the files, when i do it manually it works but not through the script. i tried 2 different ways in writing the move part but it... (6 Replies)
Discussion started by: Katkota
6 Replies

9. Shell Programming and Scripting

Scripting question

Preview of command prompt f ---> to start ferret q----> to stop ferret asp@nex:~$ f NOAA/PMEL TMAP FERRET v6.82 Linux 2.6.18-308.8.2.el5PAE 32-bit - 08/03/12 3-Dec-12 16:44 yes? go my.jnl yes?column=4/skip=1/type=num,text ............filename.txt ---... (4 Replies)
Discussion started by: nex_asp
4 Replies

10. Shell Programming and Scripting

Scripting question

Hi I am trying to write a small script which takes one by one file name from a txt file and do a 'll' and need to check if equal to the given month, otherwise it should return back the file name. Note: the file name contains parameter. My code is given below: It is not working .. giving error... (6 Replies)
Discussion started by: Ravindra Swan
6 Replies

LEARN ABOUT DEBIAN

trcs

trcs(1) 							   User Manuals 							   trcs(1)

NAME

       trcs - convert text files from one codeset to other

SYNOPSIS

       trcs -C | -l | -h

       trcs [-s] [-f input-codeset ] [-t output-codeset ] [ file ]...

DESCRIPTION

       trcs  is a program for translation of text files from one codeset to other.  When exact translation is impossible it tries to make approxi-
       mations.  For example pseudographic characters are approximated by ASCII characters in codesets that have no pseudographic  characters  and
       characters with diacritical marks are approximated by existing characters.

       If the option -s or --gen-script is given trcs will generate simple script that invokes tr(1) This is useful if you want to include this in
       your script or for faster conversion of many files.

       If none of -C, -s, -l, -h and their equivalents is given each file will be read assuming it is coded with codeset input-codeset On standard
       output  it will be recoded so to use codeset output-codeset If there is no file given trcs will act as filter.  Both input-codeset and out-
       put-codeset are case insensitive and default to `cp1251'.

OPTIONS

       -C, --copyright
	      Display copying conditions and warranty information.

       -s, --gen-script
	      Generates conversion script for given input and output encodings instead to convert text files.

       -l, --list
	      List all known codesets with their aliases.

       -h, --help
	      Display this help and exit.

       -f input-codeset, --from[=]input-codeset
	      Codeset of the source.

       -f output-codeset, --to[=]output-codeset
	      Codeset of the output.

EXAMPLES

       trcs -fcyrillic -t koi8-r letter.txt
	      Convert letter.txt from ISO-8859-5 (cyrillic) to KOI8-R and output the result on standard output.

       trcs --from cp437 --to=mik --gen-script >ibm2mik
	      Generates script ibm2mik for converting from CP437 to MIK.

       sh ibm2mik screen.txt
	      Convert screen.txt from CP437 to MIK.  Output the result on standard output.  Without parameters ibm2mik acts as filter.

AUTHOR

       Anton Zinoviev <anton@lml.bas.bg>, <zinoviev@fmi.uni-sofia.bg>

SEE ALSO

       tr(1)

Linux								     JUN 2000								   trcs(1)
All times are GMT -4. The time now is 11:34 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy