Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Scripting question
Top Forums Shell Programming and Scripting Scripting question Post 302954072 by Don Cragun on Friday 4th of September 2015 03:55:57 AM
Old 09-04-2015
You don't give enough details about what your script is supposed to do for anyone but you to say whether or not it is correct.

You should learn to indent your code so that the structure of your script is easy to see. Putting all of your code at the left margin makes it hard to see where loops start and end, where if statements start and end, etc.

Using:
Code:
for i in `cat file`
do	if ...
	then	echo ...
	elif ...
	then	echo ...
	fi
done

is almost always better written using:
Code:
while read -r i
do	...
done < file

If input.txt contains a list of filenames and you are trying to determine whether or not text in each of those files contain the string PROM and, if not, if each of those files contain the string ADUS, your script might be correct.

If you are trying to determine whether or not each line in input.txt ends with the string PROM or the string ADUS, that is NOT what your script does.
 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

another scripting question

I am writing a script that will identify the oldest file in a directory. Here's the syntax: #!/bin/ksh cd directory chmod 777 * ls -r -1t > file1 sed -n -e "1P" < file1 > file2 So my problem is, now I have file2, which contains the name of the oldest file in the directory. How do I use,... (1 Reply)
Discussion started by: kristy
1 Replies

2. Shell Programming and Scripting

Scripting Question

This script searches for core files and if it finds one, it emails me to let me know.I DONT want it to email me if it doesn't find one but I can't figure out what I need to change or add. Any thoughts? Script below: /bin/find / -name core -type f -ls -exec file {} \;|/usr/bin/mailx -s... (1 Reply)
Discussion started by: damielle
1 Replies

3. Shell Programming and Scripting

another scripting question

Hello I am working on cleaning up permissions on Oracle mountpoints and datafiles in unix. I am looking for a script or a scripting idea to 1st. 1. grep for owner oracle 2. ensure its a directory owned for oracle 3. chmod 750 on the oracle owned directory. 4. grep for oracle files, etc... (3 Replies)
Discussion started by: jigarlakhani
3 Replies

4. Shell Programming and Scripting

scripting question

I'm new to shell scripting and am having a problem trying to do something in C shell. I want to write a script that will input something instead of a user doing it. For example, using the command 'write' the user is supposed to type something to be sent to another user. I want a script to be able... (3 Replies)
Discussion started by: batmike
3 Replies

5. Shell Programming and Scripting

scripting question?

I am writing a backup script for AIX 5 and running into a problem where the output isn't being shown in the output log that is being created. Any ideas on how this would be corrected? I have included the script below. The only thing showing up in the file is listed below. I was hoping to capture... (2 Replies)
Discussion started by: justinburbridge
2 Replies

6. Solaris

Scripting question

I'm writing a small script that will run an executable program (sort of like TOP). To exit the executable, you have to enter control C (^c). I'm trying to use a redirect input file to send the ^c but I'm not having any luck. My short script looks like this - /mydirectory/abc.script < abc.in >... (1 Reply)
Discussion started by: gonzotonka
1 Replies

7. Shell Programming and Scripting

Scripting question

Folks; I'm writing a shell script to extract some fields out of a log file & it will run periodically, how can i make it runs starting from where it left of. for example; if the script will do the extract every 2 days, let's say the first run will extract fields until July 25, 2007 @ 11:15:22... (1 Reply)
Discussion started by: moe2266
1 Replies

8. UNIX for Dummies Questions & Answers

Scripting question

folks; I have a script to remove any files that older than 14 days then move any files that younger than 7 days to another directory. but for some reason it doesn't move the files, when i do it manually it works but not through the script. i tried 2 different ways in writing the move part but it... (6 Replies)
Discussion started by: Katkota
6 Replies

9. Shell Programming and Scripting

Scripting question

Preview of command prompt f ---> to start ferret q----> to stop ferret asp@nex:~$ f NOAA/PMEL TMAP FERRET v6.82 Linux 2.6.18-308.8.2.el5PAE 32-bit - 08/03/12 3-Dec-12 16:44 yes? go my.jnl yes?column=4/skip=1/type=num,text ............filename.txt ---... (4 Replies)
Discussion started by: nex_asp
4 Replies

10. Shell Programming and Scripting

Scripting question

Hi I am trying to write a small script which takes one by one file name from a txt file and do a 'll' and need to check if equal to the given month, otherwise it should return back the file name. Note: the file name contains parameter. My code is given below: It is not working .. giving error... (6 Replies)
Discussion started by: Ravindra Swan
6 Replies

LEARN ABOUT OSF1

learn

learn(1)						      General Commands Manual							  learn(1)

NAME

       learn - Provides computer-aided instruction for the C shell

SYNOPSIS

       learn [-directory] [subject] [lesson]

       The learn command provides computer-aided instruction courses and practice in the use of Tru64 UNIX.

OPTIONS

       Allows you to exercise a script in a nonstandard place.

DESCRIPTION

       To  get	started,  enter learn; if this is the first time that you are invoking the learn command, you are guided through a series of ques-
       tions to determine what type of instruction you want to receive.

       If you have used learn before and left your last session without completing a subject, the program uses information  in	$HOME/.learnrc	to
       start you up in the same place you left off.

       To  bypass questions, enter a subject or lesson.  In order to enter a lesson, you must know the lesson number that you received in a previ-
       ous learn command session. If you do not know the lesson number, enter the lesson number as a subject.  The learn command searches for  the
       first  lesson  containing  the subject you specified. If the lesson is a - (dash), learn prompts for each lesson; this is useful for debug-
       ging.

       You can specify the following subjects:

       files editor vi morefiles macros eqn C

SUBCOMMANDS

       There are a few special commands.  The bye command terminates a learn session, and the where command tells you of your  progress  (where  m
       tells  you more.)  The again command redisplays the text of the lesson and again lesson lets you review lesson. The hint command prints the
       last part of the lesson script used to evaluate a response, while hint m prints the entire lesson script.  This	is  useful  for  debugging
       lessons and might possibly give you an idea about what is expected.

EXAMPLES

       To take the online lesson about files, enter: learn files

       You are then prompted for further input.

FILES

       Playpen directories.  Start-up information.

SEE ALSO

       Commands:  csh(1), ex(1)

																	  learn(1)
All times are GMT -4. The time now is 02:56 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy