Improvement in shell script Post: 302905672

Sponsored Content

Top Forums UNIX for Dummies Questions & Answers Improvement in shell script Post 302905672 by wasim999 on Friday 13th of June 2014 02:15:34 AM

06-13-2014

Registered User

Improvement in shell script

Hi This is my Following code:

Code:

#!/bin/sh
echo "TOTAL_NO_OF_MAILS"
read TOTAL_NO_OF_MAILS
echo "TOTAL_NO_OF_TICKETS "
read TOTAL_NO_OF_TICKETS
echo "TICKETS_IN_QUEUE"
read TICKETS_IN_QUEUE
rm -rf `pwd`/Focus
echo "Hi Team\nSTATS IN CLRS MAIL BOX\n\n==============================" >> Focus
echo "#TOTAL_NO_OF_MAILS           :$TOTAL_NO_OF_MAILS\n#TOTAL_NO_OF_TICKETS CREATED :$TOTAL_NO_OF_TICKETS\n#TICKETS_IN_ASIA_QUEUE       :$TICKETS_IN_QUEUE" >> Focus
echo "==============================\n\nRegards\nClearSuite Support" >> Focus
mailx -r abc@abc.com -s "subjects" acb@abc.com  < Focus

*I am Getting input and mailing it.
*Its Working Fine!! Jus wanted to know is thr possibility of improvement in this code.
*The number of lnes must be minimum and code must be effective.

Awaiting for new ideas and suggestion to improve the code since i am very new to unix.

Last edited by wasim999; 06-13-2014 at 04:13 AM.. Reason: Add CODE tags.

wasim999

View Public Profile for wasim999

Find all posts by wasim999

7 More Discussions You Might Find Interesting

1. Programming

File - reading - Performance improvement

Hi All I am reading a huge file of size 2GB atleast. I am reading each line and cutting certain columns and writing it to another file. Here is the logic. int main() { string u_line; string Char_List; string u_file; int line_pos; string temp_form_u_file; ...

2. Shell Programming and Scripting

Script ready but might need some improvement.

Hi All, I have written a script which does some editing in the files, based on user input.This might not be the most elegant way of doing it and there would be many improvements needed. Please go through it and let me know how it could be improved. Suggestions are welcome!! Thanks!...

3. Shell Programming and Scripting

Any improvement possible in this script

Hi! Thank you for the help yesterday This is the finished product There is one more thing I would like to do to it but I’m not to certain On how to proceed I would like to log all output to a log in order to Be able to roll back This script is meant to be used in repairing a...

4. Shell Programming and Scripting

Looking for improvement to script that compresses a directory that is 2 months old

I write reports daily to a directory that is named with the month and year. I wanted to compress all but the last two months worth of these directories to save space. I am going to cron a job to run on the first of each month to do this clean up. I didn't have zip/unzip on my AIX environment so...

5. UNIX for Advanced & Expert Users

linux os improvement

can anyone help to share the knowledge on linux os improvement? 1) os account - use window AD authentication, such as ldap, but how to set /etc/passwd, where to put user home? 2) user account activity - how to log os user activity share the idea and what tools can do that...thx

6. Shell Programming and Scripting

I need the improvement for my script

Hi All, Here is my script #! /bin/sh var1=some email id var2=some email id grep -i "FAILED FILE FORMAT VALIDATION" /opt >tmp2 diff tmp1 tmp2 | grep ">" >tmp3 if then cat tmp3 | mailx -s " Error Monitoring" $var2 else echo "Pattern NOt Found" | mailx -s " Error Monitoring" $var1...

7. Shell Programming and Scripting

Performance improvement in grep

Below script is used to search numeric data from around 400 files in a folder. I have 300 such folders. Need help in performance improvement in the script. Below Script searches 20 such folders ( 300 files in each folder) simultaneously. This increases cpu utilization upto 90% What changes...

LEARN ABOUT PHP

is_string

IS_STRING(3)								 1							      IS_STRING(3)

is_string - Find whether the type of a variable is string

SYNOPSIS

       bool is_string (mixed  $var)

DESCRIPTION

	Finds whether the type given variable is string.

PARAMETERS

	      o $var
		- The variable being evaluated.

RETURN VALUES

	Returns TRUE if $var is of type string, FALSE otherwise.

EXAMPLES

       Example #1

	      is_string(3) example

	      <?php
	      $values = array(false, true, null, 'abc', '23', 23, '23.5', 23.5, '', ' ', '0', 0);
	      foreach ($values as $value) {
		  echo "is_string(";
		  var_export($value);
		  echo ") = ";
		  echo var_dump(is_string($value));
	      }
	      ?>

	      The above example will output:

	      is_string(false) = bool(false)
	      is_string(true) = bool(false)
	      is_string(NULL) = bool(false)
	      is_string('abc') = bool(true)
	      is_string('23') = bool(true)
	      is_string(23) = bool(false)
	      is_string('23.5') = bool(true)
	      is_string(23.5) = bool(false)
	      is_string('') = bool(true)
	      is_string(' ') = bool(true)
	      is_string('0') = bool(true)
	      is_string(0) = bool(false)

SEE ALSO

       is_float(3), is_int(3), is_bool(3), is_object(3), is_array(3).

PHP Documentation Group 													      IS_STRING(3)