Errors in if conditions with to many OR conditions Post: 302736957

Sponsored Content

Top Forums Shell Programming and Scripting Errors in if conditions with to many OR conditions Post 302736957 by Don Cragun on Wednesday 28th of November 2012 07:49:39 AM

11-28-2012

Registered User

Quote:

Originally Posted by bipinajith

Don Cragun, I see quoting the variables is not helping:-

Code:

# cat test.sh
#!/bin/bash

var1=100
var3=1500

if [ "$var1" -gt 1500 -o "$var2" -gt 1000 -o "$var3" -gt 1000 ]
then
    echo "Success"
else
    echo "Failed"
fi

Code:

# ./test.sh
./test.sh: line 6: [: : integer expression expected
Failed

Code:

# uname
Linux GNU/Linux
# echo $SHELL
/bin/bash

Sorry, I should have said it wasn't a portable fix.

It works with ksh on OS X, but comparing an empty string using a numeric test operator is not required to work. However, I believe that even though it didn't give you what you wanted with bash on Linux, the diagnostic message would be easier to interpret. (At least I think it would be easier to try to find out what to look for when test says it expected an integer expression than it was to figure out what was wrong when it said too many arguments and meant that an unset variable caused a test operator to be misinterpreted as an operand.)

Of course the underlying problem of using variables that don't contain data of the type expected when they are expanded can only be fixed by verifying the format of data before it is used. And, we weren't shown the first 49 lines of the script that failed to set or verify that the variables used in this test contained numeric string values.

This User Gave Thanks to Don Cragun For This Post:

Don Cragun

View Public Profile for Don Cragun

Find all posts by Don Cragun

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

multiple conditions in if/then

Hello, I am having trouble with the syntax with a conditional statement in a BASH script involving multiple conditions. Any suggestions would be greatly appreciated! if ; then array=("${array}" "$dnNum" ) fi i receive this error: ./testscript: '

2. UNIX for Dummies Questions & Answers

2 or more if conditions

Hello, I have a file as follows: col no:1 2 3 4 5 6 7 8 9 10 11 a 4 226 226 ch:95024048-95027592, 1y224 of 3545 223 224 ident b 53 235 235 ch:148398-148401255, 1y184 of 3187 180 186 ident awk...

3. Shell Programming and Scripting

conditions

./script 89 The script will extract the last digit of the input parameter. example, that is 4. This will be compared to the last digit of the current day of the month ( like day 14; that is 4). A message will displayed on the screen indicating if the digits are the same or not.

4. Shell Programming and Scripting

While with three conditions

Currently this is what I am trying while || && ]; do I want to continue if the first condition or both the second and third are true but I am getting a too many arguments error. Can someone help me out?

5. Shell Programming and Scripting

IF OR with two conditions

I have this IF working fine, testing if a char is a digit: if ; then _VALUE=$_VALUE$_CHAR else _ISDIGIT="false" fi Then I add a second condition to test if the char is either a digit or a * if ]; then _VALUE=$_VALUE$_CHAR ...

6. Shell Programming and Scripting

If conditions need

Dear Expert, Below code is for to take the backup of database by daily time stamp. I need vital help to make my script automatic sending me email if it sucess or fail. echo on @REM Seamonkey's quick date batch (MMDDYYYY format) @REM Setups %date variable @REM First parses month, day, and...

7. Shell Programming and Scripting

awk three conditions

I'm having a problem pulling UID's from data. The data outputs a user's UID in one of three ways: 1. Error User user_name already assigned with <UID> 2. Success <UID> reserved for user_name 3. <a load of crap because there was a db failure yet somehow the UID is still in there> I typically...

8. Shell Programming and Scripting