Sponsored Content
Top Forums Shell Programming and Scripting Problem saving return value of subroutine in perl Post 302710807 by rushadrena on Friday 5th of October 2012 04:30:56 PM
Old 10-05-2012
Tyler,
After the modifications suggested by you the output is
Code:
component 2 = e d
induced= bca
component 1 = c b a
induced= bca

But the problem is that for component-2 there shouldnt be anything induced(because "e d" is not a subset of DATA).

The program needs finds all the rows of DATA which are a subset of the points in any given component.
PHP Code:
----------DATA----------- 
b c a
a c d 
d e b 
So suppose there is a component 3,which has these points= "a c d e". Then row 2nd and 3rd are a subset of these points.So for component3 I'm expecting this output
component 3 = a c d e
induced= a c d
d e b
I want to save these induced values in a suitable data structure as I need to further process them.

---------- Post updated at 07:32 AM ---------- Previous update was at 01:12 AM ----------

The code fails on this data



Code:
---------DATA-------------- 
b c a 
a c d 
d e b 
e f g 
g d f 
h i g


And the output is
Code:
component 2 = e d g f 
component 1 = c a b 
b c a


Which is wrong, because it should have been this
Code:
component 2 = e d g f 
e f g 
g d f 
component 1 = c a b 
b c a

Because with the vertices in component 2, we can have 4th & 5th row of DATA.
Please help on this


---------- Post updated at 03:30 PM ---------- Previous update was at 07:32 AM ----------

Tyler please help me fix my problem. Im still havent been able to solve it.
Quote:
Originally Posted by durden_tyler
I don't quite understand the last paragraph of your 2nd post, but I'll explain the working of the final loop of your code.

Code:
...
sub induced {
my (@z)=@_;
for my $QT (\@z ){
    #print Dumper $QT;
    for my $triplet ( @trip ){
        my %Pie;
        undef @Pie{@$QT};
        delete @Pie{ @$triplet };
        print "@$triplet\n" if keys(%Pie) <= ( @$QT - @$triplet ) ;
        return (@$triplet);
    }
}}
my @C;
my $d;
my $p=$#subgraphs+1;
for ($d=$p; $d >=1; $d--)
  { 
    print "component $d = @{ $subgraphs[$d-1] }\n";
    my ($qw)=join(induced(@{ $subgraphs[$d-1] }));
    print "induced=$qw";

}

Notice the following about the subroutine "induced":
(1) it has a "print" statement in it based on an "if" condition being true.
(2) it returns an array. $triplet is an array ref, and @$triplet is the array it references.

Also notice the following about the final "for" loop:

(3) The "join" function has not been provided a "join-string" i.e. the first argument. So what happens if you use join without the join-string?

Code:
$
$ perl -le '@x = qw(a b c); $y = join(@x); print $y'

$

It doesn't print the array elements. Once you do supply the join-string, then:

Code:
$
$ perl -le '@x = qw(a b c); $y = join("~", @x); print $y'
a~b~c
$
$

it works fine.

(4) the final print function that prints the value of $qw does not have a newline.

Now, before the "for" loop, the value of $p is 2. In the first iteration:

(a) $d is 2 and the first print function prints the expected values.
(b) "join" returns nothing and hence $qw is a zero-length string.
(c) the second print function prints "induced=" and does **NOT** go to the next line due to the absence of a newline.

So after iteration 1, you have this printed:

Code:
component 2 = e d
induced=

In iteration # 2, the following happens:

(a) $d is 1 and the first print function prints the expected values (c, a, b)
(b) the "induced" subroutine, when invoked, prints the value "@$triplet\n" because apparently the "if" condition evaluates to true. Hence you see "b c a" printed. The "join" function, as usual, returns nothing and hence $qw is a zero-length string.
(c) the final print statement prints the constant string "induced=" followed by nothing.

So the output of **only** iteration 2 is as follows:

Code:
component 1 = c a b
b c a
induced=

And the overall output of both iterations is as follows:

Code:
component 2 = e d
induced=component 1 = c a b
b c a
induced=

Based on this understanding of the code, you may decide what to do next. You probably want to -
(a) fix the "join" function
(b) ensure that the final print function has a newline, and maybe
(c) suppress the "print" function inside the subroutine "induced"

Thus, if the final portion of your program looks like this:

Code:
...sub induced {
my (@z)=@_;
for my $QT (\@z ){
    #print Dumper $QT;
    for my $triplet ( @trip ){
        my %Pie;
        undef @Pie{@$QT};
        delete @Pie{ @$triplet };
        #print "@$triplet\n" if keys(%Pie) <= ( @$QT - @$triplet ) ;
        return (@$triplet);
    }
}}
my @C;
my $d;
my $p=$#subgraphs+1;
for ($d=$p; $d >=1; $d--)
{
  print "component $d = @{ $subgraphs[$d-1] }\n";
  my $qw = join " ", induced(@{ $subgraphs[$d-1] });
  print "induced = $qw\n";
}

then the final part of the output would be like this -

Code:
...
component 2 = e d
induced = b c a
component 1 = c b a
induced = b c a

I am not sure if you are expecting the return value of "induced" subroutine to be the same each time, or if you simply want to display the distinct return values. If that's the case, then set the variable $qw as a hash key, and print all keys of the hash after the final loop.

tyler_durden
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Problem in subroutine calling

Hi, we can call the subroutines using two ways .... 1) calling subroutine name preceeded by & symbol. 2)Another one is without &symbol.... what is the diff b/w these two.... ############################ #usr/bin/perl fun; sub fun { print "hi this is from perl\n"; }... (1 Reply)
Discussion started by: sarwan
1 Replies

2. Shell Programming and Scripting

Help with a perl subroutine regex

Hi, I can't get this script ot work and I wa wondering if anyone could help? I need to open a file and use a subroutine to search each line for a regular expression. If it matches then I need to return a match from the subroutine and print the result? Any help would be greatly... (11 Replies)
Discussion started by: jmd2004
11 Replies

3. Shell Programming and Scripting

calling perl subroutine from perl expect module

All, Is it possible to call a subroutine from the perl expect module after logging to a system that is within the same program. My situation is I need to run a logic inside a machine that I'm logging in using the expect module, the logic is also available in the same expect program. Thanks,... (5 Replies)
Discussion started by: arun_maffy
5 Replies

4. Shell Programming and Scripting

Why Perl Subroutine Passed In Variable is 1?

The following subroutine prints 1 instead of the content of the Equipment variable. Can someone tell me why? #!c:/perl/bin/perl.exe # use strict 'vars'; my $Equipments = "data/equips.txt"; unless (open(EQUIP_FH, "$Equipments")) { print "errors: $Equipments\n"; # This line prints... (1 Reply)
Discussion started by: tqlam
1 Replies

5. Shell Programming and Scripting

Calling perl subroutine from shell script (sh)

Hi, ive a perl script, where it has a subroutine clear() in it, and i've one shell script which runs in background, from that shell script i wanted to call subroutine which is in perl script, that's perl script is not module, just simple script. Eg: perl script <test> #!... (4 Replies)
Discussion started by: asarunkumar
4 Replies

6. Programming

perl: Subroutine question

Hi everyone, I have given up finally trying to find a way to do this. I have a subroutine called LoginFirst where I am starting a new SSH session. I have bunch of subroutines, each one of them uses a (or I have to create a new SSH constructor everytime) ssh connection to get some value so ... (2 Replies)
Discussion started by: dummy_code
2 Replies

7. Shell Programming and Scripting

Perl - pass file to subroutine

Hello All, I have 2 perl sub-routines. my $myDir = myDir_path; my $file; sub convert(){ system ("./$myConvertScript >> $myDir/$file_CONV" ); $file2 = $myDir/$file_CONV; } sub addDB(){ open(CONF, $config) or die "Cannot Open $config for reading. "; while(<CONF>){... (1 Reply)
Discussion started by: ad23
1 Replies

8. Shell Programming and Scripting

perl - return an object from subroutine - Net::LDAP

Hi all, I'm not even sure a person can do this in perl, seems like you should be able to though. Here's the error IO::Socket::INET: connect: Operation now in progress at server_search.pl line 256, <DATA> line 466. Here's the perl code... sub ldap_new{ $nl = Net::LDAP->new( "$_" ) or... (3 Replies)
Discussion started by: jtollefson
3 Replies

9. Shell Programming and Scripting

perl -Calling the Subroutine Only if the condition is met

Hello All, I am in the process of learning perl.I have a perl script and based on the arguments passed it would the appropriate subroutine that is defined in the script. Now, I need to check a value that is defined in the Environment variables and should call the subroutine only if the... (1 Reply)
Discussion started by: filter
1 Replies

10. Programming

Perl subroutine returning different values in HPUX

HI , I am running a program on hpux in perl. I am encountering a strange issue where when i print a variable in the sub which is returning it , it prints a different value but when i call it and store value in a variable it gives a different o/p. the sub is sub CheckConfigFilePattern ... (4 Replies)
Discussion started by: Jcpratap
4 Replies
All times are GMT -4. The time now is 07:35 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy