Sponsored Content
Top Forums Shell Programming and Scripting Bash string variable outputting incorrectly Post 302655289 by bakunin on Wednesday 13th of June 2012 03:52:28 AM
Old 06-13-2012
There are a few problematic lines in your script:


Code:
if  [ "$TotalAdrFOUND"="$TotalDNSFound" ] ;

i doubt that this works. correct should be (notice the spaces):
Code:
if  [ "$TotalAdrFOUND" = "$TotalDNSFound" ] ;

If i read the script source correctly the variables in question are both integers. You could also use integer comparation then (see man test for a complete description of available options)

Code:
if  [ $TotalAdrFOUND -eq $TotalDNSFound ] ;




Code:
Line=$((Line+1))

I am not sure if this works or not, but in any case this will definitely be correct (again, notice the spaces, they are necessary):

Code:
(( Line += 1 ))

A further tip: do NOT USE BACKTICKS! Backticks are an ancient device, which has some (quite intricate) shortcomings and are supported only for backwards compatibility. You use something like:

Code:
variable=`command`

and want the output of "command" to become the variables content. Use

Code:
variable="$(command)"

for this purpose, which has none of the shortcomings and all of the features of the above syntax.


One last tip: before using *any* variable, declare it at the beginning of your script. This offers the opportunity to document the variables contents, which helps greatly in maintaining your scripts, as well as to make sure all necessary variables are initialized with sensible values:

Code:
#!/bin/bash

# this is a sample script sketch

typeset    variable=""                # this is used for ....
typeset -i var_int=0                  # counter for loop cycling through something
typeset -i var_bool=0                 # processing flag, 0=process, 1=do not p.

<rest of your code>

I hope this helps.

bakunin

Last edited by bakunin; 06-13-2012 at 05:02 AM..
 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

PATH variable set incorrectly?

I've noted that in order to use commands like ifconfig, I have to prefix the commands with the directory. /etc/profile shows that the paths should be part of the PATH environment variable; any idea where the bug is? :confused: # /etc/profile # System wide environment and startup... (1 Reply)
Discussion started by: jon80
1 Replies

2. Shell Programming and Scripting

Bash string variable manipulation

In a bash script I've set a variable that is the directory name of where an executable lives. the_dir=`dirname $which myscript` which equates to something like "/path/to/dir/bin" I need to cut that down to remove the "bin" so I now have "/path/to/dir/". This sounds easy but as a... (2 Replies)
Discussion started by: Witty
2 Replies

3. UNIX for Dummies Questions & Answers

outputting selected characters from within a variable

Hi all, if for example I had a variable containing the string 'hello', is the any way I can output, for example, the e and the 2nd l based on their position in the string not their character (in this case 2 and 4)? any general pointers in the right direction will be much appreciated, at... (3 Replies)
Discussion started by: skinnygav
3 Replies

4. Shell Programming and Scripting

Bash:How to split one string variable in two variables?

Hello, I have a paramter $param consisting just of two literals and want to split it into two parameters, so I can combine it to a new parameter <char1><string><char2>, but the following code didn't work: tmp_PARAM_1=cut -c1 $PARAM tmp_PARAM_2=cut -c2 $PARAM... (2 Replies)
Discussion started by: ABE2202
2 Replies

5. Shell Programming and Scripting

Bash assign string to variable

Hi ,I am trying to assign string to variable ,but it doesn't work Also could you show me different ways to use grep,(I am trying to get the first,second and first column form file,and I am counting the chars) let name=`grep "$id" product | cut -c6-20` (25 Replies)
Discussion started by: lio123
25 Replies

6. Shell Programming and Scripting

BASH script outputting strange file formats

Hi I am very new to using BASH, but I have a problem with a piece of script that I have been working on. Basically the script goes through a mailbox file looking at particular aspects of the file, for example how many spamwords there are email address etc. It does this pretty well except for an... (13 Replies)
Discussion started by: 9aza
13 Replies

7. UNIX for Dummies Questions & Answers

bash variable string declaration

Hello, Why is this not working in a script? files="test.fsa" echo $files for file in $files do if then echo "$file does not exist." fi run a command done I get an error saying (3 Replies)
Discussion started by: verse123
3 Replies

8. Shell Programming and Scripting

bash: using a string variable in grep

Hi, I've been stuck for several days on this. Using grep on a command line, I can use quotes, eg... grep 'pattern of several words' filename I want to do this in my bash script. In my script I have captured the several command line arguments (eg arg1 arg2) into a variable: variable=$@ I... (2 Replies)
Discussion started by: adrian777uk
2 Replies

9. Shell Programming and Scripting

Passing string as variable(s) in bash

I'm trying to write a basic bash script that takes input you give (what directory, if any, what name, if any ....) and passes the information to find. I'm trying to just create a string with all variables and then pass it to find. So far I have this extremely simple: #!/bin/bash -f ... (2 Replies)
Discussion started by: Starting_Leaf
2 Replies

10. Shell Programming and Scripting

Convert a string to variable in Bash shell

Hi All; I have 2 variable let's say $A and $B. These are actually some remotely executed command outputs. I captured these values in my local variables. Here is my problem. When I try to do some arithmetic operation with these variables, I receive an error message. Neither expr nor typeset -i... (3 Replies)
Discussion started by: Meacham12
3 Replies
All times are GMT -4. The time now is 07:22 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy