Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Whats the error in this script ?
Top Forums Shell Programming and Scripting Whats the error in this script ? Post 302444794 by agama on Thursday 12th of August 2010 09:41:03 PM
Old 08-12-2010
You're getting the error because you forgot to add the return after your first echo.

Code:
if [ $1 -gt 1 ] ; then
   res=`expr $1 - 1`
   p=`fact $res`
else
   echo $1
   return        # missing return needed to avoid second echo
fi
echo `expr $p \* $1`

If you don't add the return, the second echo will execute and p will not be set. An empty variable will result in the error from expr. Another solution would be to move your 'echo `expr $p \* $1`' statement into the true branch of the if (right after the p= statement). If you do that you don't need the return.
 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

whats the purpose of the following script?

whats the purpose of the following script? who could run it? To what is the script refering that exceeds 75%? The mailbox? What does sed 's/%//' do? (1 Reply)
Discussion started by: vrn
1 Replies

2. Shell Programming and Scripting

Whats wrong with this script?

Hi all, #!/bin/ksh BIN=/interface/Gunner age=$1 directory="$2" && directory=. cd "$directory" || exit 1 from=`$BIN/today -$age` cd $BIN for i in `cat filestoarchive.txt`;do cd $i find . -mtime 14 | grep -v '.tar$' | $BIN/dttmfilter | awk '$1<="'$from'"{ print;};' | \ done (2 Replies)
Discussion started by: kayarsenal
2 Replies

3. UNIX for Advanced & Expert Users

Whats wrong in this Script ???

PATH="/clocal/mqbrkrs/user/mqsiadm/sanjay" MAIL_RECIPIENTS="xyz@abc.com" Subject="File accessed in last minutes:" find $PATH -type f -amin -1 > temp.txt.$$ cat temp.txt.$$ | \ while read line do fuser -uV $line >> tempmail.txt done cat "$tempmail.txt" | mailx -s "$Subject"... (4 Replies)
Discussion started by: varungupta
4 Replies

4. UNIX for Dummies Questions & Answers

Whats wrong in the script?

if then if then echo "fst argument is $1 " else if then "fst argument is $1" fi fi fi Can anyone tell me. My requirement is tht pass a string .. Check whether it contains "-". If yes then check if it... (1 Reply)
Discussion started by: nehagupta2008
1 Replies

5. Shell Programming and Scripting

Whats the error in this script

#!/bin/sh #usblcd clear while true; do tail -1 /root/Myprogs/apurva.log > /root/Download/usr/bin/output.txt cat /root/Download/usr/bin/output.txt | echo `awk '{if ($3 == "Connection"&&$4 == "Established") print"Connection Established "} else if {($3 == "DTNCO"&&$4 ==" Sent" && $5="Packet")... (2 Replies)
Discussion started by: appu1987
2 Replies

6. Shell Programming and Scripting

Whats the problem whit my script???

I want to take the even-numbered lines from a file and put them in a separate file and the same thing with the odd-numbered lines. #!/bin/bash file=$1 awk ' { if ( NR % 2 == 0) { (( getline < "$file" ) > "even.txt" )} else { (( getline < "$file" ) > "odd.txt" )} } ' $file (4 Replies)
Discussion started by: cristi2008
4 Replies

7. Shell Programming and Scripting

whats error in code ??

if `egrep -c "safe_mode" /usr/local/lib/php.ini` - gt 0 && " `egrep -c "safe_mode" /usr/local/lib/php.ini` = "On" " then echo " Good " exit else echo " Not Good "; fi and (4 Replies)
Discussion started by: x-zer0
4 Replies

8. Shell Programming and Scripting

Whats wrong with my script?

I am trying to find a value within a properties file and declare it into a variable. Script below. I want the "memSize" to be the branch from the properties file. Right now it always tells me "Not found" What am I doing wrong? #!/bin/sh memsize =''; memSize=`sed '/^\#/d'... (8 Replies)
Discussion started by: vsekvsek
8 Replies

9. OS X (Apple)

Whats wrong with this shell script!!!!!

hi guys can you tell me if anything is wrong with this script, seems reasonable to me but somehow never works. Script redacted for being too explicit (2 Replies)
Discussion started by: Freddo
2 Replies

10. Shell Programming and Scripting

Sh Script whats wrong?

Hi there, i have a problem i have created followning sh files some years ago but now it dosen`t work anymore i never used it a long time. Can anyone find the Error? Its always runs the stop() block and trying to Killing the Server also if i try to start or creat a new one. #!/bin/sh stop()... (6 Replies)
Discussion started by: NewCannon
6 Replies

LEARN ABOUT DEBIAN

script-email

SCRIPT-EMAIL(8) 					  System Administration Commands					   SCRIPT-EMAIL(8)

NAME

       script-email - Amanda script to send email notifications

DESCRIPTION

       script-email is an Amanda script implementing the Script API. It should not be run by users directly. It sends a notification email to the
       addresses specified in the MAILTO property.

PROPERTIES

       This section lists the properties that control script-email's functionality. See amanda-scripts(7) for information on the Script API,
       script configuration.

       MAILTO

	   List of email addresses that will receive an email on command execution. It is a multi-valued property:
	     property "MAILTO" "amanda@domain.com" "sysadmin@domain.com" "amandauser@domain.com"

EXAMPLE

       In this example, script-email is scheduled to be run before the DLE, on the server.  The unqualified email address amanda will be passed to
       the email system unchanged.  The script is then attached to a dumptype, which can then be specified for any DLEs which require
       notification.
	define script-tool pre-email {
	  comment "email me before this DLE is backed up"
	  plugin  "script-email"
	  execute-on pre-dle-backup
	  execute-where server
	  property "mailto" "amanda"
	}

	define dumptype user-tar-email {
	  user-tar
	  script "pre-email"
	}

SEE ALSO

       amanda(8), amanda.conf(5), amanda-client.conf(5), amanda-scripts(7)

       The Amanda Wiki: : http://wiki.zmanda.com/

AUTHORS

       Jean-Louis Martineau <martineau@zmanda.com>
	   Zmanda, Inc. (http://www.zmanda.com)

       Dustin J. Mitchell <dustin@zmanda.com>
	   Zmanda, Inc. (http://www.zmanda.com)

Amanda 3.3.1							    02/21/2012							   SCRIPT-EMAIL(8)
All times are GMT -4. The time now is 10:37 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy