Sponsored Content
Full Discussion: Help with bash script.
Top Forums Shell Programming and Scripting Help with bash script. Post 302395291 by cfajohnson on Monday 15th of February 2010 02:20:54 PM
Old 02-15-2010
Quote:
Code:
#!/bin/bash

PLAYLIST='/home/Fedora11'

function mk_playlist
{


That is not the standard syntax for defining a function.
Code:
mk_playlist()
{

Quote:
Code:
  AUDIOPATH='/home/Fedora11/MP3'


There is no need to quote a variable assignment unless there is literal whitespace or other special characters.

You have created a variable for the directory; why are you not using it?
Code:
AUDIOPATH=$PLAYLIST/MP3

You should never again have the literal '/home/Fedora11' in your script.
Quote:
Code:
  touch /home/Fedora11/playlist
  touch /home/Fedora11/temporaryplaylist


If you really need to create these files ahead of time, there is no need to use an external command (touch):
Code:
> "$PLAYLIST/playlist"
> "$PLAYLIST/temporaryplaylist"

Quote:
Code:
  find $AUDIOPATH -print -type f > /home/Fedora11/temporaryplaylist
  grep -i 'mp3$' /home/Fedora11/temporaryplaylist > /home/Fedora11/playlist


You don't need grep or a temporary file:
Code:
find "$AUDIOPATH" -type f -name '*.[Mm][Pp]3' > /home/Fedora11/playlist

Quote:
Code:
  rm /home/Fedora11/temporaryplaylist

  echo Total files: `wc -l /home/Fedora11/playlist`
}

# Echo some help
if [ "$1" == "-h" -o "$1" == "--help" ]; then
  echo "Usage: doze [OPTION]"
  echo
  echo "<minutes> Doze for <minutes> and start playing"
  echo "-c | --create Create playlist w/o playing it"
  echo "-h | --help Show this help"
  echo
  echo "W/o option playing starts immediately"
  echo
  exit 0
fi

# Just create playlist w/o playing it
if [ "$1" == "-c" -o "$1" == "--create" ]; then
  mk_playlist
  exit 0
fi

# Start playing immediately
if [ "$#" -ne 1 ]; then
  if [ ! -f "$PLAYLIST" ]; then
    mk_playlist
    mplayer -shuffle -playlist $PLAYLIST
  else
    mplayer -shuffle -playlist $PLAYLIST
  fi
else
  # Or after a while
  if [ ! -f "$PLAYLIST" ]; then
    mk_playlist
    TIME_IN_MINS=$(($1 * 60))
    sleep $TIME_IN_MINS
    mplayer -shuffle -playlist $PLAYLIST
  else
    TIME_IN_MINS=$(($1 * 60))
    sleep $TIME_IN_MINS
    mplayer -shuffle -playlist $PLAYLIST
  fi
fi


Now, what's your question?

What is not working in your script?

Last edited by cfajohnson; 02-15-2010 at 03:41 PM..
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Why generate "ash and bash" different output for same bash script?

Hi, For my bash script, terminal with bash is generate an OK output and program works right. already, terminal with ash have "line 48: syntax error: Bad substitution" output and program don't work. :confused: (0 Replies)
Discussion started by: s. murat
0 Replies

2. Shell Programming and Scripting

passing variable from bash to perl from bash script

Hi All, I need to pass a variable to perl script from bash script, where in perl i am using if condition. Here is the cmd what i am using in perl FROM_DATE="06/05/2008" TO_DATE="07/05/2008" "perl -ne ' print if ( $_ >="$FROM_DATE" && $_ <= "$TO_DATE" ) ' filename" filename has... (10 Replies)
Discussion started by: arsidh
10 Replies

3. Shell Programming and Scripting

how to make your bash script run on a machine with csh and bash

hi, i have a script that runs on bash and would like to run it on a machine that has csh and bash. the default setting on that machine is csh. i dont want to change my code to run it with a csh shell. is there any way i can run the script (written in bash) on this machine? in other words is there... (3 Replies)
Discussion started by: npatwardhan
3 Replies

4. Shell Programming and Scripting

Bash Script: modify bash

Hey guys, i'm having trouble complete one of my bash scripts I'm hoping to --- 1. Modify bash so that then the user types "ls" the command that is executed is "ls -al" 2. Modify the point of entry in bash when the user accesses it, moving the initial location to /var I've somewhat done #2,... (9 Replies)
Discussion started by: LibRid
9 Replies

5. Shell Programming and Scripting

Run bash script within a bash script

Hi everybody, Lets say, I have two bash scripts named down.sh and up.sh located in two different folders named ~/home/a/ and ~/home/b/ Now I want to write another bash script, located in ~/home/ which runs these other two scripts, so that I only have to execute this one comprehensive script... (1 Reply)
Discussion started by: NBurkhard
1 Replies

6. UNIX for Dummies Questions & Answers

Im new to bash scriping and i found this expression on a bash script what does this mean.

# check host value regex='^(||1|2|25)(\.(||1|2|25)){3}$' if ')" != "" ]; then if ]; then echo host $host not found exit 4 fi elif ]; then echo $host is an invalid host address exit 5 fi espeacailly the top regex part? ---------- Post updated at 06:58 PM ---------- Previous update was... (1 Reply)
Discussion started by: kevin298
1 Replies

7. Shell Programming and Scripting

Make a password protected bash script resist/refuse “bash -x” when the password is given

I want to give my long scripts to customer. The customer must not be able to read the scripts even if he has the password. The following command locks and unlocks the script but the set +x is simply ignored. The code: read -p 'Script: ' S && C=$S.crypt H='eval "$((dd if=$0 bs=1 skip=//|gpg... (7 Replies)
Discussion started by: frad
7 Replies

8. Shell Programming and Scripting

Different behavior between bash shell and bash script for cmd

So I'm trying to pass certain json elements as env vars and use them later on in a script. Sample json: JSON='{ "Element1": "file-123456", "Element2": "Name, of, company written in, a very weird way", "Element3": "path/to/some/file.txt", }' (part of the) script: for s... (5 Replies)
Discussion started by: da1
5 Replies

9. Shell Programming and Scripting

How to block first bash script until second bash script script launches web server/site?

I'm new to utilities like socat and netcat and I'm not clear if they will do what I need. I have a "compileDeployStartWebServer.sh" script and a "StartBrowser.sh" script that are started by emacs/elisp at the same time in two different processes. I'm using Cygwin bash on Windows 10. My... (3 Replies)
Discussion started by: siegfried
3 Replies

10. UNIX for Beginners Questions & Answers

In Bash shell - the ps -ef shows only the /bin/bash but the script name is not displayed

In Bash shell - the ps -ef shows only the /bin/bash but the script name is not displayed ? Is there any way to get the script names for the process command ? --- Post updated at 08:39 AM --- in KSH (Korn Shell), my command output shows the script names but when run in the Bash Shell... (3 Replies)
Discussion started by: i4ismail
3 Replies
All times are GMT -4. The time now is 12:38 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy