Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Combining Strings - Segmentation Fault
Top Forums Programming Combining Strings - Segmentation Fault Post 302106627 by Octal on Saturday 10th of February 2007 09:48:56 PM
Old 02-10-2007
Combining Strings - Segmentation Fault
I am writing a function to combine strings, but when I execute I get a segmentation fault, which doesn't make sence. Segmentation fault is when you try to acess a point of memory that doesn't exist, like trying to acess array[10] when you declared array[7].

Here is the source code:
Code:
#include <stdio.h>
/* #include <string.h> == cheating! */

#define MAXINPUT 1000

char combine(char string1[MAXINPUT], char string2[MAXINPUT]) {
	int count1, count2 = 0;

	while (string1[count1] != '\0')
		++count1;

	while (string2[count2] != '\0')
		string1[count1++] = string2[count2++];
	string1[count1] = '\0';
}
main() {
	char string1[MAXINPUT];
	char string2[MAXINPUT];
	int i = 0;
	
	printf("Enter two strings each under 1000 characters:\n");
	while(i = 0) {
		printf("1: ");
		scanf("%s", string1);
		if ((sizeof string1) > MAXINPUT) {
			i = 0;
			printf("I said under 1000 characters, please enter it again:\n");
		}
		else
			i = 1;
	}
	i = 0;
	while(i = 0) {
		printf("\n2: ");
		scanf("%s", string2);
		if ((sizeof string2) > MAXINPUT) {
			i = 0;
			printf("I said under 1000 characters, please enter it again:\n");
		}
		else
			i = 1;
	}
	printf("%s and %s combined is %s", string1, string2, combine(string1, string2));
	return 0;
}

I know there are functions in the string.h header, but as you can see, I wanted to do it without them, thus calling those functions "cheating".

Thanks for reading.
 

9 More Discussions You Might Find Interesting

1. Programming

Why not a segmentation fault??

Hi, Why I don't receive a segmentation fault in the following sample. int main(void) { char buff; sprintf(buff,"Hello world"); printf("%s\n",buff); } If I define a buffer of 10 elements and I'm trying to put inside it twelve elements, Should I receive a sigsev... (22 Replies)
Discussion started by: lagigliaivan
22 Replies

2. Programming

segmentation fault

If I do this. Assume struct life { char *nolife; } struct life **life; // malloc initialization & everything if(life->nolife == 0) Would I get error at life->nolife if it is equal to 0. wrong accession? (3 Replies)
Discussion started by: joey
3 Replies

3. Programming

segmentation fault

What is segmentation fault(core dumped) (1 Reply)
Discussion started by: gokult
1 Replies

4. Programming

Segmentation fault.

I'm getting a segmentation fault. I'm new to Linux programming. Thanks so much for all of your input.:eek: #include </usr/include/mysql++/mysql++.h> #include <stdio.h> #include <iostream> #include <sstream> #include <string.h> using namespace std; int outputToImport(const char*... (1 Reply)
Discussion started by: sepoto
1 Replies

5. Programming

segmentation fault.

This code is causing a segmentation fault and I can't figure out why. I'm new to UNIX and I need to learn how to avoid this segmentation fault thing. Thank you so much. Thanks also for the great answers to my last post.:):b: int main() { mysqlpp::Connection conn(false); if... (3 Replies)
Discussion started by: sepoto
3 Replies

6. UNIX for Advanced & Expert Users

segmentation fault with ps

What does this mean and why is this happening? $ ps -ef | grep ocular Segmentation fault (core dumped) $ ps -ef | grep ocular Segmentation fault (core dumped) $ ps aux | grep ocular Segmentation fault (core dumped) $ ps Segmentation fault (core dumped) $ pkill okular $ ps... (1 Reply)
Discussion started by: cokedude
1 Replies

7. Programming

Using gdb, ignore beginning segmentation fault until reproduce environment segmentation fault

I use a binary name (ie polo) it gets some parameter , so for debugging normally i do this : i wrote script for watchdog my app (polo) and check every second if it's not running then start it , the problem is , if my app , remain in state of segmentation fault for a while (ie 15 ... (6 Replies)
Discussion started by: pooyair
6 Replies

8. Homework & Coursework Questions

Segmentation Fault

this is a network programming code to run a rock paper scissors in a client and server. I completed it and it was working without any error. After I added the findWinner function to the server code it starts giving me segmentation fault. -the segmentation fault is fixed Current problem -Also... (3 Replies)
Discussion started by: femchi
3 Replies

9. Programming

C. To segmentation fault or not to segmentation fault, that is the question.

Oddities with gcc, 2.95.3 for the AMIGA and 4.2.1 for MY current OSX 10.14.1... I am creating a basic calculator for the AMIGA ADE *NIX emulator in C as it does not have one. Below are two very condensed snippets of which I have added the results inside the each code section. IMPORTANT!... (11 Replies)
Discussion started by: wisecracker
11 Replies

LEARN ABOUT ULTRIX

tr

tr(1)							      General Commands Manual							     tr(1)

Name
       tr - translate characters

Syntax
       tr [-cds] [string1[string2]]

Description
       The  command copies the standard input to the standard output with substitution or deletion of selected characters.  Input characters found
       in string1 are mapped into the corresponding characters of string2.  When string2 is short it is padded to the length of string1 by  dupli-
       cating  its  last character.  Any combination of the options -cds may be used: -c complements the set of characters in string1 with respect
       to the universe of characters whose ASCII codes are 0 through 0377 octal; -d deletes all input  characters  in  string1;  -s  squeezes  all
       strings of repeated output characters that are in string2 to single characters.

       In  either string the notation a-b means a range of characters from a to b in increasing ASCII order.  The backslash character () followed
       by 1, 2 or 3 octal digits stands for the character whose ASCII code is given by those digits.  A  followed by any other  character  stands
       for that character.

       The  following  example creates a list of all the words in `file1' one per line in `file2', where a word is taken to be a maximal string of
       alphabetics.  The second string is quoted to protect  from the Shell.  012 is the ASCII code for newline.
       tr -cs A-Za-z '12' <file1 >file2

Options
       -c   Translates complements:  string1 to those not in string1.

       -d   Deletes all characters in string1 from output.

       -s   Squeezes succession of a character in string1 to one in output.

Restrictions
       `', `0', and `00' are equivalent for NUL character.

       `12' is treated as octal 12 and not a NUL followed by characters 1 and 2.

See Also
       ed(1), ascii(7), expand(1)

																	     tr(1)
All times are GMT -4. The time now is 10:42 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy