Quote:
Originally Posted by
Don Cragun
I'm happy with the numbers in various colored circles around the avatar.
I'm still concerned about manually clearing confidential post counts by hitting the "Mark Forums Read" button. Hitting that button builds in a race condition that can clear notification of unread confidential posts before I receive notice that new confidential messages have been posted.
It was that way before.
When one of our admins wrote that plugin years go he did not add any hooks to update the notification system (to my knowledge) when a confidential post is viewed; and so it was the same before; however, it was not noticeable because it always appeared in the text area (at least for me) so I always had to clear notifications for confidential posts the same way. Nothing has changed from before except the fact it is more noticeable now because of using badges.
The notification feature increments not only for confidential posts, but according to the code, increments for all notices (posts in mod queue, picture comments to moderate, etc) except PMs. It may be that the notifications will update (decrement) with the vB cron during periodic system updates, but I've not testing this yet.
I will write some debugging log code in the notification system and see if I can understand how to make this even better; because I would like for these notifications to update in near real time without refreshing the page (or marking the forums read); and that goes for the PMs as well.
Thanks for staying on top of this.