UNIX for Dummies Questions & Answers

Hello,
I apologize if this was addressed in a previous post. I have done some searching but may have missed it. I am trying to read a list from a file, for example:

Code:

3bik
3bix
3biu
3bin
1nwn

and using this list, copy files with these names (ex: 3bik.dssp.Z) to a seperate folder, named Subset. [Kindly note that all files have the same .dssp.Z extension, they only differ in the names!]

I have written this code below but keep getting syntax errors...could you kindly tell me what I am doing wrong? I am new to scripting and I apologize in advance for any silly errors!
The code:

Code:

 
#!/bin/bash
cat file.txt | while read Line;
do
cp $Line.dssp.Z /Subset
done

I have saved this as Test.sh
My understanding now is that I simply call:
bash Test.sh
in the commandline (MacOs by the way)

Please correct me if I'm wrong, and let me know if the logic of the code is correct also.
Many thanks,
InfoSeeker

When posting about getting errors, post the errors, even for a simple script, it's much easier for people to help if you do.

It is not a good idea to cat a file into a while loop because you will break the script is any files have spaces in their names although the script looks like it should have worked. Thy adding the {..} to $Line as below in case you are getting some kind of misinterpretation of the variable name, or you might have blank lines in the input file.

Code:

#!/bin/bash
while read Line ; do
     cp ${Line}.dssp.Z /Subset
done < file.txt