UNIX for Dummies Questions & Answers

Hi,

I am very new to scripting and have a question regarding variables and their use in a bandwidth monitoring script.

I have identified a few primary variables being;

Bandwidth CIR Download=32kbits <- these match as per the script below
Bandwidth PIR Download=96kbits
Bandwidth CIR Upload=5kbits
Bandwidth PIR Upload=16kbits
ID
IP or MAC Address
packet source
packet destination.
Parent=1:0 <- match the example below

The script that limits the bandwidth is as follows

#DOWNLOAD
${TC} class add dev eth1 parent 1:1 classid 1:30 htb rate 32kbit ceil 96kbit
${TC} qdisc add dev eth1 parent 1:30 handle 30:0 sfq perturb 10
${TC} filter add dev eth1 parent 1:0 protocol ip handle 5 fw flowid 1:30
${EBTABLES} -A FORWARD -i eth2 -o eth1 -d 00:14:1C:E6:08:66 -j mark --set-mark 5 --mark-target ACCEPT
${TC} filter add dev eth1 parent 1:0 protocol ip u32 match ip dst 192.168.1.1 flowid 1:30

# UPLOAD
${TC} class add dev eth2 parent 1:1 classid 1:30 htb rate 11kbit ceil 32kbit
${TC} qdisc add dev eth2 parent 1:30 handle 30:0 sfq perturb 10
${TC} filter add dev eth2 parent 1:0 protocol ip handle 6 fw flowid 1:30
${EBTABLES} -A FORWARD -i eth1 -o eth2 -s 00:14:1C:E6:08:66 -j mark --set-mark 6 --mark-target ACCEPT
${TC} filter add dev eth2 parent 1:0 protocol ip u32 match ip src 192.168.1.1 flowid 1:30

So the idea is to have the script automatically pick the correct variables based on the IP Address detected using TC for example. At the present point we are almost on 300 clients so the script is very long.

Or just point me in the right direction if possible.

Unfortunately, that's a bit of a difficult requirment to understand...
You've listed that the example of Bandwidth CIR Upload and Bandwidth PIR Upload is 5kb/s and 16kb/s but the example code seems to show 11 and 32 instead.

What I suggest you do is to list all the variables you need the script to automatically pick, give them names that will be clear to the reader but are still valid names (for example, I would call a variable that contains the Bandwidth CIR Upload "bandwidthCIRUpload").

Then change the places in your script where the variables need ot be used to the variable name preceded by a $ symbol and surrounded by {}.
eg, if your script has a line:

Code:

${TC} class add dev eth1 parent 1:1 classid 1:30 htb rate 32kbit ceil 96kbit

and you want to have the '1:1', '32', and '64' be calculated automatically, change it to:

Code:

${TC} class add dev eth1 parent ${parent} classid 1:30 htb rate ${bandwidthCIRDownload}kbit ceil ${bandwidthPIRDownload}kbit

Once you have that done, report back here with your modified code and your list of variables.
Make sure to surround your code in [ C O D E ] tags so it is easier to read.
eg
[ C O D E ]
my code here
[ / C O D E ]