UNIX for Dummies Questions & Answers

Hi,

I have prepared script which is taking more time to process. find below script and help me with fast optimized script:-



cat name.txt | while read line
do

name=$(echo $line| awk '{print $8}')

MatchRecord=$(grep $name abc.txt | grep -v grep )

echo "$line | $MatchRecord" | awk -F"|" '
BEGIN { format = "%-6s %-10s %-10s %-4s %-19s %-6s %-2s %-6s %-4s\n" }
{
split($1, rsp," ")
split($2, req," ")
printf format, req[1], rsp[2], rsp[3], rsp[4], req[5], rsp[6], rsp[7],
rsp[8], rsp[9]
}'
done >> /tmp/new.txt

If you show us a sample input of those files and what you are trying to achieve, then it will be easy to relate the script.

As such here are some tips.

Change

Code:

cat name.txt | while read line
do
...
...
done >> /tmp/new.txt

to

Code:

while read line
do
...
...
done < name.txt >> /tmp/new.txt

Change

Code:

MatchRecord=$(grep $name abc.txt | grep -v grep )

to

Code:

MatchRecord=$(grep $name [a]bc.txt)

From what I see, probably the whole script can be written in awk or perl.

Thanks for quick reply


name.txt

...... 12345 67890 0000 ................... ...... 00 12345 2131

abc.txt

111111 12345 67890 0000 1234567890 12345 dfadsf

in both file 8th field is common. using common field i want to fill the blank fileds in name.txt for this value will be taken from abc.txt