Help with function


 
Thread Tools Search this Thread
Top Forums UNIX for Dummies Questions & Answers Help with function
# 1  
Old 06-07-2012
Help with function

Hi I'm a newbie in unix scripting and I'm trying to do a function that do the next:

Run this command: opcdeploy -cmd "utility -xs" -node node.com and store the result in a file.
Get the last ten lines from the stored file and do a search for the number 100, store that search in a variable.
If the result of that search is greater or equal than 100 then echo "hello"; else echo "bye".
Here is what I have done:

Code:
function utility {
opcdeploy -cmd "utility -xs" -node $SERVER | tail -10 > /home/oscar/Desktop/tail.util

let Z=100
let Y=`grep $Z /home/oscar/Desktop/tail.util`


if [ $Y -ge $Z ];then
    echo "hello"
  else
    echo "bye"
fi
}

please can someone help me to improve this, what I have done wrong?

thanks!

Last edited by Scrutinizer; 06-08-2012 at 03:01 AM.. Reason: code tags
# 2  
Old 06-08-2012
Grep for "100" will not find most values greater than 100 (eg 372, 2000, etc).
What does the output look like, and what value are you wanting to compare with 100?
# 3  
Old 06-08-2012
Quote:
Originally Posted by Chubler_XL
Grep for "100" will not find most values greater than 100 (eg 372, 2000, etc).
What does the output look like, and what value are you wanting to compare with 100?
I want to search for a number on the output of tail and if that number is greater or equal to 100 then do...
# 4  
Old 06-08-2012
Please post sample output of the last 10 lines from the opcdeploy ... command, highlighting where one might find a number with value 100 .
# 5  
Old 06-13-2012
Quote:
Originally Posted by Chubler_XL
Grep for "100" will not find most values greater than 100 (eg 372, 2000, etc).
What does the output look like, and what value are you wanting to compare with 100?
Thanks, the opcdeploy output is:

Code:
The Global      file is now  76.3% full with room for  15.0 more full days
The Application file is now  91.6% full with room for   8.7 more full days
The Process     file is now  98.4% full with room for   0.7 more full days
The Device      file is now  80.1% full with room for   3.3 more full days
The Transaction file is now 100.7% full with room for   0.0 more full days

So I want to get the % number and compare it, for example:

Get this number 76.3 and put it into a variable to compare(-ge) it with the number 100; then
echo bla bla bla

else
echo bla bla bla

fi

Last edited by methyl; 06-13-2012 at 01:33 PM.. Reason: code tags
# 6  
Old 06-13-2012
Quote:
Originally Posted by salaso
Thanks, the opcdeploy output is:

The Global file is now 76.3% full with room for 15.0 more full days
The Application file is now 91.6% full with room for 8.7 more full days
The Process file is now 98.4% full with room for 0.7 more full days
The Device file is now 80.1% full with room for 3.3 more full days
The Transaction file is now 100.7% full with room for 0.0 more full days

So I want to get the % number and compare it, for example:

Get this number 76.3 and put it into a variable to compare(-ge) it with the number 100; then
echo bla bla bla

else
echo bla bla bla

fi
Hi!
Why would you need a comparison?
If you can read 100, you have at least 100. So if you can read 100, you're done.

Hint:
Code:
 ( (egrep -q  "100\.*[0-9]*\%" /home/oscar/Desktop/tail.util ) && echo hello ) || echo bye

If you run your script frequently enough, you'll catch greater values in time (which I though was your goal).

However:

Code:
 ( (egrep -q  "[1-9][0-9]{2,}\.*[0-9]*\%" /home/oscar/Desktop/tail.util ) && echo hello ) || echo bye

will match every percent number greater or equal than 100%.

Last edited by Lem; 06-13-2012 at 01:44 PM..
# 7  
Old 06-13-2012
Quote:
Originally Posted by Lem
Hi!
Why would you need a comparison?
If you can read 100, you have at least 100. So if you can read 100, you're done.

Hint:
Code:
 ( (egrep -q  "100\.*[0-9]*\%" /home/oscar/Desktop/tail.util ) && echo hello ) || echo bye

If you run your script frequently enough, you'll catch greater values in time (which I though was your goal).

However:

Code:
 ( (egrep -q  "[1-9][0-9]{2,}\.*[0-9]*\%" /home/oscar/Desktop/tail.util ) && echo hello ) || echo bye

will match every percent number greater or equal than 100%.
Thank you Lem I tried this:

Code:
egrep -q  "[1-9][0-9]{2,}\.*[0-9]*\%" /home/oscar/Desktop/tail.util

but it didnt display any output, insted of that I tried this:

Code:
sed "s/[^0-9]//g;s/^$/-1/;" /home/oscar/Desktop/tail.util

and got this output for example for the first ovcodautil line:
Code:
"The Global      file is now  76.3% full with room for  15.0 more full days"

the output was 763150, but I need only the first three as they are on the line(76.3), any idea?

Last edited by Scrutinizer; 06-13-2012 at 07:27 PM.. Reason: code tags
 
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Function - Make your function return an exit status

Hi All, Good Day, seeking for your assistance on how to not perform my 2nd, 3rd,4th etc.. function if my 1st function is in else condition. #Body function1() { if then echo "exist" else echo "not exist" } #if not exist in function1 my all other function will not proceed.... (4 Replies)
Discussion started by: meister29
4 Replies

2. Shell Programming and Scripting

Need help on awk for printing the function name inside each function

Hi, I am having script which contains many functions. Need to print each function name at the starting of the function. Like below, functionname() { echo "functionname" commands.... } I've tried like below, func=`grep "()" scriptname | cut -d "(" -f1` for i in $func do nawk -v... (4 Replies)
Discussion started by: Sumanthsv
4 Replies

3. Shell Programming and Scripting

Will files, creaetd in one function of the same script will be recognized in another function?

Dear All. I have a script, which process files one by one. In the script I have two functions. one sftp files to different server the other from existing file create file with different name. My question is: Will sftp function recognize files names , which are created in another... (1 Reply)
Discussion started by: digioleg54
1 Replies

4. Shell Programming and Scripting

Passing variable value in a function to be used by another function

Hello All, I would like to ask help from you on how to pass variable value from a function that has been called inside the function. I have created below and put the variables in " ". Is there another way I can do this? Thank you in advance. readtasklist() { while read -r mod ver... (1 Reply)
Discussion started by: aderamos12
1 Replies

5. Shell Programming and Scripting

Help to Modify File Name in each function before calling another function.

I have a script which does gunzip, zip and untar. Input to the script is file name and file directory (where file is located) I am reading the input parameters as follows: FILENAME=$1 FILEDIR=$2 I have created 3 functions that are as follows: 1) gunzip file 2) unzip file... (2 Replies)
Discussion started by: pinnacle
2 Replies

6. Programming

How to step in one function after the function be executed in gdb?

In gdb, I can call one function with command "call", but how can I step in the function? I don't want to restart the program, but the function had been executed, gdb will execute next statement, and I don't know how to recall the function. (4 Replies)
Discussion started by: 915086731
4 Replies

7. Shell Programming and Scripting

SHELL SCRIPT Function Calling Another Function Please Help...

This is my function which is creating three variables based on counter & writing these variable to database by calling another function writeRecord but only one record is getting wrote in DB.... Please advise ASAP...:confused: function InsertFtg { FTGSTR="" echo "Saurabh is GREAT $#" let... (2 Replies)
Discussion started by: omkar.sonawane
2 Replies

8. Programming

Function pointer to inline function ?

Hi. Problem: I have to parse the payload of a packet. The payload could be in Big Endian Format (network byte order) or little. That depends on a flag present in the header of the packet. Solution: A horrible solution could be to check for that flag everytime I have to read a field in the... (11 Replies)
Discussion started by: emitrax
11 Replies

9. Shell Programming and Scripting

Return a value from called function to the calling function

I have two scripts. script1.sh looks -------------------------------- #!/bin/bash display() { echo "Welcome to Unix" } display ----------------------------- Script2.sh #!/bin/bash sh script1.sh //simply calling script1.sh ------------------------------ (1 Reply)
Discussion started by: mvictorvijayan
1 Replies

10. Shell Programming and Scripting

Passing global variable to a function which is called by another function

Hi , I have three funcions f1, f2 and f3 . f1 calls f2 and f2 calls f3 . I have a global variable "period" which i want to pass to f3 . Can i pass the variable directly in the definition of f3 ? Pls help . sars (4 Replies)
Discussion started by: sars
4 Replies
Login or Register to Ask a Question