about realloc routing


 
Thread Tools Search this Thread
Top Forums UNIX for Dummies Questions & Answers about realloc routing
# 1  
Old 10-24-2011
about realloc routing

Code:
#include <malloc.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

int*
allocat_array(void)
{
    int *array;
    int tmp;
    int n_values = 0 ;

    array = malloc(sizeof(int));
    if(array == NULL)
        return NULL;
    while(scanf("%d",&tmp) != EOF)
    {
        array = realloc(array,sizeof(int));
        if(array == NULL)
        {
            printf ( "Out of memory\n" );
            return NULL;
        }
        n_values += 1;
        array[n_values] = tmp;
    }
    
    array[0] = n_values;
    return array;
}

void
print_array(int const *array)
{
    int i;
    printf ( "\nThere are %d values in the array\n",array[0] );
     
    for(i = 1 ; i<= array[0];i++)
        printf ( "%d\n",array[i] );
}

int
main(void)
{
    int *array;
    array = allocat_array();
    if(array == NULL)
        exit(EXIT_FAILURE);
    print_array(array);

    free(array);
    return EXIT_SUCCESS;
}

---------- Post updated at 04:20 AM ---------- Previous update was at 04:09 AM ----------

there is something wrong int the code array = realloc(array,sizeof(int));

but the program can successfully run!
when i modify it to "array = realloc(array,(1 + n_values +1)*sizeof(int));"
the program run successfully ,too!
why !~
who can help me !
thanks !

Last edited by vincent__tse; 10-24-2011 at 05:15 AM..
# 2  
Old 10-24-2011
realloc allocates the size you tell it to allocate. If you just call realloc(sizeof(int)) all the time, it's going to give you the same size all the time. Naturally you need to keep adding more.

How many integer sizes do you need to store on the first loop, when n_values is zero? Two: One to hold the number of values, and another to hold the value itself. So your logic of (1 + n_values + 1) * sizeof(int) makes sense. You could as easily make that (n_values+2)*sizeof(int).

As an aside, calling realloc 937 times to add 937 pieces of data isn't very efficient. You should allocate more than you need, expand only when necessary, and shrink when you're done.
 
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

problem with realloc( i think is gcc :/ )

Hi everyone, i made this program. is a simple one for practising malloc, realloc and structs. I have a struct named shop as global variable in which i take the size of the matrix from the keyboard and after i malloc it. I insert the values with the fullarray() and after i print the matrix with... (7 Replies)
Discussion started by: giampoul
7 Replies

2. Programming

realloc() fails

Not sure in which forum to post this. I'm trying here, in Programming. I'm working on a PC with Intel Duo processor & 2GB of ram. OS is Ubuntu 10.04. I'm having problems with a C++ program that makes extensive use of realloc(). It happens that as soon as the overall memory allocated(OS +... (14 Replies)
Discussion started by: mamboknave
14 Replies

3. Programming

Realloc() question

b = realloc(a, 1000); if realloc succeeds and b!=a (not in-place replacement), does realloc automatically free a or I should free both a and b afterwards? thank you! (5 Replies)
Discussion started by: bashuser2
5 Replies

4. Programming

realloc fails in C : what next ?

Hi all I'm trying to use someone else's software, which has a realloc that fails in it. This is probably due to memory limitations, as it only happens when I use this software on huge datasets. First question : how to diagnose if it's a soft or hard limitation? I mean, if it's due to my... (10 Replies)
Discussion started by: jossojjos
10 Replies

5. Programming

What happens when realloc() fails?

Hi, I am seeing varying results about, when realloc() fails in reallocation. Which one is correct out of the below? a) realloc() maintains the original pointer (i.e) the original pointer is left unaltered/untouched but relloc() returns the NULL value. b) original buffer pointer is lost... (3 Replies)
Discussion started by: royalibrahim
3 Replies

6. Programming

malloc vs realloc

Why when using realloc, john is reversed 3 times but not the other 2 names ? But if I use malloc, then the 3 names are reversed correctly ? (but then there is a memory leak) How can I reverse all 3 names without a memory leak ? char *BUFFER = NULL; char *STRREVERSE(const char *STRING) {... (5 Replies)
Discussion started by: cyler
5 Replies

7. Programming

tolower (static pointer + malloc + realloc)

N00B here. This function would be easier using a char pointer along with free. But I wish to learn how to use char static pointers (they do not require free, right ?). How do I erase the content of a static pointer ? Terminating the string works but the static pointer's content is not being... (4 Replies)
Discussion started by: limmer
4 Replies

8. Programming

help with realloc() on Linux

hi, I'm using gcc version 3.4.6 on a Red Hat system... (not sure how to determine version of glibc) when i run the following, i get: glibc detected *** realloc(): invalid next size: 0x0804a170 I'm not sure what is wrong. The error happens on the second iteration of the while loop.... (3 Replies)
Discussion started by: Andrewkl
3 Replies

9. Programming

Does realloc free fairly?

Hello, my program works properly but valgrind tells me I am not freeing allocated memory. I think the problem is in realloc. I am pretty sure I do something wrong with realloc, because I changed it a bit and valgrind noticed less errors (that the program wasn't working properly with less errors... (3 Replies)
Discussion started by: samciz
3 Replies

10. Programming

Realloc

Can Any body give me a exampla which has the usage of realloc i want a function which uses realloc & increases /decreases the size of a pointer (0 Replies)
Discussion started by: wojtyla
0 Replies
Login or Register to Ask a Question