UNIX for Dummies Questions & Answers

hello i am trying to generate a list of the most bandwidth consuming ip's from an Apache style log file. the script is run with the path to the log file as the only peramater.

here is my code so far:

Code:

echo "The ten most bandwidth consuming IP's were:"
$outpt=''
for ip in $(awk '{print $1}' "$1" | sort | uniq); do

outpt="$outpt $(grep $ip $1 | awk '{sum+=$10} END {print sum/1024,"KB",$1}') "

done

echo $outpt

im very new to shell scripting and am having problems storing the results of my for loop in the variable $outpt so that i could perform a sort -rn | head -10 on the data.

also at the begining of the loop
"=: not found"

is outputed to the screen. any help would be much appriciated.

Hi.

I don't know what shell you are using, but most likely, this is wrong:

Code:

$outpt=''

Remove the $ and try it again.

It's possibly better to use "unset outpt" than outpt=''

Ok thanks for that i guess you don't need to declare a variable so i just removed that line and the error is removed. i guess what im still lacking is a way to insert a newline after each entry. I don't know if i can do this within my for loop or if i have to parse it with sed or something so i can use it as a list for sort

ps. i am using !#/bin/sh

Code:

nawk '{sum[$1]+=$10}END {for(i in sum) print sum[i]/1024, "KB", i}' myApacheLogFile | sort -nr -k1,1 | head -10

thanks vgersh99 but i get an error when i run that line:
nawk: can't read value of sum; it's an array name.
input record number 1386, file /var/log/httpd-access.log
source line number 1


edit
---------------
ok i fix the line to read

Code:

nawk '{sum[$1]+=$10}END {for(i in sum) print sum[$i]/1024, "KB", i}' "$1" | sort -nr -k1,1 | head -10

and it give almost a perfect output except that sum[$i] is always null and it is sorting by ip address not bandwidth usage

re-edit
-----------------
i got it just by removing the "$" from i thank you for this vgersh it also appears to be much faster then my original method