UNIX for Dummies Questions & Answers

Hi
I have this script

#!/bin/bash
cat status.txt | while read LINE
do
linija="$LINE"
echo $linija
echo $linija | awk '{print $1}' > temp.txt
koj=`tail -1 temp.txt`
echo $koj
echo $linija | awk '{print $2}' > temp1.txt
kolku=`tail -1 temp1.txt`
vkupno=$(( vkupno + kolku ))
echo $kolku
echo $vkupno > vkupno_temp.txt
done
kolku_vkupno=`tail -1 vkupno_temp.txt`
echo $kolku_vkupno

and its working perfectly in 2.05b.0(1) bash called with ksh and bash
But in 3.2.25(1) version of bash only the first line of status.txt passes. Then (on the second line of the file status.txt) i get this error : arithmetic syntax error
on this line vkupno=$(( vkupno + kolku )). Can someone pls help. What should i change in the script to work in new bash.

Thanks in advance

P.S. status.txt consists of lines :
sometext 4
another text 12
and so on

Try this..

vkupno=`expr $vkupno + $kolku`

in P.S. i wrote
sometext 4
another text 12

This would be an obvious mistake because awk '{print $2}' will get text and so on.
I must apologize

status.txt consist of
sometext 4
anothertext 12
thirdtext 45

---------- Post updated at 03:42 PM ---------- Previous update was at 03:04 PM ----------

Thanks but I get the same error with your suggestion.
Anyone pls?
It's driving me mad...

You do not initialize a variable.

Code:

#!/bin/bash
vkupno=0
cat status.txt | while read LINE
do
...
...
done

The "cat" should also not be there - it is called UUOC - useless use of cat - a waste of resources. There are also some other oddities in there - like using two awk calls each writing to a file, instead of just reading in the two variables on the while line.

If I understand your code I would write this:

Code:

#!/bin/bash
vkupno=0
while read koj kolku
do
  echo $koj
  echo $kolku
  vkupno=$(( vkupno + kolku ))
done < status.txt 
kolku_vkupno=$vkupno
echo $kolku_vkupno

I left in the echo statements, they look more like debug statements....

I tested your code on bash 3.2.38 and it worked fine. It might be that specific version has an issue or compatibility problem.

You could try this:

Code:

let vkupno=( $vkupno + $kolku )

A couple of things you can do to shorten or simplify this code:

Instead of two lines:

Code:

 
echo $linija | awk '{print $1}' > temp.txt
koj=`tail -1 temp.txt`

it could be written as one:

Code:

koj=$( echo $linija | awk '{print $1}' )

I might shorten the script by several lines and write the script this way:

Code:

while read txt num
do
    echo $txt
    echo $num
    let sum=( $sum + $num )
    echo $sum
done < status.txt
echo $sum

Here is the whole script:
#!/bin/bash
vkupno=0
while read txt num
do
echo $txt
echo $num
let vkupno=( $vkupno + $num )
echo $vkupno
if [ $(( num )) -lt 5 ]; then
STATUS="OK"
fi
if [ $(( num )) -ge 5 ]; then
STATUS="WORRIED"
fi
if [ $(( num )) -ge 10 ]; then
STATUS="PANIC"
fi
done < status.txt
echo $vkupno
if [ $(( vkupno )) -lt 10 ]; then
STATUS="OK"
fi
if [ $(( vkupno )) -ge 10 ]; then
STATUS="WORRIED"
fi
if [ $(( vkupno )) -ge 20 ]; then
STATUS="PANIC"
fi

Whatever i write on older bash it's working, and on this newer version nothing. I'm still getting the arithmetic error, even on if [ $(( num )) -lt 5 ]; then lines.
Anyway thanks a lot guys. If the script won't work at least i learned to write little more nicer code.
But if You have any ideas please....

I did find a few posts about syntax error issues with bash 3.2.x versions. A little more research is needed though. You didn't by chance edit the file on a Windows system? This would have left \n\r on the lines and cause errors. What version of RedHat are you running? Have you checked for updates to the bash rpm for that release?