Bad substitution issues.. but why?

 
Thread Tools Search this Thread
Top Forums UNIX for Beginners Questions & Answers Bad substitution issues.. but why?
# 1  
Old 08-25-2016
Bad substitution issues.. but why?

i am trying to prepare a train and test dataset, for which i need to randomly split the data into corresponding folders (train,test)..

I began on a simple script, but seem to get som weird error messages, that i cannot make sense of?..

what am I doing wrong?
Code:
#!/bin/bash
RED='\033[0;31m'
NC='\033[0m' # No Color


if [[ $1 = "" ]]
	then
		echo -e "${RED}Missing Workspace name! -  Provide a name!${NC}"
	exit 1	
fi

if [[ $2 = "" ]]
	then 
		echo -e "${RED}Missing path to dataset - SPH files${NC}"
	#exit 1	
fi

if [[ $3 = "" ]]
	then 
		echo -e "${RED}Missing path to Utt!${NC}"
	#exit 1
fi		

WORKSPACE=$1
PATH_TO_DATASET=$2
PATH_TO_UTT=$3

#Create the folder 

mkdir ../${WORKSPACE}
 
cd ../${WORKSPACE}
ln -s ../wsj/s5/steps .
ln -s ../wsj/s5/utils .
ln -s ../../src .

cp ../wsj/s5/path.sh .

mkdir -p ../${WORKSPACE}/exp
mkdir -p ../${WORKSPACE}/conf
mkdir -p ../${WORKSPACE}/data
mkdir -p ../${WORKSPACE}/data/test
mkdir -p ../${WORKSPACE}/data/train
mkdir -p ../${WORKSPACE}/data/local
mkdir -p ../${WORKSPACE}/data/local/lang

# Modify if Help script is needed
#################################
# Change order of utterance and name! 
# python help_scripts/change_order_name_utt.py  /PATH/TO/UTTERANCE 

# Partition data randomly into train and test. 
SPLIT=0.5 #train/test split
NUMBER_OF_FILES = $(ls $PATH_TO_DATASET |  wc -l) ## number of directories in the dataset

for ((i=1; i<=$(NUMBER_OF_FILES); i++))
do
	ran = ${python -c "import random; print random.randdouble(0,1)"}
	echo ${ran}
done

output
Code:
../workspace_setup.sh: line 54: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: ((: i<=: syntax error: operand expected (error token is "<=")


Last edited by kidi; 08-25-2016 at 05:07 PM..
# 2  
Old 08-25-2016
did you try this code
Code:
NUMBER_OF_FILES = ${ls ${PATH_TO_DATASET} |  wc -l )

before including it in a script?
# 3  
Old 08-25-2016
In cases like this, please ALWAYS post the entire script, so the the error line (54 ?) can be located. Or, add line numbers.

It seems you are trying to deploy "command substitution", which is done with $(...) not - as you are doing - with ${...}.
# 4  
Old 08-25-2016
Been a while, but I think your line 54 should be using () and not {}

Code:
NUMBER_OF_FILES = $(ls ${PATH_TO_DATASET} |  wc -l) ## number of directories in the dataset

# 5  
Old 08-25-2016
As has already been said, command substitutions are surrounded by parentheses $( command ) not by braces ${ command }.

Once you fix that you'll run into the problem that there cannot be any spaces around the = in shell variable assignments.

Try changing:
Code:
NUMBER_OF_FILES = ${ls ${PATH_TO_DATASET} |  wc -l} ## number of directories in the dataset

for i in {1..${NUMBER_OF_FILES}}
do
	ran = ${python -c "import random; print random.randdouble(0,1)"}

to:
Code:
NUMBER_OF_FILES=$(ls ${PATH_TO_DATASET} |  wc -l) ## number of directories in the dataset

for i in {1..${NUMBER_OF_FILES}}
do
	ran=$(python -c "import random; print random.randdouble(0,1)")

# 6  
Old 08-25-2016
this will work...
Code:
NUMBER_OF_FILES = $(ls $PATH_TO_DATASET |  wc -l)

# 7  
Old 08-25-2016
I suspect the for loop will not do as expected either...

for i in {1..${NUMBER_OF_FILES}}

Example, OSX 10.7.5, default bash terminal...
Code:
#!/bin/bash
# for_loop.sh
loop=10
for num in {1..${loop}}
do
	echo "$num"
done

Results:-
Code:
Last login: Thu Aug 25 19:29:16 on ttys000
AMIGA:barrywalker~> bash --version
GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11)
Copyright (C) 2007 Free Software Foundation, Inc.
AMIGA:barrywalker~> 
AMIGA:barrywalker~> cd Desktop/Code/Shell
AMIGA:barrywalker~/Desktop/Code/Shell> chmod 755 for_loop.sh
AMIGA:barrywalker~/Desktop/Code/Shell> ./for_loop.sh
{1..10}
AMIGA:barrywalker~/Desktop/Code/Shell> _

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Bad substitution - ShellCheck says okay

ShellCheck doesn't find any issues with this script. #!/bin/bash # color_meanings: explain meanings of colors used in bash ls eval "$(echo "no:fi:di:ln:pi:so:do:bd:cd:or:mi:su:sg:tw:st:ex" | sed -e 's/:/=/g; s/\;/\n/g')" { IFS=: for i in $LS_COLORS do ... (18 Replies)
Discussion started by: Xubuntu56
18 Replies

2. Shell Programming and Scripting

Bad substitution

Cant undestand :) why i have an error on line 2.it is working on my other boxes #!/bin/bash ret=$(echo Q | timeout 5 openssl s_client connect "${1`hostname`}:${2-443}" -ssl3 2> /dev/null) if echo "${ret}" | grep -q 'Protocol.*SSLv3'; then if echo "${ret}" | grep -q 'Cipher.*0000'; then ... (7 Replies)
Discussion started by: kenshinhimura
7 Replies

3. Shell Programming and Scripting

Why I get bad bad substitution when using eval?

Why I get bad replace when using eval? $ map0=( "0" "0000" "0") $ i=0 $ eval echo \${map$i} 0000 $ a=`eval echo \${map$i}` !!!error happens!!! bash: ${map$i}: bad substitution How to resolve it ? Thanks! (5 Replies)
Discussion started by: 915086731
5 Replies

4. Programming

Make: Bad Substitution

Hi, I have a make file which I try to execute, but it failed when it arrived to the line: for r in ${PIPESTATUS }; do if (($r != 0)); then exit $r; fi;done; With the Error: ""make:/bin/sh: Bad substitution"" Or the Error: "make:${PIPESTATUS[...}: Bad substitution" (Depend on the operating... (3 Replies)
Discussion started by: nadne
3 Replies

5. Shell Programming and Scripting

bad substitution error!

Hi All, I'm building a new shell script but i'm facing a problem with one line which is giving "bad substitution" error. Please assist script lines: #!/bin/sh printf "%s: " "Occurrence DATE (YYYYMMDD)"; read DATE shortdate=${DATE#??} o/p: ./test1: bad substitution This command is... (2 Replies)
Discussion started by: Dendany83
2 Replies

6. UNIX for Dummies Questions & Answers

bad substitution

#!/bin/bash a1=( win 12,01,02,03,04 ) a2=( pre 04,05,06 ) a3=( msn 06,07,08,09 ) Given the above arrays, I want the script to return/echo the following in a loop; win 12,01,02,03,04 pre 04,05,06,07 msn 06,07,08,09 But I can't get it to do as such. I've tried; (2 Replies)
Discussion started by: Muhammad Rahiz
2 Replies

7. Shell Programming and Scripting

bad substitution error in ksh

Hello, In bash I can use the following: TMP=12345 MID=${TMP:1:1} the expected result is: 2 but when using KSH I'm getting a ''bad substitution" error. What is the correct syntaxin ksh? Thanks (2 Replies)
Discussion started by: LiorAmitai
2 Replies

8. Shell Programming and Scripting

bad substitution error in ksh

hi, i created a shell script having the following content: #! /usr/bin/ksh FROM="myemail@domain.com" MAILTO="someemail@domain" SUBJECT="TEST" BODY="/export/home/adshocker/body.txt" ATTACH="/export/home/adshocker/attach.prog" echo $ATTACH ATTACH_NAME="${ATTACH##*/}" echo $ATTACH_NAME... (5 Replies)
Discussion started by: adshocker
5 Replies

9. Shell Programming and Scripting

Array reference - bad substitution

I've created a series of arrays named as follows: row1 row2 row3 . . . row10 Each has 4 elements. I'm trying to echo the array elements out in a for loop. Here's what I have: for ((i=1;i<=10;i++)) do for ((j=1;j<=4;j++)) do eval out=${row`echo $i`} echo -n $out (3 Replies)
Discussion started by: swankgd
3 Replies

10. Shell Programming and Scripting

Bad Substitution

Need Help... I am getting a bad substitution error on my script on a Solaris Server. However the script has been proven to work on HPUX and Solaris servers... #!/usr/bin/sh # # Set the location of the tzupdater.jar file # JAR=/tmp/tzupdater.jar # <<<<< UPDATE THIS LINE... (3 Replies)
Discussion started by: D_Redd74
3 Replies
Login or Register to Ask a Question