Bad substitution issues.. but why?

Login or Register to Ask a Question and Join Our Community

Bad substitution issues.. but why?

Login to Discuss or Reply to this Discussion in Our Community

Top Forums UNIX for Beginners Questions & Answers Bad substitution issues.. but why?

08-25-2016

Registered User

12, 0

Join Date: Aug 2016

Last Activity: 19 December 2016, 2:41 PM EST

Posts: 12

Thanks Given: 1

Thanked 0 Times in 0 Posts

Bad substitution issues.. but why?

i am trying to prepare a train and test dataset, for which i need to randomly split the data into corresponding folders (train,test)..

I began on a simple script, but seem to get som weird error messages, that i cannot make sense of?..

what am I doing wrong?

Code:

#!/bin/bash
RED='\033[0;31m'
NC='\033[0m' # No Color


if [[ $1 = "" ]]
	then
		echo -e "${RED}Missing Workspace name! -  Provide a name!${NC}"
	exit 1	
fi

if [[ $2 = "" ]]
	then 
		echo -e "${RED}Missing path to dataset - SPH files${NC}"
	#exit 1	
fi

if [[ $3 = "" ]]
	then 
		echo -e "${RED}Missing path to Utt!${NC}"
	#exit 1
fi		

WORKSPACE=$1
PATH_TO_DATASET=$2
PATH_TO_UTT=$3

#Create the folder 

mkdir ../${WORKSPACE}
 
cd ../${WORKSPACE}
ln -s ../wsj/s5/steps .
ln -s ../wsj/s5/utils .
ln -s ../../src .

cp ../wsj/s5/path.sh .

mkdir -p ../${WORKSPACE}/exp
mkdir -p ../${WORKSPACE}/conf
mkdir -p ../${WORKSPACE}/data
mkdir -p ../${WORKSPACE}/data/test
mkdir -p ../${WORKSPACE}/data/train
mkdir -p ../${WORKSPACE}/data/local
mkdir -p ../${WORKSPACE}/data/local/lang

# Modify if Help script is needed
#################################
# Change order of utterance and name! 
# python help_scripts/change_order_name_utt.py  /PATH/TO/UTTERANCE 

# Partition data randomly into train and test. 
SPLIT=0.5 #train/test split
NUMBER_OF_FILES = $(ls $PATH_TO_DATASET |  wc -l) ## number of directories in the dataset

for ((i=1; i<=$(NUMBER_OF_FILES); i++))
do
	ran = ${python -c "import random; print random.randdouble(0,1)"}
	echo ${ran}
done

output

Code:

../workspace_setup.sh: line 54: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: NUMBER_OF_FILES: command not found
./workspace_setup.sh: line 56: ((: i<=: syntax error: operand expected (error token is "<=")

Last edited by kidi; 08-25-2016 at 05:07 PM..

kidi

View Public Profile for kidi

Find all posts by kidi

08-25-2016

Moderator

6,876, 694

Join Date: Sep 2005

Last Activity: 10 February 2021, 3:50 AM EST

Location: Switzerland - GE

Posts: 6,876

Thanks Given: 594

Thanked 694 Times in 627 Posts

did you try this code

Code:

NUMBER_OF_FILES = ${ls ${PATH_TO_DATASET} |  wc -l )

before including it in a script?

vbe

View Public Profile for vbe

Find all posts by vbe

08-25-2016

Registered User

15,129, 5,008

Join Date: Jul 2012

Last Activity: 4 May 2020, 4:31 PM EDT

Location: Aachen, Germany

Posts: 15,129

Thanks Given: 735

Thanked 5,008 Times in 4,483 Posts

In cases like this, please ALWAYS post the entire script, so the the error line (54 ?) can be located. Or, add line numbers.

It seems you are trying to deploy "command substitution", which is done with $(...) not - as you are doing - with ${...}.

RudiC

View Public Profile for RudiC

Find all posts by RudiC

08-25-2016

Registered User

2,524, 241

Join Date: Dec 2007

Last Activity: 17 March 2020, 2:04 PM EDT

Posts: 2,524

Thanks Given: 173

Thanked 241 Times in 206 Posts

Been a while, but I think your line 54 should be using () and not {}

Code:

NUMBER_OF_FILES = $(ls ${PATH_TO_DATASET} |  wc -l) ## number of directories in the dataset

joeyg

View Public Profile for joeyg

Find all posts by joeyg

08-25-2016

Registered User

12,315, 4,560

Join Date: Jul 2012

Last Activity: 22 November 2019, 4:29 PM EST

Location: San Jose, CA, USA

Posts: 12,315

Thanks Given: 952

Thanked 4,560 Times in 3,818 Posts

As has already been said, command substitutions are surrounded by parentheses $( command ) not by braces ${ command }.

Once you fix that you'll run into the problem that there cannot be any spaces around the = in shell variable assignments.

Try changing:

Code:

NUMBER_OF_FILES = ${ls ${PATH_TO_DATASET} |  wc -l} ## number of directories in the dataset

for i in {1..${NUMBER_OF_FILES}}
do
	ran = ${python -c "import random; print random.randdouble(0,1)"}

to:

Code:

NUMBER_OF_FILES=$(ls ${PATH_TO_DATASET} |  wc -l) ## number of directories in the dataset

for i in {1..${NUMBER_OF_FILES}}
do
	ran=$(python -c "import random; print random.randdouble(0,1)")

Don Cragun

View Public Profile for Don Cragun

Find all posts by Don Cragun

08-25-2016

Moderator

6,876, 694

Join Date: Sep 2005

Last Activity: 10 February 2021, 3:50 AM EST

Location: Switzerland - GE

Posts: 6,876

Thanks Given: 594

Thanked 694 Times in 627 Posts

this will work...

Code:

NUMBER_OF_FILES = $(ls $PATH_TO_DATASET |  wc -l)

vbe

View Public Profile for vbe

Find all posts by vbe

08-25-2016

Registered User

1,709, 666

Join Date: Jan 2013

Last Activity: 20 May 2020, 1:43 PM EDT

Location: Loughborough

Posts: 1,709

Thanks Given: 838

Thanked 666 Times in 467 Posts

I suspect the for loop will not do as expected either...

for i in {1..${NUMBER_OF_FILES}}

Example, OSX 10.7.5, default bash terminal...

Code:

#!/bin/bash
# for_loop.sh
loop=10
for num in {1..${loop}}
do
	echo "$num"
done

Results:-

Code:

Last login: Thu Aug 25 19:29:16 on ttys000
AMIGA:barrywalker~> bash --version
GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11)
Copyright (C) 2007 Free Software Foundation, Inc.
AMIGA:barrywalker~> 
AMIGA:barrywalker~> cd Desktop/Code/Shell
AMIGA:barrywalker~/Desktop/Code/Shell> chmod 755 for_loop.sh
AMIGA:barrywalker~/Desktop/Code/Shell> ./for_loop.sh
{1..10}
AMIGA:barrywalker~/Desktop/Code/Shell> _

wisecracker

View Public Profile for wisecracker

Find all posts by wisecracker

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Bad substitution - ShellCheck says okay

ShellCheck doesn't find any issues with this script. #!/bin/bash # color_meanings: explain meanings of colors used in bash ls eval "$(echo "no:fi:di:ln:pi:so:do:bd:cd:or:mi:su:sg:tw:st:ex" | sed -e 's/:/=/g; s/\;/\n/g')" { IFS=: for i in $LS_COLORS do ...

2. Shell Programming and Scripting

Bad substitution

Cant undestand :) why i have an error on line 2.it is working on my other boxes #!/bin/bash ret=$(echo Q | timeout 5 openssl s_client connect "${1`hostname`}:${2-443}" -ssl3 2> /dev/null) if echo "${ret}" | grep -q 'Protocol.*SSLv3'; then if echo "${ret}" | grep -q 'Cipher.*0000'; then ...

3. Shell Programming and Scripting

Why I get bad bad substitution when using eval?

Why I get bad replace when using eval? $ map0=( "0" "0000" "0") $ i=0 $ eval echo \${map$i} 0000 $ a=`eval echo \${map$i}` !!!error happens!!! bash: ${map$i}: bad substitution How to resolve it ? Thanks!

4. Programming

Make: Bad Substitution

Hi, I have a make file which I try to execute, but it failed when it arrived to the line: for r in ${PIPESTATUS }; do if (($r != 0)); then exit $r; fi;done; With the Error: ""make:/bin/sh: Bad substitution"" Or the Error: "make:${PIPESTATUS[...}: Bad substitution" (Depend on the operating...

5. Shell Programming and Scripting

bad substitution error!

Hi All, I'm building a new shell script but i'm facing a problem with one line which is giving "bad substitution" error. Please assist script lines: #!/bin/sh printf "%s: " "Occurrence DATE (YYYYMMDD)"; read DATE shortdate=${DATE#??} o/p: ./test1: bad substitution This command is...

6. UNIX for Dummies Questions & Answers

bad substitution

#!/bin/bash a1=( win 12,01,02,03,04 ) a2=( pre 04,05,06 ) a3=( msn 06,07,08,09 ) Given the above arrays, I want the script to return/echo the following in a loop; win 12,01,02,03,04 pre 04,05,06,07 msn 06,07,08,09 But I can't get it to do as such. I've tried;

7. Shell Programming and Scripting

bad substitution error in ksh

Hello, In bash I can use the following: TMP=12345 MID=${TMP:1:1} the expected result is: 2 but when using KSH I'm getting a ''bad substitution" error. What is the correct syntaxin ksh? Thanks

8. Shell Programming and Scripting

bad substitution error in ksh

hi, i created a shell script having the following content: #! /usr/bin/ksh FROM="myemail@domain.com" MAILTO="someemail@domain" SUBJECT="TEST" BODY="/export/home/adshocker/body.txt" ATTACH="/export/home/adshocker/attach.prog" echo $ATTACH ATTACH_NAME="${ATTACH##*/}" echo $ATTACH_NAME...

9. Shell Programming and Scripting

Array reference - bad substitution

I've created a series of arrays named as follows: row1 row2 row3 . . . row10 Each has 4 elements. I'm trying to echo the array elements out in a for loop. Here's what I have: for ((i=1;i<=10;i++)) do for ((j=1;j<=4;j++)) do eval out=${row`echo $i`} echo -n $out

10. Shell Programming and Scripting

Bad Substitution

Need Help... I am getting a bad substitution error on my script on a Solaris Server. However the script has been proven to work on HPUX and Solaris servers... #!/usr/bin/sh # # Set the location of the tzupdater.jar file # JAR=/tmp/tzupdater.jar # <<<<< UPDATE THIS LINE...

Login or Register to Ask a Question