UNIX for Advanced & Expert Users

Hi ,

I have written code which will ask the subject,body of the mail, attachment and mail id of the receipient.
Code will pick up 4 files zip it. It will zip all the files and then post the mail to the receipient. While zipping the file i am getting error. Can anyone help me with this.

#!/bin/Sh

##Parameters to be passed
echo 'What subject do you want to put for mail'
read subject

echo 'Pass the path of the text file containing the body of the mail'
read body

echo 'Pass the path of the files need to be attached'
read attachment_path

echo 'Pass the mail id'
read mail_receiver


##Start of Program
cd $attachment_path
echo 'current path is' `pwd`


## Count and initialize parameters
count=`ls|wc -l`
echo 'count is '$count
a=0


##introduced while loop to pick up the first 4 files and zip. Delete the files that are already zipped and pick the other file
## to be zipped

while [ $count -gt 0 ]
do
ls|head -4 > zipfiles
cat zipfiles
sed - e 'y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/AbcdeFghIjklmnopqRstuvwxyz/' -e "s/^/\'/" -e "s/$/\'/" <zipfiles> zfile

list_of_file=`cat zfile`
echo $list_of_file

a=`expr $a + 1`
zip Snaps[$a] $list_of_file
rm $list_of_file
count=0
echo 'Files zipped'
rm zfile
done

## This block send the mail to the receiver.
file=`ls`
echo 'count of zip file -' $file
for i in $file
do
echo $i
var=$i
( cat $body
uuencode $var $var
) | mailx -s "$subject" ${mail_receiver}

done
***************************------**********************

While Executing this I am getting error :

current path is /export/home/jmirani/MAILExample/attach
count is 120
First month of RIA 001.jpg
First month of RIA 002.jpg
First month of RIA 003.jpg
First month of RIA 004.jpg
'First month of RIA 001.jpg' 'First month of RIA 002.jpg' 'First month of RIA 003.jpg' 'First month of RIA 004.jpg'
mail.sh[57]: 'First: not found

zip error: Nothing to do! (Snaps[1].zip)
'First: No such file or directory
month: No such file or directory
of: No such file or directory
RIA: No such file or directory
001.jpg': No such file or directory
'First: No such file or directory
month: No such file or directory
of: No such file or directory
RIA: No such file or directory
002.jpg': No such file or directory
'First: No such file or directory
month: No such file or directory
of: No such file or directory
RIA: No such file or directory
003.jpg': No such file or directory
'First: No such file or directory
month: No such file or directory
of: No such file or directory
RIA: No such file or directory
004.jpg': No such file or directory
Files zipped


All though files have been put into string still zip takes the wrong file name. Any help with this is much appreciated.

I tried zip trial 'First month of RIA 001.jpg' 'First month of RIA 002.jpg' 'First month of RIA 003.jpg' 'First month of RIA 004.jpg'
and this works properly.But code doesn't work?

It is very hard to to work with filenames that contain embedded blanks. The files are broken up by the spaces. You will need to arrange for each file name to be surrounded by quotes.

I have already arrange the files surrounded by quote, but for some reason it is giving error while zipping the files. I have also provided the results with the problem occuring.

I treied your script. I don't know how it got it run like that. I had to fix the sed statement. You have:
sed -e 'y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/AbcdeFghIjklmnopqRstuvwxyz/' -e "s/^/\'/" -e "s/$/\'/"
that first "- e" should not have a space between the - and the e. I didn't have zip, so I chaged it to "ls -l" for testing. At first I got the same errors as you. But then this worked:
eval ls -l $list_of_file

space in sed was my copy paste mistake.

I am also doinf echo before zipping and i am getting :
'First month of RIA 001.jpg' 'First month of RIA 002.jpg' 'First month of RIA 003.jpg' 'First month of RIA 004.jpg'

Every file is surrounded by quotes and should be picked up correctly while zipping but not getting picked.

Can someone help mw with why zip command is not picking up the files peoperly.

I tried this maually

zip <ZIPFILENAME> 'First month of RIA 001.jpg' 'First month of RIA 002.jpg' 'First month of RIA 003.jpg' 'First month of RIA 004.jpg'

above commna dworked properly and created <ZIPFILENAME>.zip

Help HelpHelp!!!!!!!!

If you won't try "eval" there is no point in trying to help you.

I am more than happy to try eval, unfortunately don't know what and where should i put this to get the result i am expecting.

I have read the help of eval command, but since eval doesn't zip the file , i haven't tried it.

Can you put the command in the appropriate place of the script i have pasted, and i will be more than happy to try this.

Sorry for any inconvenience caused.