Shell Programming and Scripting

I want to ftp all the sh files in the directory. Also if any of the file name
contains spaces in them, it should be converted to underscores before it is ftped. I wrote the following code below:

FILESSH=$(ls /mysh/*.sh)

--- FILESH being used here for some other task ---

echo "$FILESSH" | while read FILE
do

echo "$FILE" | grep " " >/dev/null && {

mv "$FILE" `echo "$FILE" | sed 's/ /_/g'`; echo "Name changed";
FILE=`echo "$FILE" | sed 's/ /_/g'`;

}

-- I will FTP the $FILE here ---

done

Can the line in red be avoided without using another variable in the code. I dont know why I am asking but just want to know if it can done. Is there any other nice method of doing the above task. (The dir may contain thousands of files so dont want to perform mv on all).... Thanks.......

That will break your script if any filenames contain leading or trailing spaces. Use wildcards directly:

Code:

for FILE in /mysh/*.sh

Or set IFS to a null string:

Code:

echo "$FILESSH" | while IFS= read -r FILE

There's no need for an external command:

Code:

case $FILE in
     *\ *) : do whatever ;;
esac

Code:

NEWFILE=`echo "$FILE" | sed 's/ /_/g'`
## in bash or ksh93:
## NEWFILE=${FILE// /_}

mv "$FILE" "$NEWFILE" && echo "Name changed"

Code:

FILESSH=$(ls /mysh/*.sh)
--- FILESH being used here for some other task ---
echo "$FILESSH" | while read FILE

This does not break for leading or traing whitespaces for me...

Code:

 for FILE in $(echo $FILESSH)

This breaks for any space in the name

Code:

for FILE in /mysh/*.sh

Code:

echo "$FILESSH" | while IFS= read -r FILE

Code 1,3,4 breaks if no sh file is found in the directory (they goes in loop once)....Code 2 does not but it breaks for any space in filename Any ideas?

No duplicate or cross-posting, please read the rules.

Continue here:

https://www.unix.com/shell-programmin...ng-spaces.html

Thread closed.