Shell Programming and Scripting

G'day all

This is a desperate call to those out there who know anything about Bourne Shell scripting, as I'm in the middle of a crisis

Pleae E-Mail me if you believe you can help (No spamming please)

The sooner the better, if you're an aussie that lives in Victoria, I'll even try to get you a six-pack of VB.
(That's an incentive alright! Hahahahaha)

Thankyou all very much

Aussie_Bloke

Pls read the forum rules

https://www.unix.com/unix-for-beginners-questions-and-answers/2971-simple-rules-unix-com-forums.html

(10) Don't post your email address and ask for an email reply. The forums are for the benefit of all, so all Q&A should take place in the forums.

Anyway what is the question about bourne shell ? you can try post it for us to help, not asking for email reply's.

G'day

The problem that I've got is that I've written a Bourne Shell script, complete with case statements, and it seems that UNIX believes that there's a part missing.

The error that I receive (Ungratefully) is:
syntax error: ;; unexpected
Or at least something to the tune of this, as I know that it's dealing with the case statement, the only question is where I may be wrong, any suggestions anyone?

The only reason that I'm putting this up here is because the ;; that is being referred to is supposedly at the end of the file, where no such symbol / expression exists?

I'm beginning to think that the system is hallucinating.....

Any suggestions as to what the problem might be?
Is the system really on LSD? or is it just my s***ty programming?

Thanks all

Aussie_Bloke

Are your case statements correct?
They follow the format:

Code:

case $something_here in
whatever_1) something_else_here ;;
whatever_2) something_else_else_here ;;
esac

Also, if you have unmatched " or ' marks anywhere in there, it could be messing you up there somewhere...

Can you post parts of the actual case statement and surrounding code?

[On a side note: I noticed that this is very likely a homework assignment based on your email address... I guess it's not as bad as asking someone to write the script for you, but generally it's not cool to post homework questions. I'm willing to help troubleshoot as long as you write the code yourself, though]

G'day LivinFree

The case statement that is out of sorts is actually within another case statement, would that possible have any effect on the outcome, given that there's 4 items to choose from in both?

Another possibility could be that I'm using windows notepad to create the file, porting it to UNIX via FTP to a local server, could that create problems?

I've also noticed that even though I'm sending the same file the file sizes are different, under dos and UNIX. The difference varies, but it's not more than 100 bytes, should that be cause for concern?

As requested, here's an edited selection of the file:

Code:

        echo -----------
	echo -Logs-Menu-
	echo -----------
	echo
	echo "1. Search Logs for a file"
	echo
	echo "2. View all sorted by date / time"
	echo
	echo "3. View by type (Backup or Restore)"
	echo
	echo "4. Quit"
	echo
	echo Please make your selection
	read selection
	case $selection in
	1) #Search logs for something
	echo Please enter a file name to search for
	read searchname
	cd logs
	grep $searchname *.*
	grep $searchname >> log_file2
	;;
	2) #View all sorted by date / time
	echo Displaying all log files
	more *.*
	;;
	3) #View by type
	echo Please enter what type you want
	echo "(B for backup or R for restore)"
	read choice
	if [ $choice = "B" ]
	then
	cd logs
	grep B *.*
		else
		grep R *.*
	;;
	4) #Quit
	done
	quit
	exit
	;;

esac
4) #Quit
exit
;;
esac

The text at the bottom (The 4) #Quit portion) is the last part of the first case statement.

Note that I'm now also getting another message, claiming that the indicated line (** Code **) has an unexpected `)'
Just wondering if it would be possible to explain that one too...

Thanks

Aussie_Bloke

[I added code tags for readability....Perderabo]

The "if" statement that you posted is wrong...you need a "fi to end it.

Code:

if [ $choice = "B" ]
then
    cd logs
    grep B *.* 
else
    grep R *.*
fi

Sorry mate

Should've told yas sooner, I've already found that one

Thanks anyways

Still doesn't work though, claims that there's an unexpected `)'
(Indicated with ** Code **)
Somewhere in there

then
cd logs
** grep B *.*
else
grep R *.*
;;
4) #Quit **
done
quit
exit
;;

esac
4) #Quit
exit
;;
esac

Thanks for your help, as it's both needed and greatly apprecitaed

Aussie_Bloke