Shell Programming and Scripting

I have posted my code:

#!/usr/bin/ksh

echo "Test Script: Read Data from file, myfile.txt"
cat test.txt | while read line
do
var=$line
var1=`awk 'END { print substr(val,1,10) }' val=$var < /dev/null`
var2=`awk 'END { print substr(val,12,21) }' val=$var < /dev/null`
echo $var1
echo $var2
var3=$var1"_"$var2.jpg
echo $var3
cd /some/path
find . -name $var3 -print
if [ $? -eq 0 ]; then
rm $var3
fi
cd /some/other/path
done

I would really appreciate if someone can help me .

Thanks.

Hey it does finds the file but does not removes it from that directory, it gives an error

1234567890_3456789012.jpg
/some/path/1234567890_3456789012.jpg
find: cannot execute rm{}:: No such file or directory

This is what I did in my script

var3=$var1"_"$var2.jpg
echo $var3
find /some/path -name "$var3" -print -exec rm{} \;

If someone could clarify this command, that would be great.

Thanks.

There needs to be a space between rm and {}

Thanks for your help everybody, my script is working fine now, I wasn't doing it right.
I wrote this command and its working fine, its searching for files with filename in some directory and deleteing it from there.

find /some/path -name "$filename" -exec rm {} \;

Thanks again.

Nice going!

But just a hint. Shouldn't ksh be able to extract substrings internally, so that You don't have to call awk so often? Especially in a loop and with a lot of files. You may save SECONDS! Try to find it, in bash it would be something like

Code:

var1=${var:1:10}

instead of

Code:

var1=`awk 'END { print substr(val,1,10) }' val=$var < /dev/null`

(not sure about Your indexing...)

or even as an extension:

Code:

var3=${var:1:10}"_"${var:12:21}.jpg

instead of

Code:

var1=`awk 'END { print substr(val,1,10) }' val=$var < /dev/null`
var2=`awk 'END { print substr(val,12,21) }' val=$var < /dev/null`
var3=$var1"_"$var2.jpg

I still think it's clear enough and probably a lot faster.

But qneill's post is very valid, when developing scripts, it is good to save intermediary results, so You can run the "first" part and check to see that these really are the files You want to affect. And then operate on that set. And so on. It may even be more efficient.

Good Luck!

/Lakris