What's wrong with this script


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting What's wrong with this script
# 1  
Old 11-12-2007
What's wrong with this script

I am trying to create a script but it is giving me errors on Cygwin for the following script. Could someone tell me, what am I doing wrong?

choice=1000
echo "choice is $choice"
while [ $choice -ne 0 ]; do
echo "choice is $choice"
echo 'Please select your option:'
echo '1. Option 1'
echo '2. Option 2'
echo 'Enter the number:'
read choice
echo "choice is $choice"

if [ $choice -eq 1]; then
echo "You selected option 1"
choice=0
elif [$choice -eq 2]; then
echo "You selected option 2"
choice=0
else
echo "You have entered a wrong choice. Please choose from the options given"
choice=1000
fi
done
echo "Completed."


Response that I get is:
choice is 1000
choice is 1000
Please select your option:
1. Option 1
2. Option 2
Enter the number:
1
choice is 1
[: missing ]
[1: not found
You have entered a wrong choice. Please choose from the options given
choice is 1000
Please select your option:
1. Option 1
2. Option 2
Enter the number:

I think it is not taking $choice as integer in the condition box, but i am not sure.
# 2  
Old 11-12-2007
U missed blanks:
Code:
[ $choice -eq 2]

should be:
Code:
[ $choice -eq 2 ]

Regards
# 3  
Old 11-12-2007
Hey thanks. That works. Can't believe the mistake, but that was an excellent pick on your side. Thanks once again.
# 4  
Old 11-12-2007
Suggestively, you may want to use a case statement in place of the if-elif.
This would allow for expansion if required later. And it's IMHO easier to read.

That is:
Code:
choice=1000
echo "choice is $choice"

while [ $choice -ne 0 ]; do

  echo "choice is $choice"
  echo 'Please select your option:'
  echo '1. Option 1'
  echo '2. Option 2'
  echo 'Enter the number:'
  read choice
  echo "choice is $choice"

  case $choice in
  1)  echo "You selected option 1"
      choice=0 ;;
  2)  echo "You selected option 2"
      choice=0 ;;
  *)  echo "You have entered a wrong choice. Please choose from the options given"
      choice=1000 ;;
  esac

done
echo "Completed."

Hope that helps some. Smilie

Cheers,
Cameron
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Why result is wrong here ? whether break statement is wrong ?

Hi ! all I am just trying to check range in my datafile pls tell me why its resulting wrong admin@IEEE:~/Desktop$ cat test.txt 0 28.4 5 28.4 10 28.4 15 28.5 20 28.5 25 28.6 30 28.6 35 28.7 40 28.7 45 28.7 50 28.8 55 28.8 60 28.8 65 28.1... (2 Replies)
Discussion started by: Akshay Hegde
2 Replies

2. Shell Programming and Scripting

What is wrong with my script?

Dear All The following is part of my script: echo ${myarray} mytitle=`awk '{print substr(${myarray}, 0, length(${myarray})-4)}' /dev/null` the echo ${myarray} works fine; however, I keep getting following error for the mytitle=.. part: awk: line 1: syntax error at or near { awk: line... (3 Replies)
Discussion started by: littlewenwen
3 Replies

3. Shell Programming and Scripting

Can anyone tell me what's wrong with my script

Hi... I am fed up in file handing with array for comparing.... 1st I want save first 2 columns of file 1 I tried like this,, {getline< "file1";ln=$1; lt=$2}then I read second file's 1st and 2nd column..and saved like this and small calculation and initialization var1 =$1 var2 =$2... (5 Replies)
Discussion started by: Akshay Hegde
5 Replies

4. UNIX for Dummies Questions & Answers

What's wrong on this script?

I get this error on these lines when i run this script:"for i in /home;do file2=`ls -s $i` if ;then ls - s $i fi done (7 Replies)
Discussion started by: kotsos13
7 Replies

5. Shell Programming and Scripting

What's wrong with my script ....

Please see below mentioned my script ... it ran once without any issue .... then after it is not coming out .... please suggest what is wrong? #!/bin/ksh ## if (( ${num_errors} > 0 )); export ACULOG=/home/varshnes/input export num_errors=10 **** Search for 'Start correcting roll up... (7 Replies)
Discussion started by: heyitsmeok
7 Replies

6. Shell Programming and Scripting

Script Gone Wrong

Hello all, so this is a script i did for an assignement, - first option greets the user according to the time after fetching his name - second options isn't implemented - third check the performance according to how many users are using the system - creates a log of names, time and ip of the... (14 Replies)
Discussion started by: ibzee33
14 Replies

7. Shell Programming and Scripting

what is wrong with this script?

Hi I've made a short script but it is not working. Can some pl. help me out in this? ./123.sh #! /usr/bin/ksh # for changing to this directory cd /layered/relational/scripts When I run the above scripts, it doesn't change to the above directory. I don't what is the problem? the... (2 Replies)
Discussion started by: Mike1234
2 Replies

8. UNIX for Dummies Questions & Answers

what is wrong with this script?

Hi, I have this example script which gives error ": unexpected operator/operand". I need the '' brackets for operator precedence. #!/bin/ksh x="abc" y="xyz" z="123" if -a then print "yes" else print "no" fi Thanks (2 Replies)
Discussion started by: rs1969
2 Replies

9. Shell Programming and Scripting

What is wrong with this script?

I keep getting errors messages for the "else" statement at line 81? #!/bin/ksh ######### Environment Setup ######### PATH=/gers/nurev/menu/pub/sbin:/gers/nurev/menu/pub/bin:/gers/nurev/menu/pub/mac :/gers/nurev/menu/adm/sbin:/gers/nurev/menu/adm/bin:/gers/nurev/menu/adm/mac:/ge... (8 Replies)
Discussion started by: heprox
8 Replies

10. UNIX for Dummies Questions & Answers

What is wrong with my script?

Hey guys, can someone help me with this script... #!/bin/sh dir=`pwd` for i in *.f do if then M=`wc -l < ${i} sed -e 's://.*::' < ${i} | \ (echo "//${i} -"$M ; cat - ) > $i.tmp chmod 700 $i ; mv ${i}.tmp $i ... (6 Replies)
Discussion started by: Lem2003
6 Replies
Login or Register to Ask a Question