Shell Programming and Scripting

I'm new to programming and need some help with the syntax. I am receiving a syntax error when running this script.

syntax error at line 25 : `}' unexpected

Thanks.


#!/bin/ksh

umask 002
for i in `symcfg list | grep ^" 0" | cut -c13-16`
do
{
print "Creating File: " Symopt_Check_$i
symoptmz -sid $i -parms show > Symopt_Check_$i
if [ $? -eq 0 ] ; then
print "symoptmz finished successfully for " $i
continue
else
print "symoptmz halted"
print "Would you like to continue to next symm? [Yes|No] "
read answer
case $answer in
Yes|yes|Y|y)
continue
;;
No|no|N|n)
break
;;
esac
}
done
print "Searching for Verizon_Performance_Window"
sleep 1
ls Symopt_Check_[0-9][0-9][0-9][0-9] | sort > Symopt1
grep "Verizon_Performance_Window" Symopt_Check_[0-9][0-9][0-9][0-9] | awk '{ print $1 }' | cut -c1-17 | sort > Symopt2
print "The files which do not contain Verizon_Performance_Window are:"
diff Symopt1 Symopt2 | grep Symopt | cut -c3-
print "Would you like to remove the files created when running this script? [Yes|No] "
read answer
case $answer in
Yes|yes|Y|y)
rm Symopt_Check_[0-9][0-9][0-9][0-9] Symopt1 Symopt2
;;
No|no|N|n)
print "It is recommended the files are removed manually before running the script again."
print "rm Symopt_Check_[0-9][0-9][0-9][0-9] Symopt1 Symopt2"
;;
esac
umask 022

You are missing one "fi" in line 24, just after "esac" and before "}".

Thanks. That worked! Now there is something I want to add to the program. Anytime inside the for loop if CTRL-C is pressed, I want the program to run a function prompting the user to either continue with the next variable in the loop or end. I'm not too familiar with traps so wanted to be sure the code I'm using is right. Here is what I have so far.

#create a function at beginning of script
function sigint_handler
{
print "Would you like to continue with the next symm? [Yes\No]"
read answer
case $answer in
Yes|yes|Y|y)
continue;;
No|no|N|n)
break;;
esac
}

# Place inside for loop after if statement
trap sigint_handler INT #Run function if CTRL-C is pressed
trap - INT #Reset SIGINT to default setting

Well, the script is coming along, but I'm stuck here and sure there is a simple answer. The entire updated script is pasted just below followed by the output it currently gives with my notes what I want it to actually do.

#!/bin/ksh

function sigint_handler
{
print "Would you like to continue with the next symm? [Yes\No]"
read answer
case $answer in
Yes|yes|Y|y)
print "symoptmz halted on " $i ": Skipping"
continue
;;
No|no|N|n)
print "symoptmz halted on " $i ":Skipping to search..."
break
;;
esac
}

umask 002
trap sigint_handler INT
rm Symopt_Check_[0-9][0-9][0-9][0-9] Symopt[1-2] > /dev/null 2>&1
for i in `symcfg list | grep ^" 0" | cut -c13-16`
do
{
print "Creating File: " Symopt_Check_$i
symoptmz -sid $i -parms show > Symopt_Check_$i
if [ $? -eq 0 ] ; then
print "symoptmz finished successfully for " $i
continue

fi
}
done
print "Searching for Performance_Window"
sleep 1
ls Symopt_Check_[0-9][0-9][0-9][0-9] | sort > Symopt1
grep "Performance_Window" Symopt_Check_[0-9][0-9][0-9][0-9] | awk '{ print $1 }' | cut -c1-17 | sort >
Symopt2
print "The files which do not contain Performance_Window are:"
diff Symopt1 Symopt2 | grep Symopt | cut -c3-
trap - INT
umask 022
----------------------------------------------------------------------

Creating File: Symopt_Check_1056
symoptmz finished successfully for 1056
Creating File: Symopt_Check_2107
^CWould you like to continue with the next symm? [Yes\No]
yes
symoptmz halted on 2107 : Skipping

##Good so far, it continued to the next one after hitting Ctrl-C and choosing 'yes'##

Creating File: Symopt_Check_3367
symoptmz finished successfully for 3367
Creating File: Symopt_Check_5011
^CWould you like to continue with the next symm? [Yes\No]
no
symoptmz halted on 5011 :Skipping to search...
Creating File: Symopt_Check_1176

##Not quite what I want. It should end the for loop if I choose 'no' after hitting Ctrl-C##

symoptmz finished successfully for 1176
Creating File: Symopt_Check_1345

##I stopped the output here. Whether I choose 'Yes' or 'No' the entire for loop runs. How do I end the for loop if I choose 'No' and just move on to Searching for Performance Window?##