Shell Programming and Scripting

instead of escaping ! , u have escaped " at line
echo "\!EnShAr!\"

change it to
echo "\!EnShAr\!"

Regards,
------------
Suman

okay my script for the shar section looks like this at the mo:

if
echo "cat > $file <<\!EnShAr!\"
echo "\!EnShAr!"
echo "set `cksum $file`"
echo"cksum" $file
check=$1
echo "test $1 = $check || echo $0: bad cksum in $file >&2 " >> sharS
echo "cat > $file <<\!EnShAr!" >> sharS
fi

-----------------------------------------------------------------------------------
If I do as told to do buy the last post:
"echo "cat > $file <<\!EnShAr\!"
Then it crashes at the fi not being expected,

if I don't it still crashes saying that the end of line is not expected at the end,

Any advice somebody?

Now you've done it...

Code:

if
then
  echo "cat > $file <<\!EnShAr\!"
  echo "\!EnShAr\!"
  echo "set `cksum $file`"
# Needed a space between echo and "cksum"
  echo "cksum" $file
# Is this supposed to be echoed?
  check=$1
  echo "test $1 = $check || echo $0: bad cksum in $file >&2 " >> sharS
  echo "cat > $file <<\!EnShAr\!" >> sharS
fi

Got to watch those exclamation marks. They mean something special in sh, even inside double quotes. Maybye make that !EnShAr! thing a variable so you don't have to type the various crazy escapings every time?

There is nothing wrong with this:

Code:

#! /usr/bin/ksh

for par ; do
        echo par = $par
done
exit 0

And that will work fine with the Bourne shell too. When a for statement does not have an explicit list, it will step through the positional parameters. Call that little script "fortest" and and it with:
./fortest one two three
It will work fine.

Next, shells have special characters like " and $ that mean special things. Generally a backshash will remove the special meaning from a special character. Now look at this line:
echo "cat > $file <<\!EnShAr!\"
You have removed the special meaning from the last quote so it does not match up with the first quote. So the shell reads the next line and find a normal quote there that ends the quoted string. Your quoted string contains a quote and it goes into a second line which is legal. Now everything is mexed up and the shell will finally barf on the last quote.

Have you tried running it on unix? it does not seem to work on mine, if you can show me a version you know works and I'll see if I'm the one with unix being difficult, thanks

i don't mean the whole thing by the way, just this shar section, i don't wanna have to rewrite the script to use differnt functions. Thanks for any help given

Hi, this is a cut down version that I have written from scratch to try and solve the problems I'm having:


#!/bin/sh
filevalidate()

{
case $# in
0) echo "Usage enshar file1 file2 ... > outputFile ! " > /bin/sharF/error ;;

*) for filename
do

if [ -d $filename ]; then
echo "invalid path name " > $filename > /bin/sharF/error
exit 2
fi

done ;;

esac
}

for filename in $*
do
filevalidate $filename
done

for filename in $*
do
echo cat \> $filename \<\<"\\!EnShAr\!"
cat < $filename
echo "\!EnShAr\!"
echo set \`cksum $filename\'
set `cksum $filename'
echo "test \$filename = $filename || echo \$0: BAD checksum in $filename > /bin/sharF/error"
done

exit 0

Does anyone see any issues? I could not get it to work so I took the end section from:

for filename in $*
do
echo cat \> $filename \<\<"\\!EnShAr\!"

and tried to run it alone, but an error occurs on line 7 to do with "`
Can someone check my ` ' " please and my redirection stuff, and if the cksum looks like that should work because I have been unable to test it.
Can someone please assist!!!