Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Can someone review my code tell me where I am going wrong?

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Can someone review my code tell me where I am going wrong?
# 1  
Old 07-28-2006
Can someone review my code tell me where I am going wrong?
Started writing my code.

my read input is not even asking nor working?

And I get a EOF script error.

Code:
echo "1) aragorn.domain.net"
echo "2) marvel.domain.net"
echo "3) athena.domain.net"
echo "4) gandalf.domain.net"
echo "5) griffin.domain.net"

echo "What server would you like to connect to?(1-5)
read input

if [$input=1]
 then
ssh aragorn.domain.net
elif [$input=2]
 then

ssh marvel.domain.net

elif [$input=3]
 then
ssh athena.domain.net

elif [$input=4]
 then
ssh gandalf.domain.net

elif [$input=5]
 then
ssh griffin.domain.net
else
        echo"wrong choice"
fi

# 2  
Old 07-28-2006
You need spaces:
Code:
[$input=1]

should be
Code:
[ $input = 1 ]

# 3  
Old 07-28-2006
By the way, another way to do what you are trying to do would be to use "select":

Code:
set -A domain aragorn.domain.net marvel.domain.net athena.domain.net gandalf.domain.net griffin.domain.net
PS3="What server would you like to connect to? (1-5): "
select mydomain in ${domain[*]}
 do
  ssh $mydomain
  break
done

Code:
1) aragorn.domain.net                            
2) marvel.domain.net                             
3) athena.domain.net                             
4) gandalf.domain.net                            
5) griffin.domain.net                            
What server would you like to connect to? (1-5):

$mydomain will be the domain, and $REPLY will be the number chosen by the user.
# 4  
Old 07-28-2006
I have the if commands working now.


Suppose that I wanted to include a command such as

if [ "$X" = "quit" ]; then


what would follow the then that would close out the script without error, if underneath that you did have many more else if statements?

chris
# 5  
Old 07-28-2006
You'd just need to exit then:
Code:
exit 0

Login or Register to Ask a Question

Previous Thread | Next Thread

7 More Discussions You Might Find Interesting

1. Programming

Code review: recursion in circular array, reduce two functions to one?

Hello, I think there's an easier way to do this but can't seem to recall but given an array of animals and an initial value is a random index in the array, here it's 3. 3,4,5,4,3,2,1,0,1,2,3,4,5,4,3,2,1,0... inifinite repeat a quick brute force solution i came up with was two functions, i... (6 Replies)
Discussion started by: f77hack
6 Replies

2. Shell Programming and Scripting

Request to code review Suggestions Plz

Hello All, I have 2 questions, 1) I am on Unix Sun Solaris korn shell, in my shell scripts i am using #!/bin/sh Instead of #!/bin/ksh, though it is still working is this correct way of doing and also I am saving the shell script file as abc.sh instead of abc.ksh, please let me know the best... (1 Reply)
Discussion started by: Ariean
1 Replies

3. UNIX for Advanced & Expert Users

Pls review this code and suggest if it can be written in a better way

Pls review this code and provide your feedbacks to make it more efficient.I have tried to add to each section. Code ############################################################### #!/bin/ksh RRSRC=/test RREP=/test #Directories test_dir=/test #Imp Files FILENAME=/test/files.txt #... (5 Replies)
Discussion started by: w020637
5 Replies

4. UNIX for Dummies Questions & Answers

Where can I review the source code?

A very n00b question: After compiling and installing software, where does the original source code reside? I'd like to study the source code of some of the ports I've installed. Thanks! :D (1 Reply)
Discussion started by: Aaron Van
1 Replies

5. Shell Programming and Scripting

What's wrong with this code?

Hello all, Can someone tell me why I'm getting an error in the following code: export return_code="$?" if then echo "load_shaw.sas failed." exit else echo "Trigger the next script..." # /path/to/next/script fi I get an error... (3 Replies)
Discussion started by: mmignot
3 Replies

6. Shell Programming and Scripting

Can some review my code would be appreicated?

I am getting an error "ftpNotes.sh: syntax error at line 8 : `<<' unmatched" #!/bin/ksh PATH=/usr/sbin/:/usr/bin:/usr/ucb:/etc:/usr/local/bin:. cd $HOME if ;then if ; then echo 'DSC file already ftp to epm server' else ftp -n epmdev00 <<SCRIPT... (1 Reply)
Discussion started by: sibghat
1 Replies

7. Shell Programming and Scripting

a piece of code, plz help to review

use "getopts" to get params from command. Need replace black with a specified string like "%20 DEFAULT_DELIM＝％20 ... while getopts dek:f:t:vh OPTION do case $OPTION in t) DELIM=`tvar=/'"$OPTARG"'/ svar="$DEFAULT_DELIM" awk 'BEGIN{T=ENVIRON;S=ENVIRON; while(index(T,S)!=0){S=S"0"};print... (0 Replies)
Discussion started by: anypager
0 Replies
Login or Register to Ask a Question