Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Bad substitution - ShellCheck says okay

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Bad substitution - ShellCheck says okay
# 8  
Old 02-02-2019
Quote:
Originally Posted by Xubuntu56
To answer the last question first, the script is producing the desired output: printing a legend for the different colors used by ls for each different type of file; i.e. di (directory) printed blue on a black background. I merely wanted it to do so without all the error messages.
So it is working, but with issues.
That is good to know, but please answer the other questions too. I'm not currently see any reason to keep the eval command in your script. If I knew why you had that line in your script, everything you're doing might suddenly make sense to me.
# 9  
Old 02-02-2019
I changed the script around a little bit. The "*." in many of the $LS_COLORS items is causing the problem. I couldn't figure out how to fix it in the for loop echo -e so I used sed to change the values before entering the loop. The 7 in 7z was also causing some issues, at least on my system. Here is the end result that I think does what you want:

Code:
#!/bin/bash
# color_meanings: explain meanings of colors used in bash ls

CLEAN_COLORS=`echo $LS_COLORS | sed -e 's/\*\.//g'`
{
        IFS=:
        for i in $CLEAN_COLORS
        do
		echo -e "\e[${i#*=}m$( x=${i%=*};echo "$x")\e[m"
        done
}

This User Gave Thanks to TioTony For This Post:
Xubuntu56
# 10  
Old 02-03-2019
Assuming that you really want to see the *.'s in the output, but just don't want the diagnostics, see what happens if you try:
Code:
#!/bin/bash
OIFS=$IFS
IFS=':='
array=( $LS_COLORS )

IFS=$OIFS
printf '%s %s\n' "${array[@]}" | while read -r color sequence
do	printf '\e[%sm%s\e[m\n' "$sequence" "$color"
done

This User Gave Thanks to Don Cragun For This Post:
Xubuntu56
# 11  
Old 02-03-2019
Just switch off globbing temporarily ? In the OP's example:
Code:
        IFS=:
        set -f
        for i in $LS_COLORS
        do
                echo -e "\e[${i#*=}m$( x=${i%=*}; [ -n "${!x}" ] && echo "${!x}" || echo "$x" )\e[m"
        done
        set +f

--
shellcheck will check syntax, but it cannot know what is in the variables.
Last edited by Scrutinizer; 02-03-2019 at 03:58 AM..
This User Gave Thanks to Scrutinizer For This Post:
Xubuntu56
# 12  
Old 02-03-2019
The problem in your approach in post #1 is bash's "indirection". man bash:
Quote:
Parameter Expansion
.
.
.
If the first character of parameter is an exclamation point (!), and parameter is not a nameref, it introduces a level of variable indirection.
That indirection works (in fact supplies an empty string) if x holds a string that could be a valid variable name but fails on * or . (which can't be part of a valid variable name).
@Scrutinizer: that's why the -f option doesn't take effect - no pathname expansion attempted.



May I question the use of indirection in your script? What do you want to achieve by using it? Your simplified script, purged from indirection, looks like
Code:
IFS=':'
for i in $LS_COLORS
   do   echo -e "\e[${i#*=}m${i%=*}\e[m"
   done
[[0mrs[[m
[[01;34mdi[[m
[[01;36mln[[m
[[00mmh[[m
[[40;33mpi[[m
[[01;35mso[[m
[[01;35mdo[[m
[[40;33;01mbd[[m
[[40;33;01mcd[[m
[[40;31;01mor[[m
[[00mmi[[m
[[37;41msu[[m
[[30;43msg[[m
[[30;41mca[[m
[[30;42mtw[[m
[[34;42mow[[m
[[37;44mst[[m
[[01;32mex[[m
[[01;31m*.tar[[m
[[01;31m*.tgz[[m
 [[01;31m*.arc[[m

and works perfectly well. I showed the console codes as the colours don't translate to html too well.


EDIT: Added the IFS defnition to enable the script's success...
Last edited by RudiC; 02-03-2019 at 06:14 PM..
This User Gave Thanks to RudiC For This Post:
Xubuntu56
# 13  
Old 02-03-2019
@Don Cragun: good approach, but I had to modify it slightly to make it run on my linux host, like:


Code:
printf '%s\n' "${array[@]}" | while IFS== read -r color sequence
  do    printf '\e[%sm%s\e[m\n' "$sequence" "$color"
   done

(print just one array element at a time, and split the line read at the = sign.)




EDIT: I have to apologize; my fault when creating array. Don Cragun's code works flawlessly if array is defined the way he did in his post, with an element pair per colour entry.
Last edited by RudiC; 02-03-2019 at 06:07 PM..
This User Gave Thanks to RudiC For This Post:
Xubuntu56
# 14  
Old 02-03-2019
Hi Xubuntu56...



Quote:
ShellCheck doesn't find any issues with this script.
REMEMBER!
ShellCheck ONLY checks validity and syntax of the shell in use, and NOT ALL shells.
For that is is simply superb. However don't expect it to check validity and syntax of transient commands.

A deliberate simple example from ShellCheck.


As you can see, 'sed' and 'sleep' will create an error and has absolutely no idea what 'junk_command' is.
Hope this helps.
Bad substitution - ShellCheck says okay-shellcheckpng
This User Gave Thanks to wisecracker For This Post:
Xubuntu56
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Bad substitution issues.. but why?

i am trying to prepare a train and test dataset, for which i need to randomly split the data into corresponding folders (train,test).. I began on a simple script, but seem to get som weird error messages, that i cannot make sense of?.. what am I doing wrong? #!/bin/bash RED='\033] then... (13 Replies)
Discussion started by: kidi
13 Replies

2. Shell Programming and Scripting

Bad substitution

Cant undestand :) why i have an error on line 2.it is working on my other boxes #!/bin/bash ret=$(echo Q | timeout 5 openssl s_client connect "${1`hostname`}:${2-443}" -ssl3 2> /dev/null) if echo "${ret}" | grep -q 'Protocol.*SSLv3'; then if echo "${ret}" | grep -q 'Cipher.*0000'; then ... (7 Replies)
Discussion started by: kenshinhimura
7 Replies

3. Shell Programming and Scripting

Why I get bad bad substitution when using eval?

Why I get bad replace when using eval? $ map0=( "0" "0000" "0") $ i=0 $ eval echo \${map$i} 0000 $ a=`eval echo \${map$i}` !!!error happens!!! bash: ${map$i}: bad substitution How to resolve it ? Thanks! (5 Replies)
Discussion started by: 915086731
5 Replies

4. Programming

Make: Bad Substitution

Hi, I have a make file which I try to execute, but it failed when it arrived to the line: for r in ${PIPESTATUS }; do if (($r != 0)); then exit $r; fi;done; With the Error: ""make:/bin/sh: Bad substitution"" Or the Error: "make:${PIPESTATUS[...}: Bad substitution" (Depend on the operating... (3 Replies)
Discussion started by: nadne
3 Replies

5. Shell Programming and Scripting

bad substitution error!

Hi All, I'm building a new shell script but i'm facing a problem with one line which is giving "bad substitution" error. Please assist script lines: #!/bin/sh printf "%s: " "Occurrence DATE (YYYYMMDD)"; read DATE shortdate=${DATE#??} o/p: ./test1: bad substitution This command is... (2 Replies)
Discussion started by: Dendany83
2 Replies

6. UNIX for Dummies Questions & Answers

bad substitution

#!/bin/bash a1=( win 12,01,02,03,04 ) a2=( pre 04,05,06 ) a3=( msn 06,07,08,09 ) Given the above arrays, I want the script to return/echo the following in a loop; win 12,01,02,03,04 pre 04,05,06,07 msn 06,07,08,09 But I can't get it to do as such. I've tried; (2 Replies)
Discussion started by: Muhammad Rahiz
2 Replies

7. Shell Programming and Scripting

bad substitution error in ksh

Hello, In bash I can use the following: TMP=12345 MID=${TMP:1:1} the expected result is: 2 but when using KSH I'm getting a ''bad substitution" error. What is the correct syntaxin ksh? Thanks (2 Replies)
Discussion started by: LiorAmitai
2 Replies

8. Shell Programming and Scripting

bad substitution error in ksh

hi, i created a shell script having the following content: #! /usr/bin/ksh FROM="myemail@domain.com" MAILTO="someemail@domain" SUBJECT="TEST" BODY="/export/home/adshocker/body.txt" ATTACH="/export/home/adshocker/attach.prog" echo $ATTACH ATTACH_NAME="${ATTACH##*/}" echo $ATTACH_NAME... (5 Replies)
Discussion started by: adshocker
5 Replies

9. Shell Programming and Scripting

Array reference - bad substitution

I've created a series of arrays named as follows: row1 row2 row3 . . . row10 Each has 4 elements. I'm trying to echo the array elements out in a for loop. Here's what I have: for ((i=1;i<=10;i++)) do for ((j=1;j<=4;j++)) do eval out=${row`echo $i`} echo -n $out (3 Replies)
Discussion started by: swankgd
3 Replies

10. Shell Programming and Scripting

Bad Substitution

Need Help... I am getting a bad substitution error on my script on a Solaris Server. However the script has been proven to work on HPUX and Solaris servers... #!/usr/bin/sh # # Set the location of the tzupdater.jar file # JAR=/tmp/tzupdater.jar # <<<<< UPDATE THIS LINE... (3 Replies)
Discussion started by: D_Redd74
3 Replies
Login or Register to Ask a Question