Shell Programming and Scripting

Hello Team,

In my shell script, it stopped without killing it.
Could you please help why ?
Below is the code :

Code:

get_dpi44_currentFiles()
{
	truncate --size 0 $dpi_44_fixed_currentFileList
	if ssh $dpi_srvr_44 -p 2222 "ls $dpi_44_sourceFilesDir/fixed | grep '\.tgz$'" > $dpi_44_fixed_currentFileList 2>/dev/null
	then
	Currentfilecount=`wc -l ${dpi_44_fixed_currentFileList}`
	echo -e "`date` Current File List Count for 44 fixed, server port 2222 is :${Currentfilecount} \n" >> $successlog
	else
	echo -e "`date` Connection refused $dpi_srvr_44 \n" >> $failurelog
	Currentfilecount=`wc -l $dpi_44_fixed_currentFileList`
	echo -e "`date` Current File List Count for 44 fixed, server port 2222 is :${Currentfilecount} \n" >> $failurelog
	cp  $dpi_44_fixed_pulledFileList $dpi_44_fixed_currentFileList
	Currentfilecount=`wc -l $dpi_44_fixed_currentFileList`
	echo "`date` Updated Current File List Count due to connection failure from Pulled File list for 44 fixed, server port 2222 is :${Currentfilecount}" >> $failurelog
	break;
	fi
	
}

pulling_dpi44Files()
{
while true
do
	get_dpi44_currentFiles
done
}
pulling_dpi44Files

Kindly guide is this stopped due to break command used in else condition ?

Any results prior to exiting, like output or error messages? Did you try with the -x option set?

@RudiC No, i am worrying and just wanted to confirm does break can impact the while true condition if the ssh connection refused ?
or it will break and keep on running again and again due to while true condition.

Kindly guide.

You say: "It stopped". Please show context.

This is not in line with what you said before.


Impossible without further info.

it was running on crontab and get know about it after 10 days, as the log file last access was. when investigated found the ssh connection refused. My script condition on connection refused have break command. so wondering does it cause to stop. I restarted the script and running fine. but lost 10 days of data.

To be honest i fail to see a justification for the break reserved word here. The purpose of break is to get out of loops like this:

Code:

while <condition> ; do
     something
     if <other-condition> ; then
          break
     fi
done

Which will cause the while .. do....done to be left when "other-condition" is met. Still, break (as well as its companion continue) should be used with extreme care or rather be avoided in most cases. They both are in fact thinly veiled GOTOs and there is a reason why structured programming languages without GOTOs were invented - it simply makes the task of keeping up with understanding (your own) code and the program flow a lot easier.

So, let us take a step back: what are you trying to achieve? State a clear and complete problem and we sure can work out a solution which does not depend on break or similar constructs.

Another possibility is: ssh allocates a terminal and therefore captures <stdin> - as does while. Alas, what one usually experiences is not that it fails permanently but a rather inconsistent behavior of "sometimes it works, sometimes not". Might it be that this is the case here?

I hope this helps.

bakunin

PS: on second thoughts, you should also get rid of the echos and the backticks - both are antiquated, deprecated and not best practice for quite some long time now.

bakunin