Script works, but I think it could be better and faster


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Script works, but I think it could be better and faster
# 8  
Old 11-14-2018
That doesn't seem to work properly. It places the files on one line again and I can't get it fixed....
here is what it logs:

Code:
+ for file in ${FNARR[*]}
+ sshpass -f /home/cornelis/PycharmProjects/BashProjects/conf_files_properties/password_file scp -o GSSAPIAuthentication=no -o GSSAPIKeyExchange=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -rpq root@192.168.122.74:/etc/httpd22/conf.d/proxy_ajp.conf root@192.168.122.74:/etc/httpd22/con...d_cluster.conf root@192.168.122.74:/etc/httpd22/con...workers.prorperties root@192.168.122.74:/etc/httpd22/conf.d/mod_jk.conf root@192.168.122.74:/etc/famed/defac...ponents.properties root@192.168.122.74:/etc/jbossas/domain/domain.xml root@192.168.122.74:/etc/jbossas/domain/host.xml root@192.168.122.74:/etc/jbossas/domain/host-master.xml root@192.168.122.74:/etc/jbossas/domain/host-slave.xml /home/cornelis/config_files_properties/192.168.122.74
scp: /etc/httpd22/conf.d/proxy_ajp.conf: No such file or directory

I can see why it can't find it, but the for loop doesn't fix that anymore.

I have it like this at the moment:

Code:
index=0
readarray FNARR < $home_dir/files
while read SVNM
  do if [[ ! -d "$dest_dir/$SVNM" ]]; then
    mkdir -p $dest_dir/$SVNM
     fi
    for file in ${FNARR[*]}
        do

   sshpass -f $ssh_pass scp -o GSSAPIAuthentication=no -o GSSAPIKeyExchange=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -rpq ${FNARR[@]/#/$ssh_user@$SVNM:} $dest_dir/$SVNM



   #sshpass -f $ssh_pass scp -o GSSAPIAuthentication=no -o GSSAPIKeyExchange=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -rpqv $ssh_user@$SVNM:$file $dest_dir/$SVNM
        done

   done < $home_dir/test_server_names

xdg-open $dest_dir


Last edited by cornelvis; 11-14-2018 at 10:12 AM..
# 9  
Old 11-14-2018
Does /etc/httpd22/conf.d/proxy_ajp.conf exist on 192.168.122.74?


And, what did we (better: you) find earlier? Prove validity of approach with a single or few files ...
# 10  
Old 11-14-2018
On 192.168.122.74 they do exist, but it seems like it just gets to that entry only and doesn't read the list anymore.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Shell script works fine as a standalone script but not as part of a bigger script

Hello all, I am facing a weird issue while executing a code below - #!/bin/bash cd /wload/baot/home/baotasa0/sandboxes_finance/ext_ukba_bde/pset sh UKBA_publish.sh UKBA 28082015 3 if then echo "Param file conversion for all the areas are completed, please check in your home directory"... (2 Replies)
Discussion started by: ektubbe
2 Replies

2. Shell Programming and Scripting

Optimize shell script to run faster

data.file: contact { contact_name=royce-rolls modified_attributes=0 modified_host_attributes=0 modified_service_attributes=0 host_notification_period=24x7 service_notification_period=24x7 last_host_notification=0 last_service_notification=0 host_notifications_enabled=1... (8 Replies)
Discussion started by: SkySmart
8 Replies

3. Shell Programming and Scripting

Making script run faster

Can someone help me edit the below script to make it run faster? Shell: bash OS: Linux Red Hat The point of the script is to grab entire chunks of information that concerns the service "MEMORY_CHECK". For each chunk, the beginning starts with "service {", and ends with "}". I should... (15 Replies)
Discussion started by: SkySmart
15 Replies

4. Shell Programming and Scripting

Make script faster

Hi all, In bash scripting, I use to read files: cat $file | while read line; do ... doneHowever, it's a very slow way to read file line by line. E.g. In a file that has 3 columns, and less than 400 rows, like this: I run next script: cat $line | while read line; do ## Reads each... (10 Replies)
Discussion started by: AlbertGM
10 Replies

5. Shell Programming and Scripting

Script to parse a file faster

My example file is as given below: conn=1 uid=oracle conn=2 uid=db2 conn=3 uid=oracle conn=4 uid=hash conn=5 uid=skher conn=6 uid=oracle conn=7 uid=mpalkar conn=8 uid=anarke conn=1 op=-1 msgId=-1 - fd=104 slot=104 LDAPS connection from 10.10.5.6 to 10.18.6.5 conn=2 op=-1 msgId=-1 -... (7 Replies)
Discussion started by: sags007_99
7 Replies

6. Shell Programming and Scripting

Script works with bash 3.0 but not 3.2.

Hello, So my knowledge of bash scripting is not that great and I have been trying to solve this problem on my own for awhile to no avail. Here's the error I get when running it with an OS that uses bash 3.2.x: testagain.sh: line 10: *-1: syntax error: operand expected (error token is... (2 Replies)
Discussion started by: forkandspoon
2 Replies

7. Shell Programming and Scripting

Can anyone make this script run faster?

One of our servers runs Solaris 8 and does not have "ls -lh" as a valid command. I wrote the following script to make the ls output easier to read and emulate "ls -lh" functionality. The script works, but it is slow when executed on a directory that contains a large number of files. Can anyone make... (10 Replies)
Discussion started by: shew01
10 Replies

8. UNIX for Advanced & Expert Users

Country Codes script faster response ;please help

Dear all I have group of input lines which look like this These input lines is placed in a file named phonelines.txt and there is a script which match $4 and $5 with country codes placed in another file named country-codes.txt and its contents is : Italy 39 Libyana 21892 Thuraya... (12 Replies)
Discussion started by: zanetti321
12 Replies

9. Shell Programming and Scripting

perl - how come this script works?

#!/usr/bin/perl open (DATA, file.txt); @array = <DATA>; close (DATA); open (DATA, ">$file.txt"); for (@array) { s/text/replace text/; push(@contents,$_); } seek(DATA, 0, 0); print DATA (@contents); close(DATA); could someone please explain how this works. i've been... (3 Replies)
Discussion started by: mjays
3 Replies

10. Shell Programming and Scripting

Script works fine until I | more

Hello all, This beats me. I have a script that executes some commands and redirects their output to some text files that I will parse. The commands are along the lines of: dsmadmc -id=admin -pa=admin -outfile=/home/tools/qlog.txt q log f=d If I just run the script it works. If I execute... (2 Replies)
Discussion started by: Skovian
2 Replies
Login or Register to Ask a Question